Date:   Tue, 11 Jan 2022 15:25:10 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Wayne Chang <waynec@nvidia.com>
Cc:     "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Sing-Han Chen <singhanc@nvidia.com>
Subject: Re: [PATCH v2 1/1] ucsi_ccg: Check DEV_INT bit only when starting
 CCG4
Message-ID: <Yd2TRuUaZfG/+RQJ@kroah.com>
References: <20220111133643.589346-1-waynec@nvidia.com>
 <Yd2OTRrtP1XgxmHA@kroah.com>
 <a8b185cb-3f4b-9d57-7eb5-7c09dd3bb5aa@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a8b185cb-3f4b-9d57-7eb5-7c09dd3bb5aa@nvidia.com>
Precedence: bulk

On Tue, Jan 11, 2022 at 02:15:17PM +0000, Wayne Chang wrote:
> Hi Greg,
> Thanks for the review.
> 
> On 1/11/22 10:03 PM, Greg KH wrote:
> > 
> > 
> > On Tue, Jan 11, 2022 at 09:36:43PM +0800, Wayne Chang wrote:
> >> From: Sing-Han Chen <singhanc@nvidia.com>
> >>
> >> after driver sending the UCSI_START cmd, CCGx would
> >> clear Bit 0:Device Interrupt in the INTR_REG if CCGX
> >> reset successfully.
> >>
> >> however, there might be a chance that other bits in
> >> INTR_REG are not cleared due to internal data queued
> >> in PPM and cause the driver thinks CCGx reset failed.
> >>
> >> the commit checks bit 0 in INTR_REG and ignore other
> >> bits. ucsi driver would reset PPM later.
> >>
> >> Signed-off-by: Sing-Han Chen <singhanc@nvidia.com>
> >> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> >> ---
> >>   drivers/usb/typec/ucsi/ucsi_ccg.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > What commit id does this fix?
> The change is to fix the defect of ucsi_ccg_init func based on the CCGx 
> spec.
> The original implementation's commit Id is i247c554a14aa1.

Great, can you resend this with a proper "Fixes:" tag on it?

thanks,

greg k-h