From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc:     linux-media@vger.kernel.org,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Rob Herring <robh+dt@kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Prabhakar <prabhakar.csengg@gmail.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 11/13] media: s5p-g2d: Use platform_get_irq() to get
 the interrupt
Date:   Tue, 11 Jan 2022 15:49:06 +0100
In-Reply-To: <20220111002314.15213-12-prabhakar.mahadev-lad.rj@bp.renesas.com>
        (Lad Prabhakar's message of "Tue, 11 Jan 2022 00:23:12 +0000")
Message-ID: <dleftjtuea8h0d.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20220111002314.15213-12-prabhakar.mahadev-lad.rj@bp.renesas.com>
        <CGME20220111144930eucas1p1d538f02d731983b1cd1b56472163eda4@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2022-01-11 wto 00:23>, when Lad Prabhakar wrote:
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2
> * No change.
> ---
>  drivers/media/platform/s5p-g2d/g2d.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>

Acked-by: =C5=81ukasz Stelmach <l.stelmach@samsung.com>

> diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platfor=
m/s5p-g2d/g2d.c
> index fa0bb31bd2b9..dd8864779a7c 100644
> --- a/drivers/media/platform/s5p-g2d/g2d.c
> +++ b/drivers/media/platform/s5p-g2d/g2d.c
> @@ -623,7 +623,6 @@ static int g2d_probe(struct platform_device *pdev)
>  {
>  	struct g2d_dev *dev;
>  	struct video_device *vfd;
> -	struct resource *res;
>  	const struct of_device_id *of_id;
>  	int ret =3D 0;
>=20=20
> @@ -664,14 +663,11 @@ static int g2d_probe(struct platform_device *pdev)
>  		goto put_clk_gate;
>  	}
>=20=20
> -	res =3D platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> -	if (!res) {
> -		dev_err(&pdev->dev, "failed to find IRQ\n");
> -		ret =3D -ENXIO;
> +	ret =3D platform_get_irq(pdev, 0);
> +	if (ret < 0)
>  		goto unprep_clk_gate;
> -	}
>=20=20
> -	dev->irq =3D res->start;
> +	dev->irq =3D ret;
>=20=20
>  	ret =3D devm_request_irq(&pdev->dev, dev->irq, g2d_isr,
>  						0, pdev->name, dev);

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmHdmOIACgkQsK4enJil
gBCanwf6Aru4u2Ip5vQSlbsLmuYJXeqaKjnZarh/si7gSktxJKWL9tl+cfJlVnq6
vcsePMsFPuHU/nkLTgJRNnKXaM/nkftkZfsZ42rZ9yQe3iD2C8qeZFsLiF+g4jlR
CDn+M0YYM+aLgWqj+MotiX/ZHzouMGepc8P/9N2KyV84T1BVWKAFVXZEJFBk8oh0
7HO0nuFsTiX9jA1QBGFc3mIasm9xRWqfHt93g3YyEKZr9vomGLNhbGGdjlA03pts
ZXrx9vXU5aLRXQWvwbkFY2wp6Rny8kQBEeqrratzVL3roNHWDKHnv/Z+H3dm7vhz
XNToe3GrDtW9mLwdSrt7oA5NTURIsw==
=7fYZ
-----END PGP SIGNATURE-----
--=-=-=--