Message-ID: <b649e6ad-54c7-abfa-c9cd-45c0a99f56b1@linux.ibm.com>
Date:   Tue, 11 Jan 2022 08:51:59 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] fsi: core: Check error number after calling
 ida_simple_get
Content-Language: en-US
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, jk@ozlabs.org,
        joel@jms.id.au, alistair@popple.id.au
Cc:     linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <20220111073411.614138-1-jiasheng@iscas.ac.cn>
From:   Eddie James <eajames@linux.ibm.com>
In-Reply-To: <20220111073411.614138-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 1/11/22 01:34, Jiasheng Jiang wrote:
> If allocation fails, the ida_simple_get() will return error number.
> So master->idx could be error number and be used in dev_set_name().
> Therefore, it should be better to check it and return error if fails,
> like the ida_simple_get() in __fsi_get_new_minor().


Reviewed-by:  Eddie James <eajames@linux.ibm.com>


>
> Fixes: 09aecfab93b8 ("drivers/fsi: Add fsi master definition")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>   drivers/fsi/fsi-core.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
> index 59ddc9fd5bca..92e6eebd1851 100644
> --- a/drivers/fsi/fsi-core.c
> +++ b/drivers/fsi/fsi-core.c
> @@ -1309,6 +1309,9 @@ int fsi_master_register(struct fsi_master *master)
>   
>   	mutex_init(&master->scan_lock);
>   	master->idx = ida_simple_get(&master_ida, 0, INT_MAX, GFP_KERNEL);
> +	if (master->idx < 0)
> +		return master->idx;
> +
>   	dev_set_name(&master->dev, "fsi%d", master->idx);
>   	master->dev.class = &fsi_master_class;
>