Message-ID: <f70c75a6-c816-8b20-797e-eda11ffed3a8@oracle.com>
Date:   Tue, 11 Jan 2022 09:04:43 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v19 03/13] kdump: make parse_crashkernel_{high|low}()
 static
Content-Language: en-US
To:     Zhen Lei <thunder.leizhen@huawei.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
        linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>,
        Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
        Eric Biederman <ebiederm@xmission.com>,
        kexec@lists.infradead.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        linux-doc@vger.kernel.org
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Feng Zhou <zhoufeng.zf@bytedance.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Chen Zhou <dingguo.cz@antgroup.com>
References: <20211228132612.1860-1-thunder.leizhen@huawei.com>
 <20211228132612.1860-4-thunder.leizhen@huawei.com>
From:   john.p.donnelly@oracle.com
In-Reply-To: <20211228132612.1860-4-thunder.leizhen@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHRaUkdtMllKcVhsSUl6bGY4WndORGc2NFZJV1paU2VjZjI3TmJxRWloc1lQ?=
 =?utf-8?B?MER2V2hTNEkzY0xKenZnbm5GZFROSGRzbGpqWGVLbUtNMzRsYzRlS2xHZmF2?=
 =?utf-8?B?SXBlUEgzdTZseGZTc0JLbDd4MmJNbGIvYnMxOFphM29DdFhQbzlxbXVxMnRT?=
 =?utf-8?B?Ynl6RkhpS2tlWlAwUWg5cXg2bnJtQ0M2anRCaGgvcUY4V2prRjd2R1Ivb2tt?=
 =?utf-8?B?RVR6blhqMGJVaXh0K1NrK1JTZXlISThuYUFmblhJTTZqazMwaVFWaU9IVU12?=
 =?utf-8?B?M1dSNnNjdXhZWGdERTJBOUU4L29OcUZhaVhWRWNhSWZteW5wc2JhMk4xcjdL?=
 =?utf-8?B?c1dCYllraWJ5SlRTN0hUbU1ZSEQvTXFYbzMwYmkybW15TkhlOW5SNEhNRXRM?=
 =?utf-8?B?bUtUZkJNVWhtOWJ5Mnlub1RrZmpZcUpUazJuVitWSGFOdlJYZkMvUjU0c2x0?=
 =?utf-8?B?ZnhQUmNQcDU4cTVGWlVGeGg1cDN0RW1XSE9WVzlLSE9ZUTdPeXdPYVg4MDhn?=
 =?utf-8?B?NXJnaGd2dnpIeExYR1J0VFp1KytLTUx6b1RyM082cE9FaHFRSE1LcWV3eHc3?=
 =?utf-8?B?UHpPZ0RObUhXMHh3QUtWcWVFdFBnSkNISzc3RkU1SC9kMThlN1g4MlZVR1Vq?=
 =?utf-8?B?Nm5rS3J5WlFySWU4Mkp2WHFHMTdndUpyd3p6cFExYVdhU3g2NEFsWC9wMmk1?=
 =?utf-8?B?QmVQZVJFbThwS3hDQUlaakxlS29mY01uTk8rRndQUUxqZ004dCsyV21LMVJC?=
 =?utf-8?B?MGZ1ZEI4K3prcGR5Tm9kS3duUWFjNlpINElPVFM4QzBHZ2IxcmFzL3NnNjZZ?=
 =?utf-8?B?dWx5cDllUUdERExDcEFWOVk1MHd1SU9nZktybC8vWnBIUFZFZzFBRHpOTGVZ?=
 =?utf-8?B?bllZL0dHbzQ2SWU3bWM3VW9FaUJOZnFzZmJ2NjdMWlEyWWlYaHZZYkxLaklE?=
 =?utf-8?B?VmlPdDFpa1NwYzBmZWphUldiWjgybmdEc1hBRitHWHZscyt2Z0R3ZlVIMTlw?=
 =?utf-8?B?YzZWY0tHUVJzNk1QSi9QcjhLMEdFa1ROSHQya0dkU0JiblNxNjFoUGNkakRD?=
 =?utf-8?B?UUlmSmtlN3FLUGpjRmIvZGljV3VjOHd0VUsyaEllakNrR0JsazVxMHhNN3FK?=
 =?utf-8?B?RlVCYWIzbzJpQjQ2a0dJaWtIUWlzTWdRbTduRm43UGxkZlFRRHZQRmpvellS?=
 =?utf-8?B?UzRORXFMM1hrUTlxZDI0YlJhZXZ3NUhKU0xHNEQ5UTgvdG5SUUpYeUV5eDJD?=
 =?utf-8?B?TWIxdnkwOUJiTXdPLzlqVkVoc0hIZXE3ZFhCVllqWUFqT3FyNDh2KzFYT01E?=
 =?utf-8?B?T1VYZTRrdjI1b0t6MlJvMUpTOHdMV0tlOXllVUpFOWdGZG5iZ0NQbmVUUXVO?=
 =?utf-8?B?ZFRLR0pTdHRSd3k0WW9vSUZPbFJjVWZjdzJjYWtiWUpoZVVzb1Z5Q0xuL3Bi?=
 =?utf-8?B?a2R6SUgrQmNGcmZiYWF3OFdFcm9EOG5tZ0lXWnp3RWIrUkV6SkRBTGJCbVFl?=
 =?utf-8?B?eWVkaGMzRmNrUGthQnllTTlEdkRoaHhHUjZOZ05wdmpLTFlrbm5tYkcrazFE?=
 =?utf-8?B?eHc2U094eFZmR09seEtvOTRJZWUxRkRzTHRXb0tHS0tKNUVSUlpXUy9PQklN?=
 =?utf-8?B?ZElnY05rcGRxNHVDb1VHZjJROVNDTlpGRmdCMi9MWU84UEpOa0NmcllLay9K?=
 =?utf-8?B?NUlZbHZjeVpjNzdTdjFlRFJiY2ZUU0FldlYyZXMwekxjZzdTaWc3dndkVGpu?=
 =?utf-8?B?M2doSmthU1U2c3ZFdXpXQVR6d3dsQ0NETzBHQTBaYTlEUTlvTDN1c3RHM2NB?=
 =?utf-8?B?cjVnckova1QvUlZKUUE0K2ZaMTVUTTBqTUUwNkU3TC9sRnlEdzBScU52bVky?=
 =?utf-8?B?SW1RNC9wdjdobHE2ZmFjT2czQXoxRUYxNTltRCtQNVArNnFjWFV2QnRZRVVK?=
 =?utf-8?B?NllGYzJNSWRaZzdSUzJvWG51MUFOZnlPZXBlN0hrOEh5SjN3dUZheHEwNGp3?=
 =?utf-8?B?V2NlQ0YwWk1KZko1Y1owZkZCekk5NnVEWllXRFZ1dkpoK2xmbnZjRElncTRT?=
 =?utf-8?B?Z0FxbzFnOXFieldkQURXci83S2JKcU1haXMrVjJNak9wZFROdVRHVFJkbDBP?=
 =?utf-8?B?MUpiNW5SbHRicVkyMmtYbHI0YnlkN2ppNk1SbTExTEJaeWNBeFE0QlZTRlRB?=
 =?utf-8?B?d0Y3Rk15bnExWVJVVTAveVdaS1V5T2FGL2l0WFd2WVBFOXJTYXVCZ2ZGNmJ0?=
 =?utf-8?B?Rm1EaFZZMHc0dVNOZmgrN1E5ZmJ3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a87666cf-288f-4ee4-b930-08d9d513bbc4
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 15:04:58.3149
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6cpE4eKZvCuWzjXASzvFDxLt6Uj7Mmtgz/6tZeIosifcZ5NPhg4Vl/95FWkoJo5kGZrIZnXfxvqOtzehNml/dkM3TLPgSdjXI0gH0E53aJI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5881
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10223 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201110089
X-Proofpoint-GUID: LxKlFoY-ghPYa-zPSKXWUEfTmXRqLnn3
X-Proofpoint-ORIG-GUID: LxKlFoY-ghPYa-zPSKXWUEfTmXRqLnn3
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/28/21 7:26 AM, Zhen Lei wrote:
> Make parse_crashkernel_{high|low}() static, they are only referenced by
> parse_crashkernel_high_low() in the same file. The latter is recommended.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
 >
Acked-by: John Donnelly  <john.p.donnelly@oracle.com>

> ---
>   include/linux/crash_core.h | 4 ----
>   kernel/crash_core.c        | 4 ++--
>   2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h
> index 2d3a64761d18998..598fd55d83c169e 100644
> --- a/include/linux/crash_core.h
> +++ b/include/linux/crash_core.h
> @@ -79,10 +79,6 @@ void final_note(Elf_Word *buf);
>   
>   int __init parse_crashkernel(char *cmdline, unsigned long long system_ram,
>   		unsigned long long *crash_size, unsigned long long *crash_base);
> -int parse_crashkernel_high(char *cmdline, unsigned long long system_ram,
> -		unsigned long long *crash_size, unsigned long long *crash_base);
> -int parse_crashkernel_low(char *cmdline, unsigned long long system_ram,
> -		unsigned long long *crash_size, unsigned long long *crash_base);
>   int __init parse_crashkernel_high_low(char *cmdline,
>   				      unsigned long long *high_size,
>   				      unsigned long long *low_size);
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 8966beaf7c4fd52..3b9e01fc450b2a4 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -277,7 +277,7 @@ int __init parse_crashkernel(char *cmdline,
>   					"crashkernel=", NULL);
>   }
>   
> -int __init parse_crashkernel_high(char *cmdline,
> +static int __init parse_crashkernel_high(char *cmdline,
>   			     unsigned long long system_ram,
>   			     unsigned long long *crash_size,
>   			     unsigned long long *crash_base)
> @@ -286,7 +286,7 @@ int __init parse_crashkernel_high(char *cmdline,
>   				"crashkernel=", suffix_tbl[SUFFIX_HIGH]);
>   }
>   
> -int __init parse_crashkernel_low(char *cmdline,
> +static int __init parse_crashkernel_low(char *cmdline,
>   			     unsigned long long system_ram,
>   			     unsigned long long *crash_size,
>   			     unsigned long long *crash_base)