Message-ID: <6dbf6d62-a860-4b69-5ea0-f540d52dbf43@oracle.com>
Date:   Tue, 11 Jan 2022 09:05:28 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v19 04/13] kdump: reduce unnecessary parameters of
 parse_crashkernel_{high|low}()
Content-Language: en-US
To:     Zhen Lei <thunder.leizhen@huawei.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
        linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>,
        Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
        Eric Biederman <ebiederm@xmission.com>,
        kexec@lists.infradead.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        linux-doc@vger.kernel.org
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Feng Zhou <zhoufeng.zf@bytedance.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Chen Zhou <dingguo.cz@antgroup.com>
References: <20211228132612.1860-1-thunder.leizhen@huawei.com>
 <20211228132612.1860-5-thunder.leizhen@huawei.com>
From:   john.p.donnelly@oracle.com
In-Reply-To: <20211228132612.1860-5-thunder.leizhen@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WThLUlR3MVF4T2wvbnNoTjVNbUpYVmxXM1B5L1VwcTUyZXIrOU9sbjN5NEV5?=
 =?utf-8?B?Y25hdWJDaDdqelpWR1ZMai8yOXpZQ3dSN1MwMGh4SVlzVzdvVlJlWEZOTnNz?=
 =?utf-8?B?MlVhVFlmSHRlQUFIeWs4WEh1SXFVQnN6eDZNaENDU0xhZU5jcXhPV1hwZGZ1?=
 =?utf-8?B?N1BjUmY3d0dBOUdPSU9NK1IxRkNHLzVhVXBZT3ljZjZWQkkzTkNxVVlxTHdq?=
 =?utf-8?B?NnFsdURuN2xrNDF2dXBLN1p2YkJzSHMyeEVZTlN3blBJT0pzazVTUGVZVTFV?=
 =?utf-8?B?UVpOT3d3SEtycXRoVHJKSjhnSXRqdHpaRlVzVDBmdzlHeFFxSzlpb1pXdko1?=
 =?utf-8?B?NENLMmdPTzdSWHg2RXNGSTc5VVRUUEFxSDVXb3ZZLzFzbU50UEVldHdxQWtl?=
 =?utf-8?B?MndBeHhFNGpJdFNsV0xzN1k1dW15K1NSaHdnWHBOQURoMXNlWU8yZDhQQzZK?=
 =?utf-8?B?ZDdSMndTSUVyR0FxNmJERjlMakh6ME5FNzY0bnV4YnVGbGEzamhaT1dBTjFt?=
 =?utf-8?B?YWlZNndMQ3VSRWR6aTNnbjRwRWM5VDF6blhLTXBzM3A4RFJzSHQ5VkNkSnl6?=
 =?utf-8?B?MTlHUDNoTUQ4cFNoSTBFM2F6MnRoQU1QRW9BeUtlTU9UN0w3SjhYU0I0SWFB?=
 =?utf-8?B?K0ZUWFZ2TW85OElwTmx4VVZhYlZ0WGk4T2YyVmM0QXZsNFZ2aWxVbDVmMU1D?=
 =?utf-8?B?VmtVRzZaZjdZdm05NXhQV04yUkRQc0JubHdhYmxMRFdLYVR0Rlg1L3c5V1Br?=
 =?utf-8?B?aXQ5VUhiSW5hdEVMczFJYnRIUTJJT3FkeHBxNGxkdWw4My9sYlRDRGlDN3Mw?=
 =?utf-8?B?WTZjK3RLbWZIM2ZGV3VwRVhteGx5YlBFZUVweERMS2ZrVXBsOEZlNHlyNWFz?=
 =?utf-8?B?QURkRWU1anlWTnYwdW5rWTlRam9TamhEZEFsNFg4T2FzaElvQjU0OFNoSlha?=
 =?utf-8?B?b1RtZDFIaHdSWnRxRjY4T01jMytWS3lHY0EwUVJ5Ny9kOEdlbjZ3YU92amxs?=
 =?utf-8?B?WThkbEp2ZTF5bVR5VmlSU1NHcGhhZCtIZnNiRytIMWI3N1hjTmY2NjJtWVNj?=
 =?utf-8?B?ZXdaWm0wdWJWTU44blk4b0ZHT0tqVmpsaEZqZTh1SmdGT0E5TC8ya1hSNDRh?=
 =?utf-8?B?R1pQcVpHLzVLT0Rza0lJNlMzTDczZmFiaFRTK1pzV2JJbHVQWURPZ1J6MG9Y?=
 =?utf-8?B?NzYydEk0bXUyZUUxT3ptU2U0NWQ0Rkp2dmlmQW5PVzBiN2VHV2lHOHJvZ2w1?=
 =?utf-8?B?UGI2ZUZaWFdqcTlDS0NhMVlFa2RkcFdWWG0vMUtac1JPN0ZpNzM1VnhCYzZU?=
 =?utf-8?B?Q09RTnNOcFNjRFNiRVJzT0FWNlQ1ZEREN2tZVGxpejAzbDM5bXRjNmhqcHdy?=
 =?utf-8?B?NUo4REIwem5wTUtOaTN5L3VnZWNvdG1VSGtRL0RqdDZvQzZHY2pnRWl1cTlv?=
 =?utf-8?B?QVBOL2ZyTVR4cUZkMkpHd240V2dxajRCL1hJVW5vaFo3RHNCenhlMW1FaDUw?=
 =?utf-8?B?YWdZRmw4OXN3VG5LSVJyWmhWbUxSeEEwbjJXYkMxcHkvNDViZGU0enN4b1JG?=
 =?utf-8?B?bXFJdTZBUnhlTXljeVNaczRJK2JNTkVsOUMyMmtSN3hKbGlhdlV6UmFwRHJj?=
 =?utf-8?B?ejFJQjgzdDYrM3FxUVN3Tmd5dWc1TGYyYnNrTzVEN2pqZGszVndKYzVBY1FI?=
 =?utf-8?B?bkJ0cU51aEJKamZ5YjlHSzJCZ2RIbis2dWVZV3JEbEhvT2ZTRnhMb1ZtL1pX?=
 =?utf-8?B?Z3lJSktVaUxMZUEwVmtMWElHY3JpZ08yd0NrYTFwZkJrNlc0V3NCanZEYVJS?=
 =?utf-8?B?b0JOQ2NrY2VVTnA1TVNDWjlXSlZtd1ZLNVlGblBJR3hZUzhYK2JrNGs1ZWgz?=
 =?utf-8?B?a2tZTkR2dlhCU0VJMDRUTldRRlRnUUQ4aExqalBlaktPaElwaWJuM1BJV3Z0?=
 =?utf-8?B?UFFtYjFVbUVtdW52L1k5bGgxZGtrTFR1dFpWdHc3eTZqcG13b3ZneEx1Z0wz?=
 =?utf-8?B?WFluM3pTK3hQRnVZZlhyZDcwc3dGYzNtYjNwcUU4NVk1azVWUEZnc01uRmo3?=
 =?utf-8?B?bFZGZ3dGenNNalZIcXhGVDZSZTUyYVJlTjhZcHNETmxNZ2I5bEswNCt4TUl1?=
 =?utf-8?B?QkVkTm9IYTBmNWVURWREaVMwbFJJdUFXS3Y1Y3phNk1MbnNOOFhFZFBkS1J2?=
 =?utf-8?B?ZjZBdk9HcGNCTlkxNW9nNlRHOHVoY1pHakpQelBXRG40OGFML05pRlFHOGdy?=
 =?utf-8?B?UVMvL25SR3F5R1FUdTllbUhLWTNnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e82b05a-d5fe-466f-a3b9-08d9d513d6d3
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 15:05:43.7101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HdoV1tnJHCl6IObNIwKLag5KPlFBV8j/w49jLYncZMuROBH/vr0GrdtdlPHGDd7fmyyfnlSESZmId4VPWssFaO/7zdKSVogVYtkSDcLL2QE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5881
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10223 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201110089
X-Proofpoint-GUID: tMdnQLF3iBnk-et5fyDWRNho7wI1DCcv
X-Proofpoint-ORIG-GUID: tMdnQLF3iBnk-et5fyDWRNho7wI1DCcv
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/28/21 7:26 AM, Zhen Lei wrote:
> Delete confusing parameters 'system_ram' and 'crash_base' of
> parse_crashkernel_{high|low}(), they are only needed by the case of
> "crashkernel=X@[offset]".
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
 >
Acked-by: John Donnelly  <john.p.donnelly@oracle.com>

> ---
>   kernel/crash_core.c | 21 ++++++++++-----------
>   1 file changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 3b9e01fc450b2a4..b7d024eb464d0ae 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -278,20 +278,20 @@ int __init parse_crashkernel(char *cmdline,
>   }
>   
>   static int __init parse_crashkernel_high(char *cmdline,
> -			     unsigned long long system_ram,
> -			     unsigned long long *crash_size,
> -			     unsigned long long *crash_base)
> +					 unsigned long long *crash_size)
>   {
> -	return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base,
> +	unsigned long long base;
> +
> +	return __parse_crashkernel(cmdline, 0, crash_size, &base,
>   				"crashkernel=", suffix_tbl[SUFFIX_HIGH]);
>   }
>   
>   static int __init parse_crashkernel_low(char *cmdline,
> -			     unsigned long long system_ram,
> -			     unsigned long long *crash_size,
> -			     unsigned long long *crash_base)
> +					unsigned long long *crash_size)
>   {
> -	return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base,
> +	unsigned long long base;
> +
> +	return __parse_crashkernel(cmdline, 0, crash_size, &base,
>   				"crashkernel=", suffix_tbl[SUFFIX_LOW]);
>   }
>   
> @@ -310,12 +310,11 @@ int __init parse_crashkernel_high_low(char *cmdline,
>   				      unsigned long long *low_size)
>   {
>   	int ret;
> -	unsigned long long base;
>   
>   	BUG_ON(!high_size || !low_size);
>   
>   	/* crashkernel=X,high */
> -	ret = parse_crashkernel_high(cmdline, 0, high_size, &base);
> +	ret = parse_crashkernel_high(cmdline, high_size);
>   	if (ret)
>   		return ret;
>   
> @@ -323,7 +322,7 @@ int __init parse_crashkernel_high_low(char *cmdline,
>   		return -EINVAL;
>   
>   	/* crashkernel=Y,low */
> -	ret = parse_crashkernel_low(cmdline, 0, low_size, &base);
> +	ret = parse_crashkernel_low(cmdline, low_size);
>   	if (ret)
>   		*low_size = -1;
>