From:   Rob Herring <robh@kernel.org>
To:     Cristian Pop <cristian.pop@analog.com>
Cc:     robh+dt@kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, jic23@kernel.org,
        linux-iio@vger.kernel.org, linux-gpio@vger.kernel.org
In-Reply-To: <20220111115919.14645-1-cristian.pop@analog.com>
References: <20220111115919.14645-1-cristian.pop@analog.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: addac: one-bit-adc-dac yaml documentation
Date:   Tue, 11 Jan 2022 09:14:49 -0600
Message-Id: <1641914089.194827.2944759.nullmailer@robh.at.kernel.org>
Precedence: bulk

On Tue, 11 Jan 2022 13:59:18 +0200, Cristian Pop wrote:
> This adds device tree bindings for the one-bit-adc-dac.
> 
> Signed-off-by: Cristian Pop <cristian.pop@analog.com>
> V1->V2
>  - I am aware of the recommendation of rename/move this driver. Should we
>    consider "drivers/io/gpio.c"?
>  - Add .yaml file
>  - Remove blank lines, remove unnecessary coma
>  - Remove macros for channels
>  - Check if channel is input for write_raw
>  - Use labels instead of extend_name
>  - Fix channel indexing
>  - Use "sizeof(*channels)" in devm_kcalloc()
>  - Remove assignment: " indio_dev->dev.parent = &pdev->dev;"
>  - Remove "platform_set_drvdata"
>  - Remove "adi" from compatible string since is not ADI specific driver.
> ---
>  .../bindings/iio/addac/one-bit-adc-dac.yaml   | 89 +++++++++++++++++++
>  1 file changed, 89 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.example.dts:19.27-47.11: Warning (unit_address_vs_reg): /example-0/one-bit-adc-dac@0: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/iio/addac/one-bit-adc-dac.example.dt.yaml:0:0: /example-0/one-bit-adc-dac@0: failed to match any schema with compatible: ['one-bit-adc-dac']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1578401

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.