MIME-Version: 1.0
References: <20220107033516.3611664-1-jiasheng@iscas.ac.cn>
In-Reply-To: <20220107033516.3611664-1-jiasheng@iscas.ac.cn>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 11 Jan 2022 16:36:47 +0100
Message-ID: <CAJZ5v0i8JgHk9R2_NsS=5joyhnng9g8eePZox7gsqC9yHpcvLA@mail.gmail.com>
Subject: Re: [PATCH] ACPI: APD: Check for null pointer after calling devm_ioremap
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 7, 2022 at 4:35 AM Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote:
>
> As the possible failure of the devres_alloc(), the devm_ioremap() may
> return NULL pointer.
> And then, the 'clk_data->base' will be assigned to clkdev->data->base in
> platform_device_register_data().
> And the PTR_ERR_OR_ZERO() can not detect the 'base'.
> Therefore, it should be better to add the check in order to guarantee
> the success of the setup.
>
> Fixes: 3f4ba94e3615 ("ACPI: APD: Add AMD misc clock handler support")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/acpi/acpi_apd.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index 6e02448d15d9..9db6409ecb47 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -95,6 +95,8 @@ static int fch_misc_setup(struct apd_private_data *pdata)
>                                               resource_size(rentry->res));
>                 break;
>         }
> +       if (!clk_data->base)
> +               return -ENOMEM;
>
>         acpi_dev_free_resource_list(&resource_list);
>
> --

Applied as 5.17-rc material with a rewritten changelog, thanks!