Message-ID: <e0282429-49b3-c22c-fa02-81d2e1aee8d8@linux.ibm.com>
Date:   Tue, 11 Jan 2022 18:42:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH net 3/3] net/smc: Resolve the race between SMC-R link
 access and clear
Content-Language: en-US
To:     Wen Gu <guwen@linux.alibaba.com>, davem@davemloft.net,
        kuba@kernel.org
Cc:     linux-s390@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1641806784-93141-1-git-send-email-guwen@linux.alibaba.com>
 <1641806784-93141-4-git-send-email-guwen@linux.alibaba.com>
 <8f13aa62-6360-8038-3041-86fd51b40a3e@linux.ibm.com>
 <fa057e34-7626-2b19-2c2e-acd4999e7fe5@linux.alibaba.com>
 <b1882268-d8bb-eee9-8238-e30962928034@linux.ibm.com>
 <eecadb47-92f3-c4cc-64d2-3954474e3c5f@linux.alibaba.com>
From:   Karsten Graul <kgraul@linux.ibm.com>
Organization: IBM Deutschland Research & Development GmbH
In-Reply-To: <eecadb47-92f3-c4cc-64d2-3954474e3c5f@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/01/2022 17:44, Wen Gu wrote:
> 
> 
> On 2022/1/12 00:02, Karsten Graul wrote:
>> On 11/01/2022 16:49, Wen Gu wrote:
>>>
>>> OK, I will correct this as well.
>>>
>>> And similarly I want to move smc_ibdev_cnt_dec() and put_device() to
>>> __smcr_link_clear() as well to ensure that put link related resources
>>> only when link is actually cleared. What do you think?
>>
>> I think that's a good idea, yes.
> 
> Thank you.
> 
> Not in a hurry, just want to ask should I send a v2 with these changes
> or continue to wait for subsequent review of v1?
> 

Yeah I think its time for a v2, thank you!