From:   Song Liu <songliubraving@fb.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Song Liu <song@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ast@kernel.org" <ast@kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "andrii@kernel.org" <andrii@kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v3 bpf-next 5/7] x86/alternative: introduce text_poke_jit
Thread-Topic: [PATCH v3 bpf-next 5/7] x86/alternative: introduce text_poke_jit
Thread-Index: AQHYAqTPOIWcijzdr0uhWm4W1NDGq6xdxCCAgABcKIA=
Date:   Tue, 11 Jan 2022 17:43:47 +0000
Message-ID: <48AD9DA0-5E09-4EBD-AFF0-DA63ADA5A247@fb.com>
References: <20220106022533.2950016-1-song@kernel.org>
 <20220106022533.2950016-6-song@kernel.org>
 <Yd10heJVckednY07@hirez.programming.kicks-ass.net>
In-Reply-To: <Yd10heJVckednY07@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R+YY9rN6ZbCoSejrb2sbKposzk2cuFl/C+Xr9Icgfi+ZOtaVleBHhIChnwTc?=
 =?us-ascii?Q?9qkRaAFCUyLgVTTlr4u8JfI8L9Nu7UUdPW43eK/nJvgO9srJL46j5vAIoAi/?=
 =?us-ascii?Q?sIelW0j2MySFS8ncOk4feU7pzshe2RejrEJDJUiMxlG6pmMEZ9eRjW/y/4gz?=
 =?us-ascii?Q?uiJL9bNOWmDO7pzYGM6WmVT0kSK/p4JNjO3lQOeGcVMd8g+2SoFcgeqqtpYY?=
 =?us-ascii?Q?awV/pbGaMatp5IZ8BBa8N00Ekb5b6n23pfvIQ9I6dRYW+WOIAQlqMcIx6Zh4?=
 =?us-ascii?Q?fMoF83YlpnlBQfQ7xzXr4XKU2N7uSTxtEjYqbZnxQlrBWl1Ey0jA2NSIwcdm?=
 =?us-ascii?Q?icrdqMVli0mNkp/8a1oAh5jqpx0hoqUxBtKadckwg0Oud2/Lx83Rv3eAZI2H?=
 =?us-ascii?Q?1tEUI4CAtaipz5MG3XHDA4wwTr0g+IK0xVIYNUuSlrVPikiLhG3j5m66G/+L?=
 =?us-ascii?Q?9SsxKX+/gYAifQ34IdFhV4Uw89W4uV3fKRa85bvp/yoYIdIE8rQ+5UU7DzGb?=
 =?us-ascii?Q?oYfXUD6GH7SawpnVn1UxGoYErClyFqr0md/6SDfGE83Vqp87RT25m1cJhzS+?=
 =?us-ascii?Q?JTzGkuy08ynCkvcMmf4x9rEAaWvKvXpiyCOhOMO3+kIC1V/hDeD/c4iIGF1M?=
 =?us-ascii?Q?a5R+YjyRpDLDxKguO7sMNW5If5KFeO09+hSVhk1bM+BCwh3aFz0Unw2CVlwc?=
 =?us-ascii?Q?JaH/YzIIG5+DoT/lrUyM+MqaCNsAikIlIimixaJVcH90aMqAWVyqgZNPWbak?=
 =?us-ascii?Q?Y1qk0kER+5PrMPLJaDJvwKoyr0Zq73ao5jv7ojkNIQKJcW0ZzGk4tD5rbvp2?=
 =?us-ascii?Q?1iLn2ndzyMxG2hdASChoTeLxTt8QvQ2pJqF77QVhz2O2/henoSjGUgwoFsBJ?=
 =?us-ascii?Q?y+MxK6dWthSUa6OGyecbAesSHlxVYoKIAKIZHyRxtp+dJq0Qg0hq0EqTizQL?=
 =?us-ascii?Q?7ls0ue708bx0D0qZAfgqor/SwQixLnpWMk6ksZPdAdvDxh7XYBKIbbYIMGpl?=
 =?us-ascii?Q?I1jpYbJ70MDvxeZ1xbRfVCipfuTN8aAd7Pop9O/zASsU9OpFEYyJryCaMCt5?=
 =?us-ascii?Q?51IELVyVQdZhNfNrW6LWA5k7WjoyQcrgmG20pcIzMZM//Npoyzr+Y+TAxBjz?=
 =?us-ascii?Q?7yKXMzZFUqf4j9sPkjc9dtFRH0G28HhMzjzGsw1VaeiLKpfzddzjCLjA4yKv?=
 =?us-ascii?Q?IcRhUOH7/e1CxXjsLA9aVoLGU3me2JmoMqjDNcwFTH4wb6yVuE76A2iFapsd?=
 =?us-ascii?Q?7MWzIg8hO/OSNgFj8JX7zb3TGe3OS6KT2mV0c7Ayzj10eSfEhLh5w1DR1rBV?=
 =?us-ascii?Q?IRQ26IubirKBB7mEAR82Jt4nLLncFkIxw+QEhaifBQ+YgynKL94NbwIofgW4?=
 =?us-ascii?Q?ZQwxBOxKWlWy4yCO0EvBWTNhtV+ot2iVUJI4dZ5BM+t8sOvIVMEoiBuW/Jb6?=
 =?us-ascii?Q?IsChuPuVV5ecsdEh6KNo5McQIoH8mwzGpSFX1TGalIYtZJrCAWUuxmv9ddf2?=
 =?us-ascii?Q?U2PMRgs9XRSjBFgiPpstHj4Et8tOQfiFsoSf6we9ztp1gZwAvXrHnHAv/q35?=
 =?us-ascii?Q?vWDIJRfxnhpsRE9N0jeSDRi0NQAN8RjOtHkmh0WZrmPF3VPMu7GQfZF6cjTv?=
 =?us-ascii?Q?P+zAq6vk1p6qx5q9KFwPlWw9L0+1wHQO3LIS93+19zwwRV/DejwFmAdUIf5Z?=
 =?us-ascii?Q?Xi+J+Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CC912B980F671C4487781726F62DE142@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a85994d-85dc-4d12-b1b5-08d9d529ebd0
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2022 17:43:47.6021
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: D0uBkqLhjgRwJbt6873x3ZBwru7OIW9i0iUSzI2XkR4QxajB90JXvkH+hLNa/U84KOx3zkAcZxWER9Lk9Lxtwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB5096
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: -h3TO3i9w8m53dirHpLREERAUuV8EoyL
X-Proofpoint-ORIG-GUID: -h3TO3i9w8m53dirHpLREERAUuV8EoyL
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-11_04,2022-01-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 mlxlogscore=865
 spamscore=0 impostorscore=0 bulkscore=0 suspectscore=0 priorityscore=1501
 mlxscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201110097
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 11, 2022, at 4:13 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> 
> On Wed, Jan 05, 2022 at 06:25:31PM -0800, Song Liu wrote:
> 
>> diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
>> index 23fb4d51a5da..02c35725cc62 100644
>> --- a/arch/x86/kernel/alternative.c
>> +++ b/arch/x86/kernel/alternative.c
>> @@ -1102,6 +1102,34 @@ void *text_poke_kgdb(void *addr, const void *opcode, size_t len)
>> 	return __text_poke(addr, opcode, len);
>> }
>> 
>> +/**
>> + * text_poke_jit - Update instructions on a live kernel by jit engine
>> + * @addr: address to modify
>> + * @opcode: source of the copy
>> + * @len: length to copy, could be more than 2x PAGE_SIZE
>> + *
>> + * Only module memory taking jit text (e.g. for bpf) should be patched.
>> + */
> 
> Maybe:
> 
> 	text_poke_copy() - Copy instructions into (an unused part of) RX memory
> 	@args...
> 
> 	Not safe against concurrent execution; useful for JITs to dump
> 	new code blocks into unused regions of RX memory. Can be used in
> 	conjunction with synchronize_rcu_tasks() to wait for existing
> 	execution to quiesce after having made sure no existing
> 	functions pointers are life.
> 
> or something along those lines?

This sounds good! Thanks!

Song