Date:   Tue, 11 Jan 2022 10:06:56 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Wei Yang <richard.weiyang@gmail.com>
CC:     <hannes@cmpxchg.org>, <mhocko@kernel.org>,
        <vdavydov.dev@gmail.com>, <akpm@linux-foundation.org>,
        <shakeelb@google.com>, <vbabka@suse.cz>, <willy@infradead.org>,
        <songmuchun@bytedance.com>, <shy828301@gmail.com>,
        <surenb@google.com>, <linux-kernel@vger.kernel.org>,
        <cgroups@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH 2/4] mm/memcg: mem_cgroup_per_node is already set to 0 on
 allocation
Message-ID: <Yd3HQGCmDcyWY6QB@carbon.dhcp.thefacebook.com>
References: <20220111010302.8864-1-richard.weiyang@gmail.com>
 <20220111010302.8864-2-richard.weiyang@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220111010302.8864-2-richard.weiyang@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kQwPvaG7gn8y4N8FQKVaJyDRzNxIasRuQr+fcIiQAOV2kUnjTgQxl+fNpRKh?=
 =?us-ascii?Q?ORSw2BSiKO/IhefdKdGS0fMssRFDHR8zAW3EHLvCDhw1aLZcTcoCf0hyEBk8?=
 =?us-ascii?Q?+maFq0W+DgWPiNtIJnvXTDmDDqllJe6uNrfFKTY508E6VqKzCPFpNyaJhX22?=
 =?us-ascii?Q?EsLCwGc5eZObiM3mv4V1WKj5jcZGmYESTcbwbHiZaqmyy4BTHEA79Ri5tk74?=
 =?us-ascii?Q?vFXwagHuk7WtPDmDp4yrSJod3SQiHAVwAzX7hd19atCKay8hZTTVeGHFK4UQ?=
 =?us-ascii?Q?nPRGmYv2ErOEOgW6/ceAN/L8DA1N1QCtzAf58VYaG0Z7n4WfqfNR/1spqruJ?=
 =?us-ascii?Q?3CgfpAOwQ8jLSqOZ9Q4YGYodmFfQKlyUReITeqsCWVzzZbF1Vp+sXPnWSYFW?=
 =?us-ascii?Q?iRwpnjUyMSgXMJtDhYAJxcyj892/CFkUHtEAoBLtgQ71RMKBZBMiuBoWbwby?=
 =?us-ascii?Q?NDRYwMudXYK7ygCowi7jds/jImUlFw35QEvdupXx7DVhw/3fBXeiN9voFJoc?=
 =?us-ascii?Q?D82JhG/m7AFdfQoLde9AJr9/WNL8aANmnOGGzOThAQBcMsRwlJLN5d1cJhBO?=
 =?us-ascii?Q?jX2IdGQt736PU6UWSk204j2hWuwOAuwuOdveEO1jU/khBV2kxMUbtDyjlCCh?=
 =?us-ascii?Q?vcZXF4Fgws63TszDTGCe6vZ6Elzj/LvYSFT2u/kYucONRAwc0uublLVfHliD?=
 =?us-ascii?Q?cT1iaohC/Czn78XHKjxUn/UEQ4FPeW+P8B3nVFAtMgK7oOHo1+y8rTWoAKWT?=
 =?us-ascii?Q?kX+697mWtnAKQLKddGgIvnWlZN3eAbAWF1THj2JEPMkcn+FkbDcSozDSmqXz?=
 =?us-ascii?Q?ZWNevuNrwQ5UuQfZFbSyoURFoajSKpspLeKJJEJRHhnLxd015q71cS/b2kX2?=
 =?us-ascii?Q?4wna8O3HWDBLXvNZugpionLcRpUtu6RrWvMsz96ofLhEorOmCtUXHP1xlzz2?=
 =?us-ascii?Q?X4Je0Ce5Ug47viKv5swi1PEY2C4Ik/HJmlRcaXxd2wFnMHZg4+2WMHkM8Erg?=
 =?us-ascii?Q?cbNnUTmeBW/3jHBVGhSQX9HZSQ9zBlzvrhV7jv47z4mFtgCbNa2RheT1WQgY?=
 =?us-ascii?Q?gTmcJqir+c6YYjiMNXyAvPSYgJf20lcZGWJqrnVnWuUXVzFivsW+VHBzMl3T?=
 =?us-ascii?Q?cPLOhxrn+6UECfhmS9PKE0uVws+FZRZQ+3o34cZP9ZkRss3918rA5fDC0ZXz?=
 =?us-ascii?Q?6dpbuD+CmZnU5k3pvFcFDD95YBKYhYIsus70zoHEWZdYnpEYyg45FZvVlR49?=
 =?us-ascii?Q?Krfcgc0rS2DhZPEPnPh2uNtUOaYMQPmyPhU2qGFUEc2f60U3pO9kBNW/hvCA?=
 =?us-ascii?Q?3oeTfWjr1beQAXF6yb2SU/4gERLyaaLTDJfzFYdOerziYOkH21SST8iDhLvp?=
 =?us-ascii?Q?w1cyVvp1o9SSgWt67QRcl/bIi+X5YuuUD9Eac22Lf/BrQgs5yEtN7gb6JQ4Q?=
 =?us-ascii?Q?MffVWRCdhegkBxI14nQJvHCOGaJYSROEF/0pdao+/uUoRwbsORscya57L2iE?=
 =?us-ascii?Q?JnlGEY/z+LWYQNiME+Fkby7J4MVl41w3pRBdsXVRJzCOBfjDXqstBuI0hCZL?=
 =?us-ascii?Q?C5KsXnBqtp19z2dQvb9JLfb4vnvS2b4F+a5NiG2F?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fea710b-d0a6-4ab2-44e2-08d9d52d29d8
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 18:07:00.3325
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b9/bMVwN7KsLMoLkPpAxodTOIeDTeNHFnYcAgTygIyYYtS0q7hYDEBjLTpNUs12i
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2759
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: FpJMdzThkIiuESfbTs13n9jQcahQGck_
X-Proofpoint-ORIG-GUID: FpJMdzThkIiuESfbTs13n9jQcahQGck_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-11_04,2022-01-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 mlxlogscore=695
 spamscore=0 impostorscore=0 bulkscore=0 suspectscore=0 priorityscore=1501
 mlxscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201110099
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 11, 2022 at 01:03:00AM +0000, Wei Yang wrote:
> kzalloc_node() would set data to 0, so it's not necessary to set it
> again.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>

Reviewed-by: Roman Gushchin <guro@fb.com>

Thanks!