Date:   Tue, 11 Jan 2022 10:23:41 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Wei Yang <richard.weiyang@gmail.com>
CC:     <hannes@cmpxchg.org>, <mhocko@kernel.org>,
        <vdavydov.dev@gmail.com>, <akpm@linux-foundation.org>,
        <shakeelb@google.com>, <vbabka@suse.cz>, <willy@infradead.org>,
        <songmuchun@bytedance.com>, <shy828301@gmail.com>,
        <surenb@google.com>, <linux-kernel@vger.kernel.org>,
        <cgroups@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH 4/4] mm/memcg: refine
 mem_cgroup_threshold_ary->current_threshold calculation
Message-ID: <Yd3LLalWzPy17PmR@carbon.dhcp.thefacebook.com>
References: <20220111010302.8864-1-richard.weiyang@gmail.com>
 <20220111010302.8864-4-richard.weiyang@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220111010302.8864-4-richard.weiyang@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dDOyLYw5MJ88Jaw3ySUcJLml/tJ0ppiID0NKHqIwVUupJBVG1lk+62J34pXR?=
 =?us-ascii?Q?RuEyRcMfX96LTbzmoNKYXXg2mtx79usIR00kow5C4CJSNHhsHH/XHAx7YSU3?=
 =?us-ascii?Q?CCBgNAdVY2XraRxcNmbUzcVgWrT/+MIwalc+RlI+8YwNbuNXv9nckIjCV7ic?=
 =?us-ascii?Q?+YEjiIigyXEHvIx+Gs1zq/ju2LWa4jbx+13R0ppdev+gwmh4LuYzdTDIFM84?=
 =?us-ascii?Q?RcFML/wWx1wQk7Em0CjCwT2IVnfbTuOTP9oUVhR61/ONsY0vGYrvzd715Qdj?=
 =?us-ascii?Q?nUv44k45JInKCzyZ+zxEJiARXlSNWzb2DFy5aYLkqNegWzkRmrB5E/JJ5U6V?=
 =?us-ascii?Q?KZlAg39kodtI/9hbIR35Y21F/9gs6dV0iEQI/xctbouzQEhYT40TPjJ45hL6?=
 =?us-ascii?Q?n3GlvFhHYugB7XqKKKfZp5sbBwQn/PD7dO3trHdWB4snDC5ePTB8UySs/LPU?=
 =?us-ascii?Q?JFH14XfwpU1djNBClzqh8qfgTDHEZnP/+msMtXSrTLtOCyJv6/PCTvxeokXV?=
 =?us-ascii?Q?vWVoGevHNwiGACak1FFPYNyf5GxEAMjCrOA5axluIHEW4VYahkrGWINk5V95?=
 =?us-ascii?Q?3dpqQGpNdT/qHVxXxwki/hcpYZcCB8mf8OC/csOWnk6rRj187y0tnThHBXIa?=
 =?us-ascii?Q?01erVeIXK4b6e8T7loXg3f0wSvr0c3ga0dv4ud1lZ6B7yZOqcSjvMP0BU6/C?=
 =?us-ascii?Q?QdADbRYwsRFrFL8/JFCWa5kkMsrgMCrEhkAUupBdl61bClXWqDhrNoSQVN7s?=
 =?us-ascii?Q?G03z4lr0thzqXZxjPjoxF6OEyXYR1O6JJMhoiKNh3Xj8UrBtXJelUticeURv?=
 =?us-ascii?Q?4mBJ48Ir+S0PwQ0tvsB3k6YsGpTCgTcDQOddcfe2Qu29NjRpvFVvkwI+pEin?=
 =?us-ascii?Q?h/y8LtHuXGcyTywCWSvf2MNHAe8fG7TkK+4gQbbzf2ixpfE85qKHDN3GkJHe?=
 =?us-ascii?Q?feOp/I1jEWVI2JrZ8Evfh2LcGPNzXHW9tvqv1TErWaJX6Af6Kj0WNHwJq+Qf?=
 =?us-ascii?Q?ZS1nKkYamjc39W1k/UUhwBETpO46bgJPscDuNYOXocQ3xfRtAz9w14O9rPY8?=
 =?us-ascii?Q?SBYx48Ca/kTCLxrCaXJd3LqXtuqNx8ZR/Nl8PaeoAZovod8j0jJU6PFd1PsH?=
 =?us-ascii?Q?wGX1uRn7ATEt3VSnhzl7KRLySXI38R0LXd8tMptdJ8Gg9ayfL0+7E1at3DvM?=
 =?us-ascii?Q?SbuUUNIMntZF3BsbaGS/eOyA8GO/HFzzwQiCN7TdFKy7wDfzi7zzSu/Rl1kB?=
 =?us-ascii?Q?WVtRNCTxGsBuS9YdBAVauK5Zt2E4Rz6dfZrTGUbaYPK27RQPSWezUHToaxhH?=
 =?us-ascii?Q?DBPklEuQLypszFdzcO1DZkeKh9IKvA4qhMAVgAORxGUNrtOwtw0DxGK2Dpjn?=
 =?us-ascii?Q?25Gi/62vK98MPMjo35FTNo8BaJkGfcBOiZMA6e9r7k0ApwcMMx3S7fXuV8vp?=
 =?us-ascii?Q?RustIS68+V/2wOEbH0XzsVo930JQRTXsk3Jvq9zeqv/tkhl8C07lwrXNP7PH?=
 =?us-ascii?Q?QJ8DlQ5mDhBhkERkYhUrV3UYze8EZgIyJizfvJLT4yPrs6qZbJVdrhf7Pydg?=
 =?us-ascii?Q?OCkY6I+k5JkJGM6Bv8Kk03EG0BMUsg3w+cGZO6wg?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4afe0e78-fd37-41bd-1936-08d9d52f80b9
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 18:23:45.0679
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D3wPxqY5wE0tLoRiQdULu+PZOaS2rgYhMIbRJhJIChIBcjmYtpZG/oK1JInLpy6p
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3127
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: pDyiSlfSajJ0tXrLD5wyRXbXknqI_y4-
X-Proofpoint-GUID: pDyiSlfSajJ0tXrLD5wyRXbXknqI_y4-
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-11_04,2022-01-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 impostorscore=0
 bulkscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 spamscore=0
 clxscore=1015 adultscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=999
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201110099
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 11, 2022 at 01:03:02AM +0000, Wei Yang wrote:
> mem_cgroup_threshold_ary->current_threshold points to the last entry
> who's threshold is less or equal to usage.
> 
> Instead of iterating entries to get the correct index, we can leverage
> primary->current_threshold to get it. If the threshold added is less or
> equal to usage, current_threshold should increase by one. Otherwise, it
> doesn't change.

How big is usually an array of thresholds? If it's not huge, likely
any savings won't be really noticeable (it's not a hot path and there
is an rc_synchronize() below).

So I agree with Michal that a better justification is really needed.

Thanks!