Date:   Tue, 11 Jan 2022 10:28:15 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Mark Brown <broonie@kernel.org>, linux-gpio@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        Russell King <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>, UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [RFC v5 net-next 01/13] mfd: ocelot: add support for external
 mfd control over SPI for the VSC7512
Message-ID: <20220111182815.GC28004@COLIN-DESKTOP1.localdomain>
References: <20211218214954.109755-1-colin.foster@in-advantage.com>
 <20211218214954.109755-2-colin.foster@in-advantage.com>
 <Ycx9MMc+2ZhgXzvb@google.com>
 <20211230014300.GA1347882@euler>
 <Ydwju35sN9QJqJ/P@google.com>
 <20220111003306.GA27854@COLIN-DESKTOP1.localdomain>
 <Yd1YV+eUIaCnttYd@google.com>
 <Yd2JvH/D2xmH8Ry7@sirena.org.uk>
 <20220111165330.GA28004@COLIN-DESKTOP1.localdomain>
 <Yd23m1WH80qB5wsU@google.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Yd23m1WH80qB5wsU@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WENHZ2JMVnREbXRVTFNVakEyc25YcUpqaGxONFhWdEVod2JyakJCT1ZQeENP?=
 =?utf-8?B?OW91cHpza2k0dmkzamNSTU9ITWFVcmFacUd1NFpOQm43SUM5eThPK0Y4WU02?=
 =?utf-8?B?ZDI3K2Y5VWl2SUhpSW1ieEsyL3Nzb05obm42VFZweWJwRXVnbzZYOTNoY0NE?=
 =?utf-8?B?MTV2T1J2cW9BdDlFQ0JHLzVHbUlZV2Rka3VlUFlZL09pdGtJMHpzSnAyb0s1?=
 =?utf-8?B?UzhzRjEzWUhLUGdkT2FaOW9yQVZJb0pHRVZoL0tBWjNGZUdYTFNOQm1FYy9N?=
 =?utf-8?B?ZGZtZmhJNVE3SnNmQU5PT0dkNFRoWDU4RmdhQm1rR3FpUmhRSlJtOHI0V0hF?=
 =?utf-8?B?d0lqNXcxSnhoNXZVcjd4bktVcFhDMXhhOGMrTFE1M3AzQVl5dUV1SDk2UTdh?=
 =?utf-8?B?aWt5NHpoRTk5U1FGV2I2QTk1YXhxWFlKQ2I4S0YyWDk0aUNkMnRQa1c3YVpI?=
 =?utf-8?B?TmRkRzFxbGN4T21hK0xEdW5jazF1emxsY2hRUElPU3RERE5pcDJFSE5RWm9s?=
 =?utf-8?B?Yk9sOVhEb0drbFlmakI2N2REUUpNNWQ1UGVpYTMyZCtiSDJwMDk1MWw4eVF3?=
 =?utf-8?B?Tm43OHdBa1I3NUNPL3VzNTFBUXRyOFBqbHI0TzdDTzNmN2J0M3c0dVpJZHg4?=
 =?utf-8?B?Sk5EM21LNDM1anUrYmthMGtBc0tVSXN1VlQ4VGd2Nytpd2V6c3d5MjZSbzVF?=
 =?utf-8?B?Q0ZMMUFnVkllN0Y4WG4xWUVBN2pZYmFtOWZNYXRzNUhVZmNyM3E1cnBZU0N0?=
 =?utf-8?B?cENGUjJ0dkl2elFFUUd2akh3U1RZZ01qbUQwajFCQ3Y1K3V3MUl4L0dqM00x?=
 =?utf-8?B?WTZMOGFveFBCSW5oYXE0amFCaVNMdE1ESHNOcGtWL1FoYVhQUHptTjhOV3Jp?=
 =?utf-8?B?MHhwT2kxcllldGJwZ3ZFNjFGaWJOaWk2RWNFUzhGN2U0eGprTmhKL09YdHlK?=
 =?utf-8?B?ZUF0S0lNMm55ZE0wTUZuclFLcHU4eUNWbVBrNy9rbVpWQXVrdFJIdmhJM2cx?=
 =?utf-8?B?SC9xbFhBNC9HWG44WVRWMjVUZDdKU3djSGxET09NSE1rN0dNbUpGVG9ZRFds?=
 =?utf-8?B?VE9hdHJHUTBkWGFITk1rZ1BWT0NFelhWK1lQWjRjRkova1hyMzBGNHVtRWNv?=
 =?utf-8?B?bHNiNGFHWnBmUHQvY1VVc3RVYW85T1grY3A5TnpmdG9DT1pjKzB4bjdYeVBI?=
 =?utf-8?B?N0lodTZEUjZXR1VVclR1WGplOXNETHRjRk9jS3J4bVdpOWdKUG9yQjBRUmx6?=
 =?utf-8?B?ZzlHeXZNWDBya3FReXBaTjlxMmFNdDh0dkYwcTRDNHV0NkJuMU5CaGdldzUr?=
 =?utf-8?B?UnZJRXYvWFZ2WjBGOWliL3FONXp1aENuQlN0OHJEOUJYOWhPOUpDTGFrbUk0?=
 =?utf-8?B?SFlmcVQ0UmN2cWVkdFkwcUZyanhsZXJvckg5YjdYc1hFUU9nTnIzT0VwY01M?=
 =?utf-8?B?d1B3bHZZV21sTmtsWHlxbGV5eXJaMUVFYlpCSVRvVEdxNHU2dG1HbHAyK3JE?=
 =?utf-8?B?K2xwMWwrTWI3UCtqWW5SUGgzbC91eVh3dDRib0NiRU5jOGxiNGhpS2NKcGMv?=
 =?utf-8?B?ZkpKYmJmNXV5azVFQkFwU1ZMWTVJT2lMU2Q5eCtuREZ1MWNRT2pPaVE5L1B1?=
 =?utf-8?B?K1FhOXZCN2F2YlJGWXM5SmJuQWNmRy9xRmQzcnV4K3QrS01jbUpXKzdGN3NE?=
 =?utf-8?B?a09xMWFuc2FRb3R3NE1XNzEvcnFBOGpHdU5nNm45emNuSzhoL2YxYXgyQy9q?=
 =?utf-8?B?YjZZN1NoUjJGYVVBVEhCS0hWc3NreExySnI5cTltdmwxYWk2YkZYQVNSWmlU?=
 =?utf-8?B?b1VjelFZbG1vS0IxajRUWjFvRld5MldVaW96U2o2bDAwaHFQQkNLOHBxZjNC?=
 =?utf-8?B?bEtubDQrZlhRVS8wN29CWTdYOXhGZjV1bVhKUHdETDBCN0xPRVRycVhwRW12?=
 =?utf-8?B?aGwzaG5MaTF4YkVYKzBlQjcvUUNrZTJhdWRMOHhBNFNvMGhoWjlRMEloSmg4?=
 =?utf-8?B?NUZyVldLSHVIK01PWTdoNENDSkxpODhCVXlWaDAxbURleDF1TnUyTis3OERQ?=
 =?utf-8?B?RE8xa3ViYk1aSXYveS95N3k1VVRWYjRnQ1VaRzcyT01PdmxIYjZNUkVxRjNH?=
 =?utf-8?B?azJvUFZXQjlLK0o5N1h6U21SelFXdWc3ajUrc3QwbXN1OFFKT3o2cWdObFJr?=
 =?utf-8?B?aHlmd3JkVUhxVVQ3Q3VPcG1Od1lIR2NFeFVwMTZVNmJJdHkzVkxrMlBXZ2Jq?=
 =?utf-8?B?eUFSanh2SVdkS2RMVXhGZlV2UTJRPT0=?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff4ac4bf-8fbd-417a-5f2e-08d9d5301525
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 18:27:54.2052
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XBnSXNnzjSqAhfiP1OltBDLO36QhnzF1qPNyEJDl+DHXNk2Gl9S2dJDsT5szwyLmU4q1c6XPSofyfSDCJeKAD6iCpphuCRSPCfd40I4kCTs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB2032
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Lee,

On Tue, Jan 11, 2022 at 05:00:11PM +0000, Lee Jones wrote:
> On Tue, 11 Jan 2022, Colin Foster wrote:
> 
> > Hi Mark and Lee,
> > 
> > > 
> > > > However, even if that is required, I still think we can come up with
> > > > something cleaner than creating a whole API based around creating
> > > > and fetching different regmap configurations depending on how the
> > > > system was initialised.
> > > 
> > > Yeah, I'd expect the usual pattern is to have wrapper drivers that
> > > instantiate a regmap then have the bulk of the driver be a library that
> > > they call into should work.
> > 
> > Understood. And I think this can make sense and clean things up. The
> > "ocelot_core" mfd will register every regmap range, regardless of
> > whether any child actually uses them. Every child can then get regmaps
> > by name, via dev_get_regmap. That'll get rid of the back-and-forth
> > regmap hooks.
> 
> I was under the impression that MFD would not always be used?
> 
> Didn't you have a use-case where the child devices could be used
> independently of anything else?
> 
> If not, why don't you just register a single Regmap covering the whole
> range?  Then let the Regmap API deal with the concurrency handling.

That's exactly the use-case I was considering.

An example:
"mscc,ocelot-miim" exists. It can currently be used in two different
scenarios: directly with devicetree, or indirectly as in
drivers/net/dsa/ocelot/seville_vsc9953.c

mscc_miim_setup(dev, &bus, "VSC9953 internal MDIO bus",
                ocelot->targets[GCB],
                ocelot->map[GCB][GCB_MIIM_MII_STATUS & REG_MASK]);

The "GCB_MIIM_MII_STATUS" parameter is the offset from the base for that
regmap. See commit (b99658452355 "net: dsa: ocelot: felix: utilize
shared mscc-miim driver for indirect…")

(My apologies if the formatting of that commit refernece is incorrect)

But in that case... the Seville driver makes a devcpu_gcb regmap located
at 0x71070000. That regmap is created over the entire "GCB range". That
gets passed into the mscc-miim driver, along with the base register
location of the MIIM periperal.

At the same time, mscc-miim can be probed independently, at which point it
would create a smaller regmap at 0x7107009c
(Documentation/devicetree/bindings/mscc-miim.txt)

So the mscc-miim driver supports multiple use-cases. I expect the same
type of "offset" idea can be reasonably added to the following drivers,
all of which already exist but need to support the same type of
use-case:

mscc,ocelot-pinctrl, mscc,ocelot-sgpio, mscc,ocelot-miim, and
mscc,vsc7514-serdes. As I'm bringing up different parts of the hardware,
there might be more components that become necessary.

With the exception of vsc7514-serdes, those all exist outside of MFD.
The vsc7512-serdes driver currently relies on syscon / MFD, which adds a
different complexity. One that I think probably merits a separate probe
function.

> 
> -- 
> Lee Jones [李琼斯]
> Principal Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog