Date:   Tue, 11 Jan 2022 11:17:27 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Muchun Song <songmuchun@bytedance.com>
CC:     <willy@infradead.org>, <akpm@linux-foundation.org>,
        <hannes@cmpxchg.org>, <mhocko@kernel.org>,
        <vdavydov.dev@gmail.com>, <shakeelb@google.com>,
        <shy828301@gmail.com>, <alexs@kernel.org>,
        <richard.weiyang@gmail.com>, <david@fromorbit.com>,
        <trond.myklebust@hammerspace.com>, <anna.schumaker@netapp.com>,
        <jaegeuk@kernel.org>, <chao@kernel.org>,
        <kari.argillander@gmail.com>, <linux-fsdevel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-nfs@vger.kernel.org>, <zhengqi.arch@bytedance.com>,
        <duanxiongchun@bytedance.com>, <fam.zheng@bytedance.com>,
        <smuchun@gmail.com>
Subject: Re: [PATCH v5 09/16] mm: memcontrol: move memcg_online_kmem() to
 mem_cgroup_css_online()
Message-ID: <Yd3Xx/ZX0CY68bEv@carbon.dhcp.thefacebook.com>
References: <20211220085649.8196-1-songmuchun@bytedance.com>
 <20211220085649.8196-10-songmuchun@bytedance.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211220085649.8196-10-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gsWujptz58ELMLJC9z7hOBAZMgXtrXLI201wwyGtxHPJqC7zMzqVgPl/fGBN?=
 =?us-ascii?Q?Bd+oP1XochIkAzGSdiMkCNczFB89T3cKFQtKpl4qNHYrh0u1Ul+Z0SjxxyUB?=
 =?us-ascii?Q?QtqKoT/4gZ+AzjAMYXOmiLVgQLgL0Vhlrnhnei8zc3cKFTsH86X4+xxwz6JW?=
 =?us-ascii?Q?XxXT8NbB/nkd6/6OY7SQatAM79VYNGyC9iwRfETnBeYC0xHsXrXOkGglgqJO?=
 =?us-ascii?Q?Un1FbOzhcjYkWOYJCJhxvINlwIddtIofdDnUQxPXVRjxkozgOFZjFTM79VIb?=
 =?us-ascii?Q?VMrbhhNA29fWh3usCvP9TBUmhHpRgxGJh5EiXmRRrYKnlEfZheZwUBEUf3P3?=
 =?us-ascii?Q?DwPrLVCFqDOYdCHAJ7/cHvpSBoC2KFqkzlXhfsmdzOiT4bUCVPuk9CIwFTVo?=
 =?us-ascii?Q?w9g9XenIhwQEQVQzu6lD2K2ebpO+bGp95QyGuLSlKS1luwpTp6nMLLimyUzF?=
 =?us-ascii?Q?R4XEKNrq4YFWDtTMjvGydRVLHJfHpE7rxHdpRbuRVj9eFC9/nvJ1rkY9k7wH?=
 =?us-ascii?Q?aDXuzNg1UlC8giKVtvNboUQ/ToqEJZnWkKA8uXAN3/SeeNUad1GnXT4RykNP?=
 =?us-ascii?Q?iWDoKegLLPlFL+eCw/IXIspyFzSnCyRpPm31khuLdVeCFYF3LP6S6SiNcq2a?=
 =?us-ascii?Q?ZgvMD2K19giLxglVM2XlEu5gnb3vxMNqv0Sc/HPPQ7Ft5ALw2lhV8oU2Bwln?=
 =?us-ascii?Q?2hi9LlrLg3RltwX4rmrsnOOmkwMYawJiR58gWbJoL3fBLBEFEAI52cbZHbaW?=
 =?us-ascii?Q?klS3KlZL63o9pLGDliYq2N/gHNqyreTi0wEG0Pys/H0sbTVG10rduaXkR1hr?=
 =?us-ascii?Q?JKz957+nvDbweohap4ep1BE0R8jcg8ntKZIXAPUOy/YjI2+3pzsHZxgNLqgB?=
 =?us-ascii?Q?RBlhronOFa92fCbuyNwy9pjwVIm8MxJoYVlrADqohS8pkcGqMWpFNuC20/pr?=
 =?us-ascii?Q?2p7g5B5KW4HW/c8N4uKJig+oJkGnKBB/ekA9UlMjxjIWfTiY4F4OMIqdNue7?=
 =?us-ascii?Q?791N5ZtIfZ9xcKT/iQUiq4o12sc1s0ToBF9Z/xeJ5AtCVozQHjwGye3FQ/VP?=
 =?us-ascii?Q?BJUJmq1+he6ZM++HkwQKclShtI7JU6n+km0g5nDeT5xsuuZql0wjM7NoU49j?=
 =?us-ascii?Q?D4BgEXQve72X4P3Odkjd/yjE9qTatvfhEujfBsA0EgDKiSNJrwl9u2x/4bGL?=
 =?us-ascii?Q?OUtvEl10n6ZPvxcq56cOOiua69Wp6a7gso9XkAgxBK0f83BD5Tpb3g+w6/qg?=
 =?us-ascii?Q?IpqA04M8nnjDNVgRHSs+kkednjSJCTCTo52g16uFq7meQU7J0o5mjRDQ2om3?=
 =?us-ascii?Q?IfhYbzxS76U1uYE1Ad6KuefBsDcFD2jpoG3gRmSpiFmDi6ALWandnmVptjTQ?=
 =?us-ascii?Q?oLJkXNPPQg90Bha5wsinP0RHAkVyvdIekVyg6BoFXK8NcwPGHIOdK4hCDVOU?=
 =?us-ascii?Q?KKbjn8bSnrNz1hotwnb3/SFsvjLwOWqZeplqRcmu7p9VAtVPwoiISQxkWg4G?=
 =?us-ascii?Q?tU/Y/c7YC42c3bORkefir44P/zDSPBXYJUTDXc9ku3h8RLPNiAQhPmfej/M3?=
 =?us-ascii?Q?hDu7/qTDVx+p5j3jwEucxfNYy499FnjKW+y4NQ/O?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d794c050-54f7-42e3-4659-08d9d53703f1
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 19:17:31.8040
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iqAuhyvy4kgNv3nf+TluuOkYIS8PHDvhTeAcbq3Dmj+GLiRWO+UUacMcq9ZIAkEX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR15MB4758
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: Q-S_8XBAe6d4fMyq8vlnx7YaQKlr3DY3
X-Proofpoint-ORIG-GUID: Q-S_8XBAe6d4fMyq8vlnx7YaQKlr3DY3
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-11_04,2022-01-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 bulkscore=0
 priorityscore=1501 malwarescore=0 adultscore=0 mlxscore=0 suspectscore=0
 mlxlogscore=660 impostorscore=0 spamscore=0 lowpriorityscore=0
 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201110103
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 20, 2021 at 04:56:42PM +0800, Muchun Song wrote:
> It will simplify the code if moving memcg_online_kmem() to
> mem_cgroup_css_online() and do not need to set ->kmemcg_id
> to -1 to indicate the memcg is offline. In the next patch,
> ->kmemcg_id will be used to sync list lru reparenting which
> requires not to change ->kmemcg_id.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>

Nice!

Acked-by: Roman Gushchin <guro@fb.com>