Message-ID: <83c51ee4-ac10-0e44-d1cc-f69cebcbf0b8@gmail.com>
Date:   Tue, 11 Jan 2022 21:43:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v5] ASoC: dt-bindings: davinci-mcasp: convert McASP
 bindings to yaml schema
Content-Language: en-US
From:   =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@gmail.com>
To:     Jayesh Choudhary <j-choudhary@ti.com>, robh+dt@kernel.org
Cc:     lgirdwood@gmail.com, broonie@kernel.org,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220103074427.4233-1-j-choudhary@ti.com>
 <2cf3c89c-169f-3421-25d4-c80a6c9737ae@gmail.com>
In-Reply-To: <2cf3c89c-169f-3421-25d4-c80a6c9737ae@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 1/11/22 21:21, Péter Ujfalusi wrote:
> Hi Javesh,
> 
> On 03/01/2022 09:44, Jayesh Choudhary wrote:
>> Convert the bindings for McASP controllers for TI SOCs from txt
>> to YAML schema.
>>
>> Adds additional properties 'clocks', 'clock-names', 'power-domains',
>> '#sound-dai-cells' and 'port' which were missing from the txt file.
>> Removes properties 'sram-size-playback' and 'sram-size-capture'
>> since they are not used.
>> Adds 'dmas' and 'dma-names' in the example which were missing from
>> the txt file.
>> Changes 'interrupts' and 'interrupt-names' from optional to
>> required properties.
>> Changes 'op-modes', 'serial-dir' to optional properties as they are
>> not needed if the McASP is used only as GPIO.
>> Changes 'tdm-slots' to required property only for I2S operation mode.
>>
>> Adds the yaml file in the 'MAINTAINERS' under the heading 'TEXAS
>> INSTRUMENTS ASoC DRIVERS'
> 
> I would have added description for the GPIO support as it is not obvious
> that 2 is going to be for AXR2 or 29 is for ACLKR pin.
> But I don't think this functionality is going to be used apart from the
> one dra7 evm.
> 
> Thank you for the updates and the nice work!
> 
> Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
> 
...

>> +properties:
>> +  compatible:
>> +    enum:
>> +      - ti,dm646x-mcasp-audio
>> +      - ti,da830-mcasp-audio
>> +      - ti,am33xx-mcasp-audio
>> +      - ti,dra7-mcasp-audio
>> +      - ti,omap4-mcasp-audio

This is the only thing which bugs me: the pointless '-audio' postfix for
the compatible string...

-- 
Péter