Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423075AbXBBCdk (ORCPT ); Thu, 1 Feb 2007 21:33:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030225AbXBBCdk (ORCPT ); Thu, 1 Feb 2007 21:33:40 -0500 Received: from mailout.stusta.mhn.de ([141.84.69.5]:57081 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030218AbXBBCdj (ORCPT ); Thu, 1 Feb 2007 21:33:39 -0500 Date: Fri, 2 Feb 2007 03:33:43 +0100 From: Adrian Bunk To: Andrew Morton Cc: Luca Tettamanti , Peter Osterlund , linux-kernel@vger.kernel.org Subject: Re: [2.6.20-rc6] pktcdvd doesn't work Message-ID: <20070202023343.GY3754@stusta.de> References: <20070130195319.GA10994@dreamland.darkstar.lan> <20070131233044.GX3754@stusta.de> <20070201230752.GA17679@dreamland.darkstar.lan> <20070201182147.2835668e.akpm@osdl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070201182147.2835668e.akpm@osdl.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2158 Lines: 58 On Thu, Feb 01, 2007 at 06:21:47PM -0800, Andrew Morton wrote: > On Fri, 2 Feb 2007 00:07:52 +0100 Luca Tettamanti wrote: > > > Il Thu, Feb 01, 2007 at 12:30:44AM +0100, Adrian Bunk ha scritto: > > > On Tue, Jan 30, 2007 at 08:53:19PM +0100, Luca Tettamanti wrote: > > > > Hi, > > > > pktcdvd on kernel 2.6.20-rc6 is not working as expected. Any file that > > > > is written to the device is lost after umount. > > > > I rarely use pktcdvd but at some point it used to work on my system. > > > > > > > > This is what I'm doing: > > > > > > > > root@dreamland:/tmp# cdrwtool -d /dev/scd0 -q > > > > using device /dev/scd0 > > > > 1029KB internal buffer > > > > setting write speed to 12x > > > > Settings for /dev/scd0: > > > > Fixed packets, size 32 > > > > Mode-2 disc > > > >... > > > > > > Does 2.6.20-rc7 work? > > > If no, does it work after applying the attached patch? > > > If no, does 2.6.19.2 work? > > > > Git current + the following patch works. > > > > > diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c > > > index 6246219..7c95c76 100644 > > > --- a/drivers/block/pktcdvd.c > > > +++ b/drivers/block/pktcdvd.c > > > @@ -765,34 +765,47 @@ static inline struct bio *pkt_get_list_first(struct bio **list_head, struct bio > > > */ > > > static int pkt_generic_packet(struct pktcdvd_device *pd, struct packet_command *cgc) > > > { > > > - request_queue_t *q = bdev_get_queue(pd->bdev); > > > + char sense[SCSI_SENSE_BUFFERSIZE]; > > Where did this patch come from? It's a revert of the commits 3b00315799d78f76531b71435fbc2643cd71ae4c and 406c9b605cbc45151c03ac9a3f95e9acf050808c cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/