Date:   Tue, 11 Jan 2022 22:52:29 +0200
From:   Abel Vesa <abel.vesa@nxp.com>
To:     Jesse Taube <mr.bossman075@gmail.com>
Cc:     Stephen Boyd <sboyd@kernel.org>, linux-imx@nxp.com,
        mturquette@baylibre.com, robh+dt@kernel.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch,
        linus.walleij@linaro.org, gregkh@linuxfoundation.org,
        arnd@arndb.de, olof@lixom.net, soc@kernel.org,
        linux@armlinux.org.uk, adrian.hunter@intel.com,
        jirislaby@kernel.org, giulio.benetti@benettiengineering.com,
        nobuhiro1.iwamatsu@toshiba.co.jp, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
        linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v7 5/7] clk: imx: Add initial support for i.MXRT1050
 clock driver
Message-ID: <Yd3uDSAwQMoNz8e3@abelvesa>
References: <20220103233948.198119-1-Mr.Bossman075@gmail.com>
 <20220103233948.198119-6-Mr.Bossman075@gmail.com>
 <20220105235157.8ED80C36AEB@smtp.kernel.org>
 <89046151-e44e-6828-ad76-8574fba4fca8@gmail.com>
 <20220110201201.C1E37C36AE9@smtp.kernel.org>
 <Ydy3qvT5w6IWnR7s@abelvesa>
 <baa991a5-31d8-80fb-faf0-b443626030d4@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <baa991a5-31d8-80fb-faf0-b443626030d4@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Dc72J8SdP8XBRyPAD+H/7Rk+l2Q3qzK4bAEBtEnh2pQIcb+m0ARy+A0nLSlp?=
 =?us-ascii?Q?D6hC5SvQzG9k6Iv50tjkdnC4BCXQYwZl++ruARRQxDD/18FSEfjZA/iyvtdC?=
 =?us-ascii?Q?PX6HDNiDlLOQ3jCXAdYM2qSRbAQ0rascawSZkhGRqK7J9FpFbsm41HDcw4+l?=
 =?us-ascii?Q?GHtUMnb7OxU9grbOEV/aJedkfoG4HPqAMpJpLkSrHeUFMid8fPxTGNGE0Xmg?=
 =?us-ascii?Q?R7MV3RYrv7nIEoexeGPq18v5OgDsUquJmz1WHnrlozoMGfh+kA2hichLcxwO?=
 =?us-ascii?Q?XCiEis/YCxajQc9j5i1aNb+ZjMqC2yX5KhuHEkTTDLeo7U7zzCmBFRxKnTOE?=
 =?us-ascii?Q?vEKlcA+fSFmoG/+lD83uHj+ojf+UZ7UkRE+Cwk1pHtE9q0ivlv2Nk2vKgPyE?=
 =?us-ascii?Q?kyJgKnE8OgnwLPAy/Yq03Z0sOREB/egJ707s8yDu3U6jkqokFfMcsOwoqBGC?=
 =?us-ascii?Q?OGYOGRcRaMSnrekDADMTWJ1UVgmBNV3rk+77ZMCBSjIteJhwNXOKbqIoOJt+?=
 =?us-ascii?Q?/HSJJUzHPZqjK181Ht1xTHFwOOk35fN15pmI67b4u48TWwR8daYodeEmzuSn?=
 =?us-ascii?Q?xe19LWaO+m49KwN9CL6QsClaJQPH9d+zbw2o7gF9n7awriBwzP8yKtMI5w4N?=
 =?us-ascii?Q?u7bbhsLrW7SjAnPP7D8iGWE2owy4bjDKJl6qnWpBECy3XQyjhasXk311PM5x?=
 =?us-ascii?Q?oCJzgoWlofeZFN5ATHnGAspaXtoCq9AecqEhSWeHvh7wOTtNek5irBMaLN5u?=
 =?us-ascii?Q?Byou7Mbk5ip5tnQWM5QHtG4EF45+U/hZlc1yTPzD3M26ck9BLqsNhhi7t37a?=
 =?us-ascii?Q?G7kJMILHvg6lGgT0/2Mcj11p2oNdqfGTFExs/0mM8AR2Sisr5OciAF6nOwKW?=
 =?us-ascii?Q?OdtXOahx0i0QgQRfMXFtHK2es9PWRVftFhwQwiHH/mPk7mAUQAJ452J+r2A5?=
 =?us-ascii?Q?kumVBoIZOcJhK92+5R0F43YTozzoadvh8nBkGAoX/GjqteP6q/50/lyRXlpE?=
 =?us-ascii?Q?lnifAUZOArBdXQQfT313k9g8A3EvhbeM8Y7fMm6I9u83t3AsDxvlyVAfSLoQ?=
 =?us-ascii?Q?MancBO4RHcasL308JIdIPO7jOGcH6bSY8Ru1MYclkz5xZMG9Umgc3GuQmVv+?=
 =?us-ascii?Q?5OaaADgx9j3mCXmD7WZ+4fvsWEoYC6XgqCjwq7mDfJv0zdwC1c6G1Gpjkp41?=
 =?us-ascii?Q?HlJBZYrAyFhDKm5Ydifv9uLsPvdvREEuFj0bpFHZ4yLEzGCMSCzbaQy0PIcX?=
 =?us-ascii?Q?eqzAVmEmyvuxJyyLM34h4DblrTMAta83+Kmc8f/RcWHuJtHdQLVxWpXZs1o2?=
 =?us-ascii?Q?HGbbKwuSIhd38xUp8md4ULWRJALSbsoXt8tdV6B7qHcNbcaIdUO4ruxRnel8?=
 =?us-ascii?Q?LgesVA/McrJjopUpsnlBqAdZ9gSl6WgFMVnaD+h45zrbk6wzji1G9+KeNfp+?=
 =?us-ascii?Q?sLCnOkNc4795y0yXbIolKog67/crf+hmMbT9ExSSoqadGzq36pPZXmNE9xp5?=
 =?us-ascii?Q?nua8OhL4Btna5dTWh5oIfVJ1GcYyKCrgz3aITQfMljqkNTMikbyj0CSv94un?=
 =?us-ascii?Q?foKm69GcfAfxNQDtjLUzdgX5fHmFwvljFDfpSg3QtyE4fjMG+q2Lj5JAvrDt?=
 =?us-ascii?Q?szRftQEA+KN4I7oPd7eBl3c=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6d18511-0394-43e2-aad3-08d9d5444978
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 20:52:31.9429
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uwChWVc8O5/QyF/Fa9sCJNAa5SMfBd4qEAKX8RL51W5a3qEVRKLh2RKQopgq0sNxZ3cnmSlTUDVG7aGHIMyKEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6014
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22-01-10 19:18:58, Jesse Taube wrote:
> 
> 
> On 1/10/22 17:48, Abel Vesa wrote:
> > On 22-01-10 12:12:00, Stephen Boyd wrote:
> > > Quoting Jesse Taube (2022-01-09 11:07:42)
> > > > > > +
> > > > > > +       clk_hw_data->num = IMXRT1050_CLK_END;
> > > > > > +       hws = clk_hw_data->hws;
> > > > > > +
> > > > > > +       hws[IMXRT1050_CLK_OSC] = __clk_get_hw(of_clk_get_by_name(np, "osc"));
> > > > > 
> > > > > Use clk_parent_data instead and reference the binding name with .fw_name
> > > > 
> > > > Hi Stephen, sorry to bother you again.
> > > > I'm wondering if adding `clk_parent_data` is necessary as it seems like
> > > > it wold be a big change and the other IMX boards haven't implemented
> > > > this yet would it be okay if I don't do this, or if it is necessary
> > > > could you link to a patch set to change it.
> > > > 
> > > 
> > > Is it a big change because the imx_clk_hw*() APIs aren't prepared for
> > > non-string parents? Can you make some clk_parent_data based APIs and
> > > migrate things over gradually? This is really a question for i.MX folks
> > > to see if anyone is working on moving away from the string names.
> > 
> > I'm currently looking into it. I would suggest we take this patch as is
> > and I'll switch it later on to clk_parent_data.
> Thanks so much that would be great!
> 
> Should I sent the other changes requested I have them ready? Or should i
> wait.

Sure, send it. If Stephen is OK with my suggestion, I will pick it.

> 
> Best regards
> 	Jesse Taube