Cc:     brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 12/40] x86/sev: Add helper for validating pages in
 early enc attribute changes
To:     Venu Busireddy <venu.busireddy@oracle.com>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-13-brijesh.singh@amd.com> <YdOGk5b0vYSpP1Ws@dt>
 <7934f88f-8e2b-ea45-6110-202ea8c2ad64@amd.com> <Yd374d2+XdBD+vTM@dt>
From:   Brijesh Singh <brijesh.singh@amd.com>
Message-ID: <91194a7c-b363-6356-4148-5a5222b86a59@amd.com>
Date:   Tue, 11 Jan 2022 15:57:13 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <Yd374d2+XdBD+vTM@dt>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UW85Umw5QjhnNjd6TnBIQVl5cHQ2enN6ZTAyUmhURnQ4YnZibitUckc1SXE4?=
 =?utf-8?B?UGpzUVVCTWVreElITmVnaldyMlNsc3BYT2pCZ0tsbWJtY3R0clFvVnNjTEl1?=
 =?utf-8?B?YWN0WnF0NnBRSld6RDBBdlQ5eUZXUzZDVDFLdnNQR0V2RG5KdGVNQzgvYXQ0?=
 =?utf-8?B?dnJ5L2lkYTRTS2lidXVtR3ZxOFNFUjhnZ2ZXS3lXTGwwNmNzS0dYN1krM1ht?=
 =?utf-8?B?Y25BY3NwUHpXSUVqZjJOM2pTUEl0OVFoZEFHeHZSUFRGaVllN25wMmpMeEV2?=
 =?utf-8?B?cjBXeXZpeEc3dnU3ZlE0dXR5QWNIWFRNSWIxV1pBTThCTUFCOXRyQU1tNmNF?=
 =?utf-8?B?RHlGaTdxb3dlWngwWXRqTkQ4VG9tUHgzUmlvTi9wR1R6MHd0Wk9najRBeklv?=
 =?utf-8?B?RllWamZMdGtrWWQ0YlNGM0E4alhVbnB6ZnhZRS9qVHY2dVRXTnJrUmQrS3Np?=
 =?utf-8?B?Tnh5c0QySkNVSzkzTE43T0pQdjlSdjRoRmVSSFFwSlZDenNQZVF6bG14SFp0?=
 =?utf-8?B?OVI3blE2TEwvVkluc2pDSno5VkFKMkJ2MzAvWE93eDlwK3BjRlc0aE0xamVp?=
 =?utf-8?B?NkpSRWM1YTRHYUNvTmcxdXFOaS9ybGZqdEFuK3RaMU5ndzhtbXlGdTBtWlUr?=
 =?utf-8?B?TGxUVVR3L0Y4SmxOOEtsN0VMMzk4THRaVW0wOXplNjllbE5ETTNDUzRKTDdp?=
 =?utf-8?B?eUF4bkVjbVNjNnZxdllRWTVtTnUrQytOYVk5NFFuanNoMVRDSElGbUh0R1Z3?=
 =?utf-8?B?T2krWGFheHJsRXFicmlGTWU1cEJYTG9wL3o2UmdxWWdXek5PZklmNkYrZjFD?=
 =?utf-8?B?OHRpOHYvQXNPdGhhRHc4OURZNlNET0NYZllFSHZtV25jQXJCRmFkMktzb1Rp?=
 =?utf-8?B?bHIwUlQxOGNxblBmNmo4L3Awa20wcngzelc3OWpYbEhRdGc1a0Mzc0JQazd0?=
 =?utf-8?B?MllkRk9xOThOVE9oandRUFQwSmhmVnpzZld6N1gyZ3NQWmNnQzNsNnA4WnBD?=
 =?utf-8?B?VStqWXZUUkN2UTlGVGs1UVc1YUxBRTNtMmVIcHQ0aXRialpqYkNTUkNKNzFJ?=
 =?utf-8?B?RDlsQllLS05RUDg4WHlmVUVUdUgwbnJUcEFrczlKc2liSFN6b0xmWElsZHox?=
 =?utf-8?B?RG9UZTNZUzRjQWZkU3lRRUl6c2lCaW1mMm1PNkxwUjd0UUxPT2xxeUhlSWgy?=
 =?utf-8?B?ZlRvclBsdnVSZDBHU0tXNzg4MGVLQ2gzYW5XMVlKUXNFYmhKbjkwSkpKSDBE?=
 =?utf-8?B?cHlLcnozVzZjL0J0b09XWGRDLzc4cGpXTVFBRnp2OW1jR01LS3lKdTBBYkN5?=
 =?utf-8?B?VjRQTi9OVk5QY3FKMFhUTG56MU0zRjZWbTVFbzZqaUgyWWNLM0R1aVZUb2tO?=
 =?utf-8?B?azdzU2xMRDlmVk1NYjI3WEpBYzJid0Y1aFF1cUF3MGpTUk82RnYxc2ppYVVW?=
 =?utf-8?B?T2Z0T3BaSG81aVUzYy9qbzBkc0xmck4zNDFxUTdKSWRWSkYxM2xrV2F1ZFIw?=
 =?utf-8?B?WEpGUWVaZzM0Zy9Ib3FqdVJ4d2pmYkVWSHhaNTdISnMrYTFEcFdrUGFQZGhR?=
 =?utf-8?B?NnczWGVrWHFrVTE4M3lpT3R5dEk5V2ViV2hMeS85NkRIMEt1TlJEUWN0S1VW?=
 =?utf-8?B?N3BGK1JWSWpvQzk5YnRuMnRkakhFa05HYktCNFYxUDgwZjhDKy9nVkhDWGNF?=
 =?utf-8?B?RUpkMHU4UXBZeVFicGpkaTFMU3E4eWdYT3pVN3UzV3BOZzJBM29vamJtUUJI?=
 =?utf-8?B?eXlhd2E3V1BQNWNWamNLeDJ0TFB6WGZrZUNMU0NVNUFnWklidVplb2tDdWpH?=
 =?utf-8?B?RDFyZ1JhcStzWUNja2k2T1hFU2krdEhNclpBa3IxRGpxVXVZNTdNSlNOVzNQ?=
 =?utf-8?B?TDFMcENnU2JqNUxJSTFOeGlKLzFDV3JObE5OdENIL1R3bFhXcUxYMVg5ZVFL?=
 =?utf-8?B?U0lhZjlzWUpVeGxpeldkZWpobCt0VysrcW9yZUQ0VDlvSWs4V0FXRUZ5d1Zp?=
 =?utf-8?B?MHFub0pBWDU0dDB4eUc5LzdqdWZnWVpWalY2QWFPdEFnNzh3VFNFTTZPcS9F?=
 =?utf-8?B?Nm5KaTAweE11L2JRc0RWTUZpV0tzNDJaUFRDb0ViSldoRWcwb0hkbERiQ1Rv?=
 =?utf-8?B?NS9hd0FyeUtpZG5WUHF3WjF6ZjVhaFFZQ2hyUU5Ed0ltZ0ZNZmFJckhWUDdQ?=
 =?utf-8?Q?+KeXteSWeBjQg0cYBlE8nDo=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7427f637-f148-4625-866f-08d9d54d5506
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2714.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 21:57:16.7824
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YKV5xU1QKotWg3eClCsdPQ4L95f78/DXAHF7LC6l6tC1QYwpfSdWbIIfuC9l1Fn9+fQoWz60k3uYcCeilEsEkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3324
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/11/22 3:51 PM, Venu Busireddy wrote:
> On 2022-01-11 15:22:01 -0600, Brijesh Singh wrote:
>> Hi Venu,
>>
>>
>> On 1/3/22 5:28 PM, Venu Busireddy wrote:
>> ...
>>
>>>> +
>>>> +	 /*
>>>> +	  * Ask the hypervisor to mark the memory pages as private in the RMP
>>>> +	  * table.
>>>> +	  */
>>>
>>> Indentation is off. While at it, you may want to collapse it into a one
>>> line comment.
>>>
>>
>> Based on previous review feedback I tried to keep the comment to 80
>> character limit.
> 
> Isn't the line length limit 100 now? Also, there are quite a few lines
> that are longer than 80 characters in this file, and elsewhere.
> 
> But you can ignore my comment.
> 

Yes, the actual line limit is 100, but I was asked to keep the comments 
to 80 cols [1] to keep it consistent with other comments in this file.

https://lore.kernel.org/lkml/f9a69ad8-54bb-70f1-d606-6497e5753bb0@amd.com/

thanks