Date:   Tue, 11 Jan 2022 16:42:51 -0600
From:   Venu Busireddy <venu.busireddy@oracle.com>
To:     Brijesh Singh <brijesh.singh@amd.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 12/40] x86/sev: Add helper for validating pages in
 early enc attribute changes
Message-ID: <Yd4H6/inP576Kppv@dt>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-13-brijesh.singh@amd.com>
 <YdOGk5b0vYSpP1Ws@dt>
 <7934f88f-8e2b-ea45-6110-202ea8c2ad64@amd.com>
 <Yd374d2+XdBD+vTM@dt>
 <91194a7c-b363-6356-4148-5a5222b86a59@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <91194a7c-b363-6356-4148-5a5222b86a59@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6iwjITBpOOsN4Hv0rpg+RFkB7g2wA5A80+GQxK6x9RgkrRYzo/VxCEZkSkvM?=
 =?us-ascii?Q?E5Z2SVAkOTup3MQVdnn+q0ysBuM7I92SCNOtF/M14YsUpi6laNK+DyReSTKu?=
 =?us-ascii?Q?Z77fyCXzHz7u7hxL0Tb0MLABUi0GDJQzzKylKXG7I530iO5Gxi+Z9mQsO9Fj?=
 =?us-ascii?Q?jpcogYyn6W1dJUQqGE7YyoNNRWju3Hyogwl35XR5zy9EjKdVH/VzJQjY8Img?=
 =?us-ascii?Q?PilKPw0663TuObuUhTtMMfNKWQ8tZKf6oHkdnb/XUWkIkgd5KxuWWBWivdwV?=
 =?us-ascii?Q?lwO8FkXmu0sogLjsG3FZOL1RxwXUx/cD/qPVxrGRVnaBa0JeqNVG/RyJL/b8?=
 =?us-ascii?Q?QEj4MoDbBzQK0/qdSJ4eunb7mVg9vRPk0jM9TYIqab01d9EZL+WUImC0JNjA?=
 =?us-ascii?Q?QQjHbL46a7QuLku8E8BYtN3SzQWLrcMOHP75gB1qyKqjq2LdEEbOCzcFADx1?=
 =?us-ascii?Q?hzrjVCkGrXZ5HYLcdiYxw0pGEP+GMWod+zTn8Pa8x4c2zcA2jKxtk8/1BjNS?=
 =?us-ascii?Q?pCLYUbPkaWdcmtFI8J/UCoaKgrpd6J2JAY3w7sNiyJp9/rgWpXHv2ipGVqig?=
 =?us-ascii?Q?JkGdgpycBCGfco0BmHHn0HKji2bX6JUIjKILb6YLurLM/rTjoQw1tdAe74dM?=
 =?us-ascii?Q?XQ9a9nAIbu/Q3yc2PiXbgb958tSghsEIcZxkluvczWMjIpXzKK2/U38E7O3V?=
 =?us-ascii?Q?4KwGlENk4qDkhIFkAovN+1QZAbwlS+Vhl3QwgZ+YPnzcBwIZSxCtIbm3bsxP?=
 =?us-ascii?Q?05B16Ka9NktmWtbuQ5OyxtkPTs9k6x8GJZb+y5AcsjOTR2IjNnFAunqK2T+7?=
 =?us-ascii?Q?L69erj7dodQBAX9BEGqRi8bArcWswx2h24VtjzulV+E6o+zBmbKw7ACUnJ7e?=
 =?us-ascii?Q?7OgDnjI16RxgdgBsLTyNhsBt6CG5fndHMR4ik/paW5iIkbcVnAk5FQLdmnJh?=
 =?us-ascii?Q?1CAvLBPjdC4FooMKlGPKyuFQE9bK6+33TwuMm/KASdRNh8c1uwd1KApZcxjD?=
 =?us-ascii?Q?Q69BXXopK+dae1GZIM20FOC/v82UxlhIK366YpKhcnPXswvfrsuY0CcbYC3c?=
 =?us-ascii?Q?PVM5QVctQpv1Rj/9ZQCR6PkyBmzuL9ObnGorX6nifKnSM1SBe7usVvlH4pzN?=
 =?us-ascii?Q?QBJNN/L/IWNy1nJ92SFGcw0DO7cb2zpYGhnkLeArDuE8Jie1vJL/UtX9eb7v?=
 =?us-ascii?Q?oEfNQGQ+F60kSdm+kK/0PofqKlbRqT+kMquCORydDZ1cD4q/T7uTsTAFYKDJ?=
 =?us-ascii?Q?zVexMYx9nK3uXxY/FRd4GyE4Uwu18XyWr85vjSu5N0higSIhTPzIOy8WjOcU?=
 =?us-ascii?Q?FBKlf88csBjLCyXK2n7Xpr/jhJZ0JIOGwoeJq6aUOWNn6btcKVmp8zI0BUZK?=
 =?us-ascii?Q?RmsY2KSBYP3uEVHWGDGAaYFmlqXVcrmtZYkQtFgXdHrDPZEqwRFyptZEUwMk?=
 =?us-ascii?Q?jsi5npoVgjNwqtmcbW4EWETdi10qk2u4iEA+/7DBYFUe7tu8NH9XQVYUay9x?=
 =?us-ascii?Q?F3QvZfhr/5nWkv3O1h1NXsmBTqkzMFVqyTGYnuf9QrJxMPDlUTZ/FmBnhEib?=
 =?us-ascii?Q?fzj46n/0WFisAc7NgItys/Rdnzv8L6KcTNzEWYyxbje36VnSLbsaqnKRQ0Kw?=
 =?us-ascii?Q?xaniFCmXkHV3gzeQqOA2Ekwd9qz/5uLEsE/NagR0wO59yKsb0Y+Eku6tnpCk?=
 =?us-ascii?Q?UeFF+w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43c8d086-44eb-448c-dd56-08d9d553b6a3
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2576.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 22:42:57.4928
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MTvSVwpkCjhFj1I9HXSwJLkKu3X1OixtbRxwWyeBtEbSxeuKGj4aR+QiQJ6Mo4cR+SMbDS3R7OnGZS4pQYMA5IVG/J0qrS18eNeAczm85d0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4796
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10224 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201110119
X-Proofpoint-GUID: gNmq-IqfPnsmlcjVVCw5G1pmL4eFVy_R
X-Proofpoint-ORIG-GUID: gNmq-IqfPnsmlcjVVCw5G1pmL4eFVy_R
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-01-11 15:57:13 -0600, Brijesh Singh wrote:
> 
> 
> On 1/11/22 3:51 PM, Venu Busireddy wrote:
> > On 2022-01-11 15:22:01 -0600, Brijesh Singh wrote:
> > > Hi Venu,
> > > 
> > > 
> > > On 1/3/22 5:28 PM, Venu Busireddy wrote:
> > > ...
> > > 
> > > > > +
> > > > > +	 /*
> > > > > +	  * Ask the hypervisor to mark the memory pages as private in the RMP
> > > > > +	  * table.
> > > > > +	  */
> > > > 
> > > > Indentation is off. While at it, you may want to collapse it into a one
> > > > line comment.
> > > > 
> > > 
> > > Based on previous review feedback I tried to keep the comment to 80
> > > character limit.
> > 
> > Isn't the line length limit 100 now? Also, there are quite a few lines
> > that are longer than 80 characters in this file, and elsewhere.
> > 
> > But you can ignore my comment.
> > 
> 
> Yes, the actual line limit is 100, but I was asked to keep the comments to
> 80 cols [1] to keep it consistent with other comments in this file.

Well, now that you mention it, the comment that immediately precedes this
one in the file is 91 characters long, and the comment that immediately
follows this one is 82 characters long! And both those lines are also
added as part of this patch.

Venu

> 
> https://lore.kernel.org/lkml/f9a69ad8-54bb-70f1-d606-6497e5753bb0@amd.com/
> 
> thanks