Date:   Wed, 12 Jan 2022 00:39:15 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Wanpeng Li <kernellwp@gmail.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, Aili Yao <yaoaili@kingsoft.com>
Subject: Re: [PATCH v2] KVM: LAPIC: Enable timer posted-interrupt when
 mwait/hlt is advertised
Message-ID: <Yd4jMyi4JIE+uh5o@google.com>
References: <1641471612-34483-1-git-send-email-wanpengli@tencent.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1641471612-34483-1-git-send-email-wanpengli@tencent.com>
Precedence: bulk

On Thu, Jan 06, 2022, Wanpeng Li wrote:
> From: Wanpeng Li <wanpengli@tencent.com>
> 
> As commit 0c5f81dad46 (KVM: LAPIC: Inject timer interrupt via posted interrupt) 
> mentioned that the host admin should well tune the guest setup, so that vCPUs 
> are placed on isolated pCPUs, and with several pCPUs surplus for *busy* housekeeping.
> It is better to disable mwait/hlt/pause vmexits to keep the vCPUs in non-root 
> mode. However, we may isolate pCPUs for other purpose like DPDK or we can make 
> some guests isolated and others not, we may lose vmx preemption timer/timer fastpath 
> due to not well tuned setup, and the checking in kvm_can_post_timer_interrupt() 
> is not enough. Let's guarantee mwait/hlt is advertised before enabling posted-interrupt 
> interrupt. vmx preemption timer/timer fastpath can continue to work if both of them 
> are not advertised.
> 
> Reported-by: Aili Yao <yaoaili@kingsoft.com>
> Cc: Aili Yao <yaoaili@kingsoft.com>
> Cc: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> ---

Reviewed-by: Sean Christopherson <seanjc@google.com>