Message-ID: <tencent_236C8935F1179CB3D1788CBF3B179494D60A@qq.com>
Date:   Wed, 12 Jan 2022 14:16:27 +0800
From:   Conley Lee <conleylee@foxmail.com>
To:     Corentin Labbe <clabbe.montjoie@gmail.com>
Cc:     davem@davemloft.net, kuba@kernel.org, mripard@kernel.org,
        wens@csie.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: ethernet: sun4i-emac: replace magic number with
 macro
References: <tencent_58B12979F0BFDB1520949A6DB536ED15940A@qq.com>
 <tencent_71466C2135CD1780B19D7844BE3F167C940A@qq.com>
 <Yd2xC7ZaHrTAXcZd@Red>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Yd2xC7ZaHrTAXcZd@Red>
Precedence: bulk

On 01/11/22 at 05:32下午, Corentin Labbe wrote:
> Date: Tue, 11 Jan 2022 17:32:11 +0100
> From: Corentin Labbe <clabbe.montjoie@gmail.com>
> To: Conley Lee <conleylee@foxmail.com>
> Cc: davem@davemloft.net, kuba@kernel.org, mripard@kernel.org,
>  wens@csie.org, netdev@vger.kernel.org,
>  linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3] net: ethernet: sun4i-emac: replace magic number
>  with macro
> 
> Le Tue, Jan 11, 2022 at 11:05:53AM +0800, Conley Lee a écrit :
> > This patch remove magic numbers in sun4i-emac.c and replace with macros
> > defined in sun4i-emac.h
> > 
> > Signed-off-by: Conley Lee <conleylee@foxmail.com>
> 
> Hello
> 
> I sent a CI job witch next-20220107+yourpatch and saw no regression.
> 
> Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> Tested-on: sun4i-a10-olinuxino-lime
> 
> Thanks!
> Regards
> 
Could you please provide more information about it ? I test it on my
marsboard-a20 and everything work well.

Thanks