Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8BA8C43219 for ; Wed, 12 Jan 2022 07:50:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237875AbiALHuE (ORCPT ); Wed, 12 Jan 2022 02:50:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231359AbiALHuD (ORCPT ); Wed, 12 Jan 2022 02:50:03 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95AC1C06173F; Tue, 11 Jan 2022 23:50:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4C87CB81E02; Wed, 12 Jan 2022 07:50:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0B24C36AEA; Wed, 12 Jan 2022 07:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641973800; bh=/zzr28pbn0mYUQ3C33VgJ093abXpWPwu5+XYGnZ7HOI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gOqryZE8ISgc3MSbb89OPqbHB6lIMKLRTWkJZLRLlDZHEJA/FQtD3G2PIsejf5vyO lxWl5kHtlDWx+2yc/6CJmmQfiG8ge1a5br3t/cLssV7rpwVrhnob4JaBH1U0JI8tgp 25eSYGvcuqTn0fJwoecvD18TO+bpXoyGmxgE6J843NfM0Dl99XRgKTfhkiHWwudeGs 7D+149LV6SKMnsY02KSCXxco7iYDswVneC5OEeIwsKfK+dPeBzBigILcjGp/cDqASq Qk5EMf32ZCO+TMplE91xnTN6iWxt2tL1yHcc5CzTv9Khp2Z5z2siK7vZ+2n2awVCAr 2SY6QAcVjlhug== From: Kalle Valo To: Jerome Pouiller Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "David S . Miller" , devicetree@vger.kernel.org, Rob Herring , linux-mmc@vger.kernel.org, Pali =?utf-8?Q?Roh?= =?utf-8?Q?=C3=A1r?= , Ulf Hansson Subject: Re: [PATCH v9 23/24] wfx: remove from the staging area References: <20220111171424.862764-1-Jerome.Pouiller@silabs.com> <20220111171424.862764-24-Jerome.Pouiller@silabs.com> Date: Wed, 12 Jan 2022 09:49:54 +0200 In-Reply-To: <20220111171424.862764-24-Jerome.Pouiller@silabs.com> (Jerome Pouiller's message of "Tue, 11 Jan 2022 18:14:23 +0100") Message-ID: <874k69jsv1.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jerome Pouiller writes: > From: J=C3=A9r=C3=B4me Pouiller > > Signed-off-by: J=C3=A9r=C3=B4me Pouiller > --- > .../bindings/net/wireless/silabs,wfx.yaml | 125 --- > drivers/staging/wfx/Kconfig | 8 - > drivers/staging/wfx/Makefile | 25 - > drivers/staging/wfx/bh.c | 330 ------- > drivers/staging/wfx/bh.h | 33 - > drivers/staging/wfx/bus.h | 38 - > drivers/staging/wfx/bus_sdio.c | 272 ------ > drivers/staging/wfx/bus_spi.c | 271 ------ > drivers/staging/wfx/data_rx.c | 94 -- > drivers/staging/wfx/data_rx.h | 18 - > drivers/staging/wfx/data_tx.c | 596 ------------- > drivers/staging/wfx/data_tx.h | 68 -- > drivers/staging/wfx/debug.c | 365 -------- > drivers/staging/wfx/debug.h | 19 - > drivers/staging/wfx/fwio.c | 405 --------- > drivers/staging/wfx/fwio.h | 15 - > drivers/staging/wfx/hif_api_cmd.h | 555 ------------ > drivers/staging/wfx/hif_api_general.h | 262 ------ > drivers/staging/wfx/hif_api_mib.h | 346 -------- > drivers/staging/wfx/hif_rx.c | 416 --------- > drivers/staging/wfx/hif_rx.h | 17 - > drivers/staging/wfx/hif_tx.c | 513 ----------- > drivers/staging/wfx/hif_tx.h | 60 -- > drivers/staging/wfx/hif_tx_mib.c | 324 ------- > drivers/staging/wfx/hif_tx_mib.h | 49 -- > drivers/staging/wfx/hwio.c | 352 -------- > drivers/staging/wfx/hwio.h | 75 -- > drivers/staging/wfx/key.c | 241 ----- > drivers/staging/wfx/key.h | 20 - > drivers/staging/wfx/main.c | 506 ----------- > drivers/staging/wfx/main.h | 43 - > drivers/staging/wfx/queue.c | 307 ------- > drivers/staging/wfx/queue.h | 45 - > drivers/staging/wfx/scan.c | 149 ---- > drivers/staging/wfx/scan.h | 22 - > drivers/staging/wfx/sta.c | 833 ------------------ > drivers/staging/wfx/sta.h | 73 -- > drivers/staging/wfx/traces.h | 501 ----------- > drivers/staging/wfx/wfx.h | 164 ---- > 39 files changed, 8555 deletions(-) > delete mode 100644 drivers/staging/wfx/Documentation/devicetree/bindings= /net/wireless/silabs,wfx.yaml > delete mode 100644 drivers/staging/wfx/Kconfig > delete mode 100644 drivers/staging/wfx/Makefile > delete mode 100644 drivers/staging/wfx/bh.c > delete mode 100644 drivers/staging/wfx/bh.h > delete mode 100644 drivers/staging/wfx/bus.h > delete mode 100644 drivers/staging/wfx/bus_sdio.c > delete mode 100644 drivers/staging/wfx/bus_spi.c > delete mode 100644 drivers/staging/wfx/data_rx.c > delete mode 100644 drivers/staging/wfx/data_rx.h > delete mode 100644 drivers/staging/wfx/data_tx.c > delete mode 100644 drivers/staging/wfx/data_tx.h > delete mode 100644 drivers/staging/wfx/debug.c > delete mode 100644 drivers/staging/wfx/debug.h > delete mode 100644 drivers/staging/wfx/fwio.c > delete mode 100644 drivers/staging/wfx/fwio.h > delete mode 100644 drivers/staging/wfx/hif_api_cmd.h > delete mode 100644 drivers/staging/wfx/hif_api_general.h > delete mode 100644 drivers/staging/wfx/hif_api_mib.h > delete mode 100644 drivers/staging/wfx/hif_rx.c > delete mode 100644 drivers/staging/wfx/hif_rx.h > delete mode 100644 drivers/staging/wfx/hif_tx.c > delete mode 100644 drivers/staging/wfx/hif_tx.h > delete mode 100644 drivers/staging/wfx/hif_tx_mib.c > delete mode 100644 drivers/staging/wfx/hif_tx_mib.h > delete mode 100644 drivers/staging/wfx/hwio.c > delete mode 100644 drivers/staging/wfx/hwio.h > delete mode 100644 drivers/staging/wfx/key.c > delete mode 100644 drivers/staging/wfx/key.h > delete mode 100644 drivers/staging/wfx/main.c > delete mode 100644 drivers/staging/wfx/main.h > delete mode 100644 drivers/staging/wfx/queue.c > delete mode 100644 drivers/staging/wfx/queue.h > delete mode 100644 drivers/staging/wfx/scan.c > delete mode 100644 drivers/staging/wfx/scan.h > delete mode 100644 drivers/staging/wfx/sta.c > delete mode 100644 drivers/staging/wfx/sta.h > delete mode 100644 drivers/staging/wfx/traces.h > delete mode 100644 drivers/staging/wfx/wfx.h I'm not sure what's your plan here, but with staging wireless drivers there's usually a simple simple move (git mv) of the driver from drivers/staging to drivers/net/wireless. An example here: https://git.kernel.org/linus/5625f965d764 What you seem to do here is that you add a new driver to drivers/net/wireless and then remove the old driver from drivers/staging. And I'm guessing these two drivers are not identical and have differences? --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes