Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25887C43217 for ; Wed, 12 Jan 2022 08:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351378AbiALIFn (ORCPT ); Wed, 12 Jan 2022 03:05:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237544AbiALIFl (ORCPT ); Wed, 12 Jan 2022 03:05:41 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55244C06173F; Wed, 12 Jan 2022 00:05:41 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id b1-20020a17090a990100b001b14bd47532so3298599pjp.0; Wed, 12 Jan 2022 00:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=auwyob08IbwW94XZ4f2/DsmTnLD3tEUnrhYCGAW4mV0=; b=E7CZjNp8ew/pIigi8/9fGrQIVAoLQrh14ruflwowcQicZ4GkxWA8SdA/yuUPMnlaJM pXIe/8A62KQUNV7ITwg0TmIuUG6SBpjyQs4cmWgKVNZHcIGjtWG9G7I4slFXoLpGLLa0 1ueDK/pm6PgGWpLoNoPngyoxdih2T8odceBi6oXniuUoAbB5V2OApVtgiWI/T1WOVxhc Tep/DfP9PlB8NC71xSYYizghYjBi+arCrSc84egFVvnTUMb95p+5Zy1YTI5Nm/Anm38o MJ1/qBmyHdou3lQjUnV17Xrv6X9mDFPGJf7KfLwhvXo1S9glIsaasLQ1oc1Ek4UZ6HWH CTLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=auwyob08IbwW94XZ4f2/DsmTnLD3tEUnrhYCGAW4mV0=; b=xn/OEoBFUuuzwMm2/f2TB3ZG1g/cNsE6ZnccBwBP0i4WoYu5xSFkY2UNqtFvA1hnyF 9m69pjc35t4iiBL5Ii/GYoN6RAAmEeFfNNJUf4ZE/BKDN76MjBfErELRFZbfIBMvjyk7 cG6rBUc/mos6pszbn+Ae6f2UL73l1RUyZiYGOO64EpB2zy2i7UjpG+ujUFl0zc/1uIpU G450lZZ9sHGKDaxYBHIsNjZxaKR3D/dWAGW4r9y2XVdkoX3vRrdHUn9fZ9Lxr/XD375e gxBoznPMa90mMHC53JSkPPXw29xpRIA2FbRBpxoDKCop2/QQHrp3yRzO450qJcm7CBl0 G+tg== X-Gm-Message-State: AOAM5320a8nbsLw81LxU/KaVB+un8MZuQmGv2xMavMaqllL67/xpfwEm YHTMPaBnq084tQXcbMWwluFgZBa6lczdCA== X-Google-Smtp-Source: ABdhPJzD7+K8uKCTMJoKLJqSdgcxNQz56yyK1twt2mzjiP2zQ/JTpowXz/ezrXCHOxcVLhActIDfuQ== X-Received: by 2002:a17:902:dac5:b0:14a:5f50:ed0f with SMTP id q5-20020a170902dac500b0014a5f50ed0fmr4286228plx.58.1641974740890; Wed, 12 Jan 2022 00:05:40 -0800 (PST) Received: from [10.1.1.24] (222-155-5-102-adsl.sparkbb.co.nz. [222.155.5.102]) by smtp.gmail.com with ESMTPSA id x2sm1666008pgo.2.2022.01.12.00.05.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jan 2022 00:05:40 -0800 (PST) Subject: Re: [PATCH 08/17] ptrace/m68k: Stop open coding ptrace_report_syscall To: Geert Uytterhoeven References: <87r19opkx1.fsf_-_@email.froward.int.ebiederm.org> <20220103213312.9144-8-ebiederm@xmission.com> <6060f799-d0c5-e4c2-a81c-2bd872ce3d5a@gmail.com> Cc: Finn Thain , Al Viro , "Eric W. Biederman" , Linux Kernel Mailing List , Linux-Arch , Linus Torvalds , Oleg Nesterov , Kees Cook , Linux API , linux-m68k From: Michael Schmitz Message-ID: <98e43c68-0a4b-004a-bb1b-015fc80a1724@gmail.com> Date: Wed, 12 Jan 2022 21:05:32 +1300 User-Agent: Mozilla/5.0 (X11; Linux ppc; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Am 12.01.2022 um 20:55 schrieb Geert Uytterhoeven: > Hi Michael, > >> What's the other reason these patches are still stuck, Geert? Did we >> ever settle the dispute about what return code ought to abort a syscall >> (in the seccomp context)? > > IIRC, some (self)tests were still failing? Too true - but I don't think my way of building the testsuite was entirely according to the book. And I'm not sure I ran the testsuite with more than one of the return code options. In all honesty, I had been waiting for Adrian Glaubitz to test the patches with his seccomp library port instead of relying on the testsuite. Still, reason enough to split off the removal of syscall_trace() from the seccomp stuff if it helps with Eric's patch series. Cheers, Michael > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >