Date:   Wed, 12 Jan 2022 10:20:54 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Michael Wu <michael@allwinnertech.com>
Cc:     ulf.hansson@linaro.org, wens@csie.org, samuel@sholland.org,
        andre.przywara@arm.com, jernej.skrabec@gmail.com,
        linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mmc:sunxi-mmc:fix clock division for timing mode
Message-ID: <20220112092054.4agh3lydvibea5wh@houat>
References: <20211222031521.34170-1-michael@allwinnertech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fymmmzrzovlh7ofo"
Content-Disposition: inline
In-Reply-To: <20211222031521.34170-1-michael@allwinnertech.com>
Precedence: bulk


--fymmmzrzovlh7ofo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Michael,

Thanks for your patch

On Wed, Dec 22, 2021 at 11:15:21AM +0800, Michael Wu wrote:
> When use new timings,all speed mode requires a doubled module clock
> if speed mode is ddr,requires a four times module clock
> When use old timings,only 8 bit ddr requires a doubled module clock
>=20
> Signed-off-by: Michael Wu <michael@allwinnertech.com>
> ---
>  drivers/mmc/host/sunxi-mmc.c | 27 +++++++++++++++------------
>  1 file changed, 15 insertions(+), 12 deletions(-)
>=20
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index afeefead6501..7b47ec453fb6 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -774,20 +774,23 @@ static int sunxi_mmc_clk_set_rate(struct sunxi_mmc_=
host *host,
>  	if (!ios->clock)
>  		return 0;
> =20
> -	/*
> -	 * Under the old timing mode, 8 bit DDR requires the module
> -	 * clock to be double the card clock. Under the new timing
> -	 * mode, all DDR modes require a doubled module clock.
> -	 *
> -	 * We currently only support the standard MMC DDR52 mode.
> -	 * This block should be updated once support for other DDR
> -	 * modes is added.
> +	/**
> +	 * When use new timings, all speed mode requires a doubled module clock.
> +	 * if speed mode is ddr, requires a four times module clock.
> +	 * When use old timings, only 8 bit ddr requires a doubled module clock.
>  	 */

I found the original comment to be clearer, maybe we can change it to
something like:

    /*
     * Under the old timing mode, 8 bit DDR requires the module
     * clock to be double the card clock. Under the new timing
     * mode, all modes require a doubled module clock, and DDR modes
     * require a quadrupled module clock.
     *
     * ...

> -	if (ios->timing =3D=3D MMC_TIMING_MMC_DDR52 &&
> -	    (host->use_new_timings ||
> -	     ios->bus_width =3D=3D MMC_BUS_WIDTH_8)) {
> -		div =3D 2;
> +	if (host->use_new_timings) {
>  		clock <<=3D 1;
> +		if (ios->timing =3D=3D MMC_TIMING_MMC_DDR52) {
> +			div =3D 2;

Shouldn't that be 4?

> +			clock <<=3D 1;
> +		}
> +	} else {
> +		if (ios->timing =3D=3D MMC_TIMING_MMC_DDR52 &&
> +				(ios->bus_width =3D=3D MMC_BUS_WIDTH_8)) {

This creates some checkpatch.pl --strict warnings

Maxime

--fymmmzrzovlh7ofo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYd6ddgAKCRDj7w1vZxhR
xaLiAP47v9sW+jH0z6DXKRDumXm1PSSMgqdjfsjbfy1lddD97gD9FGv36UyHu+Do
VjNu5T34Utzn7S9mZeT4p/pUA5ic/wY=
=F8YC
-----END PGP SIGNATURE-----

--fymmmzrzovlh7ofo--