Date:   Wed, 12 Jan 2022 10:34:15 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Michael Wu <michael@allwinnertech.com>
Cc:     ulf.hansson@linaro.org, wens@csie.org, samuel@sholland.org,
        andre.przywara@arm.com, jernej.skrabec@gmail.com,
        linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mmc: sunxi-mmc: check ocr_avail on resource request
Message-ID: <20220112093415.wdy3ht5yizw5lffl@houat>
References: <20220104060325.3957-1-michael@allwinnertech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pow7a6h6ea2halol"
Content-Disposition: inline
In-Reply-To: <20220104060325.3957-1-michael@allwinnertech.com>
Precedence: bulk


--pow7a6h6ea2halol
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jan 04, 2022 at 02:03:25PM +0800, Michael Wu wrote:
> Some platforms have no regulator, discrete power devices are used instead.

Is it really the case? vmmc at least should be mandatory so a platform
not having a regulator would violate the binding itself.

> However, sunxi_mmc_probe does not catch this exception when regulator is
> absent in DTS. This leads to sd or eMMC init failure.

This will still happen with your patch though?

> To solve this, a fixed vmmc regulator must be hooked up in DTS, like this:
> reg_dummy_vmmc: dummy_vmmc {
> 	compatible =3D "regulator-fixed";
> 	regulator-name =3D "dummy-vmmc";
> 	regulator-min-microvolt =3D <3300000>;
> 	regulator-max-microvolt =3D <3300000>;
> };
>=20
> mmc0:mmc@4020000 {
> 	compatible =3D "allwinner,sun50i-a100-emmc";
> 	device_type =3D "mmc0";
> 	vmmc-supply =3D <&reg_dummy_vmmc>;
> }
>=20
> In this patch, we print an error message and abort the probe process if
> the regulator is not specified in DTS.

I'm fine with the patch itself, but it's really not clear to me what
situation is being fixed or improved here.

You're first mentioning that this is fixing the driver probing even if a
regulator is absent, but then states (rightfully) that in such a case we
should use a fixed regulator. So we should always have a regulator then?

I assume that you want the driver to properly error out instead of going
on if either a regulator is missing or if its voltages are out of range?

If the former, then we should probably check if host->mmc->supply.vmmc
returned an error. If the latter, then yes, checking ocr_avail is
probably fine but we should make it clearer in the error message that
it's what it's about.

Maxime

--pow7a6h6ea2halol
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYd6glwAKCRDj7w1vZxhR
xYMDAQDOvoByLoNbucD0rg09oRxg0ac/oM8XXvRnOEoOgNtc6AD7B4fNMTPoPSrt
SOyuoXTJa0OcH67vLGECca6JGG6L/gg=
=5+yC
-----END PGP SIGNATURE-----

--pow7a6h6ea2halol--