Date:   Wed, 12 Jan 2022 10:41:29 +0100 (CET)
From:   Miroslav Benes <mbenes@suse.cz>
To:     =?ISO-8859-15?Q?Martin_Li=A8ka?= <mliska@suse.cz>
cc:     linux-kernel@vger.kernel.org, peterz@infradead.org,
        jpoimboe@redhat.com
Subject: Re: [PATCH] objtool: Fix -Wformat-truncation seen with GCC 12.
In-Reply-To: <5168172b-d6f2-a13b-5d43-175cd864ebe9@suse.cz>
Message-ID: <alpine.LSU.2.21.2201121039160.27851@pobox.suse.cz>
References: <5168172b-d6f2-a13b-5d43-175cd864ebe9@suse.cz>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="1678380546-953004748-1641980489=:27851"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--1678380546-953004748-1641980489=:27851
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

Hi,

On Wed, 12 Jan 2022, Martin Liška wrote:

> The patch fixes the following warning that seems reasonable:
> 
> check.c:2836:58: error: '%d' directive output may be truncated writing between
> 1 and 10 bytes into a region of size 9 [-Werror=format-truncation=]
> 2836 |                 snprintf(pvname, sizeof(pvname), "pv_ops[%d]", idx);
> 
> Signed-off-by: Martin Liška <mliska@suse.cz>
> ---
>  tools/objtool/check.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index a9a1f7259d62..9555f7ad57cd 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -2852,7 +2852,7 @@ static inline bool func_uaccess_safe(struct symbol
> *func)
>  
>  static inline const char *call_dest_name(struct instruction *insn)
>  {
> -	static char pvname[16];
> +	static char pvname[20];
>  	struct reloc *rel;
>  	int idx;

a similar patch has already been posted (not merged yet though).

https://lore.kernel.org/all/20211223182707.42590-1-kilobyte@angband.pl/

Thanks

Miroslav
--1678380546-953004748-1641980489=:27851--