From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Pali =?ISO-8859-1?Q?Roh=E1r?= <pali@kernel.org>
Cc:     linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        Kalle Valo <kvalo@codeaurora.org>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "David S . Miller" <davem@davemloft.net>,
        devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v9 08/24] wfx: add bus_sdio.c
Date:   Wed, 12 Jan 2022 12:18:58 +0100
Message-ID: <42104281.b1Mx7tgHyx@pc-42>
Organization: Silicon Labs
In-Reply-To: <20220112105859.u4j76o7cpsr4znmb@pali>
References: <20220111171424.862764-1-Jerome.Pouiller@silabs.com> <20220111171424.862764-9-Jerome.Pouiller@silabs.com> <20220112105859.u4j76o7cpsr4znmb@pali>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?oXltm3vX/4bodzeI6Kq8Bwn+QTJmmWTfQveByhYCVY6QngWRj7w8uNGQS1?=
 =?iso-8859-1?Q?e9hpC7s72OXKqEjFOXix+UaT9KsG37xVqSdcl9JFZJka4ZKgxXcscwxeYO?=
 =?iso-8859-1?Q?Bj1EgUd4nADM92cUP4TZin3BjIRlMhLCyBauVZfWlo903Gqs+FJwCSKGw1?=
 =?iso-8859-1?Q?ARe+DnClV3AsG2a1uaRR/L98qrZoyHu6hluCe+VtXLlLhJaEvNMeSvqSi1?=
 =?iso-8859-1?Q?mxJe/aQrHzNOAekSJ/WpFmdDDGvZNfq4j09AkLiwG1VW7i1dkp26hNWTKG?=
 =?iso-8859-1?Q?++zjIB7mCcRHHETvl5EJWh70AUid65bmz1U3so+AsfHyAH+RJoyDs/5uW7?=
 =?iso-8859-1?Q?FW22pe4Yb9fRbpK1povqKzqF7GrAZG+A3Q8yYl0kF+DNWijTVZrLtO4eNZ?=
 =?iso-8859-1?Q?BuHtE4hOPvVBIv6NT0GRtXUSFds8V9j0/NOoRAK1hufvmN93NhsTcVMrQm?=
 =?iso-8859-1?Q?2B61TdFcpKZzAcrMTF9EaNVmBZcykUhNgvAl6+C4LU8zcsZ/6QnoRd6rk2?=
 =?iso-8859-1?Q?pePnVKRSOOOEiSyHD/AopXkSWO0jvz4VEW7vGdJlF5XeoiDQG/9hEoQqv5?=
 =?iso-8859-1?Q?E4A2FwVwTgqwni+ASAHtGPoPztI4i9YMWzCtxVAhYH7IL8yFANGJNjTavS?=
 =?iso-8859-1?Q?WE1s6BzTDDo2sCGxBYaG9Za58XxVH4s+imJRAmnE2b4XEtcJx41VZt+T65?=
 =?iso-8859-1?Q?Gxbjx0sfE6sXvxNVJfRhGcH+rOp44H4YmEBvbJ92pS+EoR5gDMZSFRODvF?=
 =?iso-8859-1?Q?ecmDv/rPR8XlKCASHtXy30mRbnzO/rhiCwLW6ypIMl5CpXPgB+lD1prgO5?=
 =?iso-8859-1?Q?lAOID2BfqkJYS6eBitg7LyaGKWg0A3tv9AhHRQM+pQ1SscBBoMasqqSAlv?=
 =?iso-8859-1?Q?R6gOphlB+RQNfBefwG7m1ua+sFydxkALE0m/coxj+3b4za823EUfKdp2AQ?=
 =?iso-8859-1?Q?otgEDnGUk/+tLvyhl+t7U9oGR0qpOu+MD4R7ydlKbLsVJ9wP2nlBbVG75U?=
 =?iso-8859-1?Q?DNeIldozZxlFP1DaFe5LOI2fzFa9c05ixLuRvbqssDvRmexbtYogtXkG9l?=
 =?iso-8859-1?Q?Nz8/xUF+a6AtKEcHbhRuih9hb/n+/oFmmQVFnJtRfnQpBE6Bm/9w0lkOgC?=
 =?iso-8859-1?Q?XtVeMmvEMlpWEP9VuxOS6cKJICSmFKCYH+/lgnVd6YIAN/yVOaYOrBRdqr?=
 =?iso-8859-1?Q?bvUi9c7R+/+wAaiteNXEhkbLmO2aWMlxQrkl/bRKVDDtRrFSiGP7+YbSEE?=
 =?iso-8859-1?Q?u/K7c0y9ddJ6dsmIObNGCr0QHNNjRTXQbm2VMhpul8547KMxMH6sRd8Oua?=
 =?iso-8859-1?Q?xorv2fBHQ6IDFGt7L+bfRhfOKK2k0/Zi47QIm94QGjx4mAwwJKvMU6cKV2?=
 =?iso-8859-1?Q?sfY7ePcMMIKkTnpuV523x9X88nfghfEpvQI1SvmMF3p0mImSjfNo23xPRe?=
 =?iso-8859-1?Q?BWH6n4Z/4JMp9tDZ7rebdXFnXVjeqL4+WdPzgZRfYJoTFqvuVvmORCHben?=
 =?iso-8859-1?Q?m961L3ZshMUjDWPfVHdel4k0aHugee/jKs02bar7ref2KZnz8avK1gpDNu?=
 =?iso-8859-1?Q?bRWw7vQ0IArbHW305WvJfbReux4TzIIRqOLU3yFWlJbm3vjnZvirG9w9h7?=
 =?iso-8859-1?Q?4EwJtKcIYCkDcPs5pToSZRZHQ3fobMFM+ZYYzl2lsXu0ZD4JaLTy6dQNG9?=
 =?iso-8859-1?Q?OKyl5Su+LCb+3nCSPY2bGkDRSvozH2teTMN0OuoL6ZV3zIYP/QIlTF0goL?=
 =?iso-8859-1?Q?Rby3Ragvz0KEs43kh6mfpsV1E=3D?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf507a75-cb5d-45c9-0be6-08d9d5bd5919
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5650.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2022 11:19:07.3265
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1yL8J5cheTH/Wv7aAZk8NCxtrqJ/E5zKwEWHg7EirJ2OLWWHty3YCJnbQeDSo5yWEqZ9OB++UIK77Z410B815w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5278
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 12 January 2022 11:58:59 CET Pali Roh=E1r wrote:
> On Tuesday 11 January 2022 18:14:08 Jerome Pouiller wrote:
> > +static const struct sdio_device_id wfx_sdio_ids[] =3D {
> > +     { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200)=
 },
> > +     { },
> > +};
>=20
> Hello! Is this table still required?

As far as I understand, if the driver does not provide an id_table, the
probe function won't be never called (see sdio_match_device()).

Since, we rely on the device tree, we could replace SDIO_VENDOR_ID_SILABS
and SDIO_DEVICE_ID_SILABS_WF200 by SDIO_ANY_ID. However, it does not hurt
to add an extra filter here.

> > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids);
> > +
> > +struct sdio_driver wfx_sdio_driver =3D {
> > +     .name =3D "wfx-sdio",
> > +     .id_table =3D wfx_sdio_ids,
> > +     .probe =3D wfx_sdio_probe,
> > +     .remove =3D wfx_sdio_remove,
> > +     .drv =3D {
> > +             .owner =3D THIS_MODULE,
> > +             .of_match_table =3D wfx_sdio_of_match,
> > +     }
> > +};
> > --
> > 2.34.1
> >
>=20


--=20
J=E9r=F4me Pouiller