From:   Pawel Laszczak <pawell@cadence.com>
To:     Peter Chen <peter.chen@kernel.org>
CC:     "a-govindraju@ti.com" <a-govindraju@ti.com>,
        "frank.li@nxp.com" <frank.li@nxp.com>,
        "rogerq@kernel.org" <rogerq@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] usb: cdnsp: Fix segmentation fault in cdns_lost_power
 function
Thread-Topic: [PATCH] usb: cdnsp: Fix segmentation fault in cdns_lost_power
 function
Thread-Index: AQHYBsrYK4fAFdkFQkqeOjWZYn4NnaxfWfuAgAAAlzA=
Date:   Wed, 12 Jan 2022 13:13:10 +0000
Message-ID: <BYAPR07MB5381D8455AF977200D503D15DD529@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20220111090737.10345-1-pawell@gli-login.cadence.com>
 <20220112125615.GC3796@Peter>
In-Reply-To: <20220112125615.GC3796@Peter>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nOgvkTW/Zw9L4iJJ1O0XD6cN6QO3DvILktTlUeJS+mVFCJUb23CNYFeXI1Wk?=
 =?us-ascii?Q?9xznl9AyxwMtauVDw/MfRU9AE/lh4tPr1dnjXq1UYP1BY8zoKtTLB/EFDKgi?=
 =?us-ascii?Q?mY0EjkF1wMrbA8nusCEv10oIuKt6aA9awr1dV5934nD4dF5gY0ENG7BbUU4k?=
 =?us-ascii?Q?iStJASuQReNNts9HSOXdMxAYU8CRYjkjTAoG4Z+aobxo2mKRvtUcAbMJS1cU?=
 =?us-ascii?Q?6WH86wIw5E3W/J6JTGAWK6F+XR6IeX+0PuwYGEX5g/QpOEzsZ9GxjtFcLcLh?=
 =?us-ascii?Q?nfQac1Ef/KtGq20ho8DyiER7LkJBwH/9yMUzPxH3kpxBQt5RjhToghDoLWLm?=
 =?us-ascii?Q?jZiHOjDU5PXmyQpgo7y/GCvjkdLsLuWPunsAi148LTuCF1N1OkuQAK9/5LZr?=
 =?us-ascii?Q?KWo1AQ/SamJtSAQI8Ky5KkI9CbNmGuR75hLCO4nBZAMv0jma+zXv4pNfrnb1?=
 =?us-ascii?Q?E5+eS9xbGKkR1Fvty3R8YYzqMcYNEEzYP0eX9+rhjWV5zo711XcxCsgFirf5?=
 =?us-ascii?Q?a54z1xicCcg1OQbq6Jtk3PL54G5Bw6S0K9pvE7TvgjgqYlUUEtFLlspmbfrh?=
 =?us-ascii?Q?XP1BhEL5lNJg0sRopZhLTy1YaugfUMe6mHFF20pmGaMdV8qqeOYRSQD4wyT4?=
 =?us-ascii?Q?n2VyQ54+9LwRNruPtI5zW8lWGSUitrZBHEasXm9+LYsmA4rqaUbp5DAW5kD/?=
 =?us-ascii?Q?eA9HelAiF0+43X6y6McjiC6tBwoozvUNuLn85hrPYPuP7VfVAAdDtzAAFE0g?=
 =?us-ascii?Q?VaVHrfA+ULiM+RNQcZfkdDSm70VZC+ixbTK0knJHiVlYlrefN3GdjhFFcAWT?=
 =?us-ascii?Q?D9gqCaEA2XZ+xfGoYYsMu7/GJye7w1SQepS9r0cKVFwRajrcT/KbRl2a2w3D?=
 =?us-ascii?Q?yDbftMwpTOeb+BV8MtvuukwJGZy30DQoksgsSmRqdf410jBkqAOu28Pt8fye?=
 =?us-ascii?Q?Ef49q/e1qwlK3v2ZdhCrsbzT87llCqxmh55nBcA1LK7A57KVz2w8L1JukIYh?=
 =?us-ascii?Q?U7CFpU1uHL1qNh4uNEaQ+9zMBJhNIcEN9BeB3Y1IMnFrii02tKAwOWWqA+OE?=
 =?us-ascii?Q?0prbgltJgBSXqM7yUDtgbCe7EPR+hS2fTEZAhihoL4cKQm0EzEi7akGSNvAO?=
 =?us-ascii?Q?yTWKvojz+7pfAvbP+1RfAjROXuxPtqN/sVLALgzek7PGf79qiR+uzSisq59N?=
 =?us-ascii?Q?VWqanGo2CntMj8gqfXezeNZF7TU/NJbwcav45BBz2W3+bJ3g1J8eJWZxaGpQ?=
 =?us-ascii?Q?woFkassGwnK/nTjnThhebRa5RGrpMivdXJl96fnqvAHgiy7YwGgT2ab+1kwL?=
 =?us-ascii?Q?5Kea/NODTAuGYDRcuGNjKMlGEVXAzzzDS1/gxycpjiaIRgmONqp4ADIT6nWr?=
 =?us-ascii?Q?THydqG7U0Rh3BAadmDK9g7zVT3+PlsK4YWzP4zDQcxp5N1QLMdJd0UT22dGq?=
 =?us-ascii?Q?Kl9q1g+g/J1HjuIgUkDOuS6quiirsPpH10/OZHsALLccxWnCK3Ykf32HtFys?=
 =?us-ascii?Q?FHj1qMXM2JBzILZNvBB5dYMw1wOI76tJaGrMy1RgRRSyiTaJCNaf6XbXqsOt?=
 =?us-ascii?Q?OoizP+XSlSYEt2V2WFv07yMA8j2PRztn+/6CLl7xvH5cmxy5WY93G8p3DFpK?=
 =?us-ascii?Q?uANj67QquyfssXcJ7HVmzdZGaNYDafbu5Mxg6vwMucttI3Zw87L4KvwE3uVY?=
 =?us-ascii?Q?DvuV9g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9adcd7f-25cd-443e-85aa-08d9d5cd482a
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2022 13:13:10.4769
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vSNa4rKjY4wC9u2puR5IpWsbi2RouKMdtukPPZ7aCp2gYDsq++LD1MpPLbET5ZIyL72/IOwUEchnTGaCkzmt6uyGkbAwg6KOJqoUL6YHwwY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR07MB4010
X-Proofpoint-GUID: FN2tnG_q5IJhVMuv8B3KjVWBAP7xsMhr
X-Proofpoint-ORIG-GUID: FN2tnG_q5IJhVMuv8B3KjVWBAP7xsMhr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-12_04,2022-01-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 malwarescore=0
 suspectscore=0 clxscore=1015 priorityscore=1501 adultscore=0
 mlxlogscore=653 impostorscore=0 spamscore=0 lowpriorityscore=0 mlxscore=0
 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201120087
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>On 22-01-11 10:07:37, Pawel Laszczak wrote:
>> From: Pawel Laszczak <pawell@cadence.com>
>>
>> CDNSP driver read not initialized cdns->otg_v0_regs
>> which lead to segmentation fault. Patch fixes this issue.
>>
>> Fixes: 2cf2581cd229 ("usb: cdns3: add power lost support for system resu=
me")
>> cc: <stable@vger.kernel.org>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>>  drivers/usb/cdns3/drd.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
>> index 55c73b1d8704..d00ff98dffab 100644
>> --- a/drivers/usb/cdns3/drd.c
>> +++ b/drivers/usb/cdns3/drd.c
>> @@ -483,11 +483,11 @@ int cdns_drd_exit(struct cdns *cdns)
>>  /* Indicate the cdns3 core was power lost before */
>>  bool cdns_power_is_lost(struct cdns *cdns)
>>  {
>> -	if (cdns->version =3D=3D CDNS3_CONTROLLER_V1) {
>> -		if (!(readl(&cdns->otg_v1_regs->simulate) & BIT(0)))
>> +	if (cdns->version =3D=3D CDNS3_CONTROLLER_V0) {
>> +		if (!(readl(&cdns->otg_v0_regs->simulate) & BIT(0)))
>>  			return true;
>>  	} else {
>> -		if (!(readl(&cdns->otg_v0_regs->simulate) & BIT(0)))
>> +		if (!(readl(&cdns->otg_v1_regs->simulate) & BIT(0)))
>>  			return true;
>>  	}
>>  	return false;
>> --
>
>Pawel, may this lead cdns driver segment fault?
>

Yes, we can observe such situation for CDNSP driver on simulation.=20
As you know, it is a common code and driver support two version  of registe=
r map for DRD.

If cdns->version  =3D=3D CDNSP_CONTROLLER_V2 (for CNDSP) the cdns->otg_v0_r=
egs is NULL.
It will cause segmentation fault.=20

I didn't analyze why this issue was not observed on my FPGA testing board.

Regards,

Pawel Laszczak =20