Date:   Wed, 12 Jan 2022 14:46:05 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     kuba@kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org,
        lipeng321@huawei.com, liuyonglong@huawei.com, mbrugger@suse.com,
        netdev@vger.kernel.org, salil.mehta@huawei.com,
        shenyang39@huawei.com, yisen.zhuang@huawei.com
Subject: Re: [PATCH v2] net: hns: Fix missing put_device() call in
 hns_mac_register_phy
Message-ID: <Yd7bnS/jPQgRPD88@lunn.ch>
References: <20220111203333.507ec4f5@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
 <20220112103919.28894-1-linmq006@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220112103919.28894-1-linmq006@gmail.com>
Precedence: bulk

On Wed, Jan 12, 2022 at 10:39:19AM +0000, Miaoqian Lin wrote:
> We need to drop the reference taken by hns_dsaf_find_platform_device
> Missing put_device() may cause refcount leak.

Is the put also missing on driver unload?

As a fix for net, it might be better to rename
dsaf_find_platform_device() to dsaf_get_platform_device() and add a
dsaf_put_platform_device(). Add similar undo functions where ever
needed, and make sure they get called.

	Andrew