Date:   Wed, 12 Jan 2022 08:26:32 -0600
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     kys@microsoft.com, sunilmut@microsoft.com, haiyangz@microsoft.com,
        sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
        lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com,
        bhelgaas@google.com, mikelley@microsoft.com, maz@kernel.org,
        linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next v2] PCI: hv: Fix an ignored error return from
 bitmap_find_free_region()
Message-ID: <20220112142632.GA252208@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220112003324.62755-1-yang.lee@linux.alibaba.com>
Precedence: bulk

On Wed, Jan 12, 2022 at 08:33:24AM +0800, Yang Li wrote:
> An error return from bitmap_find_free_region() is currently ignored 
> and we instead return a completely bogus *hwirq from 
> hv_pci_vec_alloc_device_irq().
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: c10bdb758ca4 ("PCI: hv: Add arm64 Hyper-V vPCI support")
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Thanks, I squashed this into c10bdb758ca4.

> ---
> 
> Change in v2:
> --According to Bjorn's suggestion, the corresponding changes were made.
>   https://lore.kernel.org/lkml/20220111155412.GA142851@bhelgaas/
> 
>  drivers/pci/controller/pci-hyperv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index 26c9c8ec0989..20ea2ee330b8 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -701,7 +701,7 @@ static int hv_pci_vec_alloc_device_irq(struct irq_domain *domain,
>  				       irq_hw_number_t *hwirq)
>  {
>  	struct hv_pci_chip_data *chip_data = domain->host_data;
> -	unsigned int index;
> +	int index;
>  
>  	/* Find and allocate region from the SPI bitmap */
>  	mutex_lock(&chip_data->map_lock);
> -- 
> 2.20.1.7.g153144c
>