Return-Path: <linux-kernel-owner+w=401wt.eu-S1423197AbXBBIai@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1423197AbXBBIai (ORCPT <rfc822;w@1wt.eu>);
	Fri, 2 Feb 2007 03:30:38 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423198AbXBBIah
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 2 Feb 2007 03:30:37 -0500
Received: from e4.ny.us.ibm.com ([32.97.182.144]:52620 "EHLO e4.ny.us.ibm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1423197AbXBBIag (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 2 Feb 2007 03:30:36 -0500
Date: Fri, 2 Feb 2007 14:00:27 +0530
From: Vivek Goyal <vgoyal@in.ibm.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] __crc_... is intended to be absolute
Message-ID: <20070202083027.GD6353@in.ibm.com>
Reply-To: vgoyal@in.ibm.com
References: <E1HCcMR-0007OE-VW@ZenIV.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1HCcMR-0007OE-VW@ZenIV.linux.org.uk>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1671
Lines: 43

On Thu, Feb 01, 2007 at 01:52:23PM +0000, Al Viro wrote:
> 
> i386 boot/compressed/relocs checks for absolute symbols and warns about
> unexpected ones.  If you build with modversions, you get ~2500 warnings
> about __crc_<symbol>.  These suckers are really absolute symbols - we
> do _not_ want to modify them on relocation.
> 
> They are generated by genksyms - EXPORT_... generates a weak alias, then
> genksyms produces an ld script with __crc_<symbol> = <checksum> and it's
> fed to ld to produce the final object file.  Their only use is to match
> kernel and module at modprobe time; they _must_ be absolute.
> 
> boot/compressed/relocs has a whitelist of known absolute symbols, but
> it doesn't know about __crc_... stuff.  As the result, we get shitloads
> of false positives on any ld(1) version.
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
>  arch/i386/boot/compressed/relocs.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/i386/boot/compressed/relocs.c b/arch/i386/boot/compressed/relocs.c
> index 468da89..881951c 100644
> --- a/arch/i386/boot/compressed/relocs.c
> +++ b/arch/i386/boot/compressed/relocs.c
> @@ -43,6 +43,8 @@ static int is_safe_abs_reloc(const char* sym_name)
>  			/* Match found */
>  			return 1;
>  	}
> +	if (strncmp(sym_name, "__crc_", 6) == 0)
> +		return 1;
>  	return 0;
>  }

Thanks Viro. Sorry, I missed this case.

Thanks
Vivek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/