Message-ID: <881ba4aa-2dc6-b116-869f-0fa2ecfe326b@gmail.com>
Date:   Wed, 12 Jan 2022 11:28:48 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH -next v2] scsi: efct: don't use GFP_KERNEL under spin lock
Content-Language: en-US
To:     Yang Yingliang <yangyingliang@huawei.com>,
        linux-kernel@vger.kernel.org, target-devel@vger.kernel.org,
        linux-scsi@vger.kernel.org
Cc:     hch@lst.de, james.smart@broadcom.com, martin.petersen@oracle.com
References: <20220111012441.3232527-1-yangyingliang@huawei.com>
From:   James Smart <jsmart2021@gmail.com>
In-Reply-To: <20220111012441.3232527-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/10/2022 5:24 PM, Yang Yingliang wrote:
> GFP_KERNEL/GFP_DMA can't be used under a spin lock, according the
> comment of els_ios_lock, it's used to protect els ios list, so we
> can move down the spin lock to avoid using this flag under the lock.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 8f406ef72859 ("scsi: elx: libefc: Extended link Service I/O handling")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> v2:
>    move up unlock to just protect list_add_tail()
> ---
>   drivers/scsi/elx/libefc/efc_els.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 

Looks fine.

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james