Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422837AbXBBLxF (ORCPT ); Fri, 2 Feb 2007 06:53:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422892AbXBBLxF (ORCPT ); Fri, 2 Feb 2007 06:53:05 -0500 Received: from nf-out-0910.google.com ([64.233.182.190]:36789 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422837AbXBBLxC (ORCPT ); Fri, 2 Feb 2007 06:53:02 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=gQ25Na7gGqwx+hJ0DQO0jL/VQn5Rjdjxzuu8M0pOjMdLJUP6/aEZcYsgNBPhejqXhSI6Hkh44ETy8aIbnPDGlexopRmHa0Z2rJUygIbWKu8B0hiQCNvkz1vOePC3lOqnMnwXS0dasVxl3JSVJPnWuj6oGtPo0S3u0qNgNRqm4y0= Message-ID: Date: Fri, 2 Feb 2007 20:53:00 +0900 From: "Magnus Damm" To: "Andrew Morton" Subject: Re: [PATCH] kexec: Fix CONFIG_SMP=n compilation (ia64) Cc: "Magnus Damm" , linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, "Luck, Tony" , fastboot@lists.osdl.org, nanhai.zou@intel.com In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070201131347.3807.87075.sendpatchset@localhost> <20070201163320.eb4fa2c7.akpm@osdl.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1578 Lines: 46 On 2/2/07, Magnus Damm wrote: > On 2/2/07, Andrew Morton wrote: > > Magnus Damm wrote: > > > > > kexec: Fix CONFIG_SMP=n compilation (ia64) > > > > > > This patch makes it possible to compile kexec for ia64 without SMP support. > > > --- 0002/arch/ia64/kernel/machine_kexec.c > > > +++ work/arch/ia64/kernel/machine_kexec.c 2007-02-01 12:35:46.000000000 +0900 > > > @@ -70,12 +70,14 @@ void machine_kexec_cleanup(struct kimage > > > > > > void machine_shutdown(void) > > > { > > > +#ifdef CONFIG_SMP > > > int cpu; > > > > > > for_each_online_cpu(cpu) { > > > if (cpu != smp_processor_id()) > > > cpu_down(cpu); > > > } > > > +#endif > > > kexec_disable_iosapic(); > > > } > > > > hm. I suspect this one should have been #ifndef CONFIG_HOTPLUG_CPU? Re-reading this I assume you mean #ifdef CONFIG_HOTPLUG_CPU. I would be happy to resend a new updated version of the patch, but I wonder if it may be better to fail miserably during the build than fail silently in the case of CONFIG_SMP=y but CONFIG_HOTPLUG_CPU=n. Any ideas? Nan hai, is there any particular reason why the ia64 kexec code builds on top of cpu hotplug instead of smp functions such as smp_send_stop()? Thanks! / magnus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/