From:   Robert Hancock <robert.hancock@calian.com>
To:     linux-kernel@vger.kernel.org
Cc:     giometti@enneenne.com, gregkh@linuxfoundation.org,
        andriy.shevchenko@linux.intel.com, rasm@fe.up.pt,
        jamesnuss@nanometrics.ca, akpm@linux-foundation.org,
        Robert Hancock <robert.hancock@calian.com>
Subject: [PATCH] pps: clients: gpio: Propagate return value from pps_gpio_probe
Date:   Wed, 12 Jan 2022 14:52:14 -0600
Message-Id: <20220112205214.2060954-1-robert.hancock@calian.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QNxREGgbyKtMDlkJ3GyT5pmCJVbyTN1kVFtdYqDjJkqmRiHc5YjroEIYJ28A?=
 =?us-ascii?Q?uzVC3jIU3JXAfU1bCF+A8GIgMOfhIHu0uGfkleBBAKpcjPXoQITvh74CeaaI?=
 =?us-ascii?Q?nqn3IT1a3uRqxNVBrZcXLhxsC6XKG6LS05XHOWdYC9LDk9f7d3x1cwhL9wjZ?=
 =?us-ascii?Q?2GMV9jW4ZLQ9r950TtITD25Vyvk4gHztudecMJ1WmncN4pSVOlTfvInClJaw?=
 =?us-ascii?Q?GOK7uLpprz8PqjPEwbHbcgZy9vFHv1yhQp8qYAi0uR4YrQPLs/M9G13eHjk0?=
 =?us-ascii?Q?DZajFMbA3whPmqzcX5oDZUHN3y6FQFFAx4CdfjLvEGHF+oGxcFv8T+AGJXqk?=
 =?us-ascii?Q?5kc20DSuUku2tLnfXaaPVqJZAXjAkesGbEU+bPy48DyteclhWKwfSx//inYG?=
 =?us-ascii?Q?8ucry+Ukj6CnggdhfDEyN9nrrq17kDPaYaPPTnIjxTbj4RC2FIEEgkvHeYRJ?=
 =?us-ascii?Q?B52fHYemobcK0Zae/n/tuNMS17kWcXgCjdkbKzbwALms2tZ+RhAuHUJv5Gzv?=
 =?us-ascii?Q?YAuZPtp9HaBqsw/hvFF0pwznB6eNRZq6rRfA8pLFGlkIuH4w3EnRKNirNRcq?=
 =?us-ascii?Q?klYfuvwK7a2OoUONxTZoYDyTlG0QK5YtmrVRweXkqvlejht6onNSTHlJo+CA?=
 =?us-ascii?Q?vTHY9xTydKf9R/HpyNXwUo5Rl9+aP6y/gb9rAUqAjBtW5oSu3cr6xmY8rj7b?=
 =?us-ascii?Q?CVA0qrLrWNTS7z/Pk0AL70nqlav9UPjOGSiPlOpaBiBx5nhJHeJOB79Z7BcY?=
 =?us-ascii?Q?NyQvhkuecz3qHarLLksDSTs66WOL4jeLThxtKnp6rMXfN3FMfYVjE/tMllwe?=
 =?us-ascii?Q?rWmYbbcjBMT6xbAHkBx+meW6FyszFs2nnJWvnzndx5y3VPFHJaaIA8nIPpgt?=
 =?us-ascii?Q?c4KnK9xv8wn6QMZB7t//0PVZk8IEm6Xh7y9MpL9hSLrUm68IgD46A0Wa2zgp?=
 =?us-ascii?Q?qUWggeTEFuRs5bJSSU0FZyfbDDcG25h4UHVOMD1/onE2U2TRaAnljqXj/S9o?=
 =?us-ascii?Q?FmDAfHkTBVkSrFvEuntO0/kYwD0vOQa6JncZVpKy0yKKNn8hQX9Acoh1seXx?=
 =?us-ascii?Q?J8DGT7rmAr6f+/UfUB8PsFB/TltsAo+ExnS0Te3B5Y6N+uGMqrgW9ydZB8fT?=
 =?us-ascii?Q?v+e/NQyOFOllViV+YmJJwL9/KKi8hEUj6O+rAvc9DKAueNXCNFVC1X9/qcxv?=
 =?us-ascii?Q?pzpi0qmTc9WCty+8AcKVfqneft5ao4drKTJ+m3/WHePmiQvxPFwyPJZPcHbI?=
 =?us-ascii?Q?DyXsF0ivH6dQ/xXIgUpeudqwjdG0WWvGzvG8ooAHw6opbMAotLdC2cnKR5JY?=
 =?us-ascii?Q?WcLG3t93WFKfE3aHNkrbj+jFBRsyf7m3zUuvF1ZkaWuXjpLBT83LROMBOHUG?=
 =?us-ascii?Q?F/Dcu5Cw0fR2eJreDeV06y4q9qRXtRUig+9+GDd5T3uyDI0rHmFVBN+wjc2O?=
 =?us-ascii?Q?38jFK5qLxVgc/2MNpfTjlXPosNmRlt1SMbMbG3futNtWpAklNsBApSpr3GfD?=
 =?us-ascii?Q?7aVkABytwQb756WyLj5u4PEoMm8Az63GD+7yJb4Ox9iaptFr8RsayX6xktGx?=
 =?us-ascii?Q?c3FwEPHmZazyBD3U67M86dY7oi8mcvyazCjmEnIPz8Dl77WUXuQtCOTAH0aU?=
 =?us-ascii?Q?vkAYWPXTGGMXXu6MUQ5JlyUmvTuTtBhfWi7Dz+2ZwOmG46Wu494tG0WWcO21?=
 =?us-ascii?Q?Bq0TduBEkQrhPLgSYW96HWXEYSY=3D?=
X-OriginatorOrg: calian.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa63faf4-6ed1-42ca-0235-08d9d60db706
X-MS-Exchange-CrossTenant-AuthSource: YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2022 20:54:24.4897
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +LE1fr2bhoYnZFawyTBg9BSZECPpm8U52r6AROVSA1F1OT4eA3YIX02ki6GYXjqIJzgHhlTjFMo3vmcCTnN4il4h+mxK29WtDwooW6lml20=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB5666
X-Proofpoint-GUID: 6FUS1j35rN5uxVJ_p8xZFB9r9d1l7WTK
X-Proofpoint-ORIG-GUID: 6FUS1j35rN5uxVJ_p8xZFB9r9d1l7WTK
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-12_05,2022-01-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0
 malwarescore=0 bulkscore=0 priorityscore=1501 mlxlogscore=801
 lowpriorityscore=0 spamscore=0 phishscore=0 adultscore=0 suspectscore=0
 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201120123
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

If the pps-gpio driver was probed prior to the GPIO device it uses, the
devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe
replaced that error code with -EINVAL, causing the pps-gpio probe to
fail and not be retried later. Propagate the error return value so that
deferred probe works properly.

Fixes: 161520451dfa (pps: new client driver using GPIO)
Signed-off-by: Robert Hancock <robert.hancock@calian.com>
---
 drivers/pps/clients/pps-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
index 35799e6401c9..2f4b11b4dfcd 100644
--- a/drivers/pps/clients/pps-gpio.c
+++ b/drivers/pps/clients/pps-gpio.c
@@ -169,7 +169,7 @@ static int pps_gpio_probe(struct platform_device *pdev)
 	/* GPIO setup */
 	ret = pps_gpio_setup(dev);
 	if (ret)
-		return -EINVAL;
+		return ret;
 
 	/* IRQ setup */
 	ret = gpiod_to_irq(data->gpio_pin);
-- 
2.31.1