From:   Oleksandr Natalenko <oleksandr@natalenko.name>
To:     Eugene Shalygin <eugene.shalygin@gmail.com>
Cc:     andy.shevchenko@gmail.com, pauk.denis@gmail.com,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v5 3/3] hwmon: deprecate asis_wmi_ec_sensors driver
Date:   Wed, 12 Jan 2022 22:51:35 +0100
Message-ID: <2224186.ElGaqSPkdT@natalenko.name>
In-Reply-To: <20220111180347.1245774-4-eugene.shalygin@gmail.com>
References: <20220111180347.1245774-1-eugene.shalygin@gmail.com> <20220111180347.1245774-4-eugene.shalygin@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Hello.

On =FAter=FD 11. ledna 2022 19:03:46 CET Eugene Shalygin wrote:
> ---
>  drivers/hwmon/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 2c16b19d2c03..5e693c93d43a 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -2243,13 +2243,16 @@ config SENSORS_ASUS_WMI
> =20
>  config SENSORS_ASUS_WMI_EC
>  	tristate "ASUS WMI B550/X570"
> -	depends on ACPI_WMI
> +	depends on ACPI_WMI && !SENSORS_ASUS_EC

Not sure how it handles `SENSORS_ASUS_EC=3Dm`. Probably, it should be:

```
depends on ACPI_WMI && SENSORS_ASUS_EC=3Dn
```

?

>  	help
>  	  If you say yes here you get support for the ACPI embedded controller
>  	  hardware monitoring interface found in B550/X570 ASUS motherboards.
>  	  This driver will provide readings of fans, voltages and temperatures
>  	  through the system firmware.
> =20
> +	  This driver is deprecated in favor of the ASUS EC Sensors driver
> +	  which provides fully compatible output.
> +
>  	  This driver can also be built as a module. If so, the module
>  	  will be called asus_wmi_sensors_ec.

Thanks.

=2D-=20
Oleksandr Natalenko (post-factum)