IronPort-SDR: XWz6La2x8d/oycKi+OxF89V5+VNkhYydPiDqr/F3sCG2o4oNQg2ODmkmHRre7YT8W3DQxCmH6m
 uHRCKdEZ+YKPCcq3F0enfz/6rnOeqY2t2agvq+6BCUa+E0dwnEy6Iejg5K+pjMm66Zrg0JxVhL
 PJpgh270aYI6Z/p5+uP/EIQ4eovOju8b13WQPOQAPyIMqjZ8jLJFoBWA7hw1HQToc+1qcgb/wK
 sS21kIYDiJTboL4TOTa5Dtx0sUfp1R3KTxRHOqb4i2otU2cGiAK1snt4/2IoYYfjguZqLsEpvK
 6+aHVbEfSBgHXOXPuEc3BQ7Y
IronPort-SDR: uu3+l7jl+3XLLDNHYe2Tk7y7Mam4u2PcYaUUBlm9AaFGcJsqClgbbLGrgiMKvHsQKcMNcG++sB
 UpGF7bG36Jq9lZNdtGvLp/hlecL+Ebq6SLK7jRCFh8LVk5y8eIhYRJXBMb0V3oLUBiw5xc/HFW
 WxAJj5ah8XqUupK1jk/GaXkkL7RvDcUGJ3Qw+BaTAn+xkvmErbjCzCy1npOX3UkfmTsKeFXBfw
 L5nJRvNyPDWequALyMNCWy11w59FwyYb0wXlCszj0zvZaII47hmCFYpm/tj/HRJzM15jY6IS7k
 h38=
WDCIronportException: Internal
Message-ID: <ec4d9eb0-3999-db52-1eec-bc6351dd4f07@opensource.wdc.com>
Date:   Thu, 13 Jan 2022 08:47:37 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH][RESEND] sata_fsl: Use struct_group() for memcpy() region
Content-Language: en-US
To:     Kees Cook <keescook@chromium.org>, Jens Axboe <axboe@kernel.dk>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
References: <20220112220652.3952944-1-keescook@chromium.org>
 <df3eefdc-d8d1-48fa-f5f7-9c2f2382842b@kernel.dk>
 <202201121515.8679164D6@keescook>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <202201121515.8679164D6@keescook>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/13/22 08:15, Kees Cook wrote:
> On Wed, Jan 12, 2022 at 03:23:40PM -0700, Jens Axboe wrote:
>> On 1/12/22 3:06 PM, Kees Cook wrote:
>>> In preparation for FORTIFY_SOURCE performing compile-time and run-time
>>> field bounds checking for memcpy(), memmove(), and memset(), avoid
>>> intentionally writing across neighboring fields.
>>>
>>> Use struct_group() in struct command_desc around members acmd and fill,
>>> so they can be referenced together. This will allow memset(), memcpy(),
>>> and sizeof() to more easily reason about sizes, improve readability,
>>> and avoid future warnings about writing beyond the end of acmd:
>>>
>>> In function 'fortify_memset_chk',
>>>     inlined from 'sata_fsl_qc_prep' at drivers/ata/sata_fsl.c:534:3:
>>> ./include/linux/fortify-string.h:199:4: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wattribute-warning]
>>>   199 |    __write_overflow_field();
>>>       |    ^~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Cc: Jens Axboe <axboe@kernel.dk>
>>> Cc: linux-ide@vger.kernel.org
>>> Signed-off-by: Kees Cook <keescook@chromium.org>
>>> ---
>>> Jens, can you take (or Ack) this? It's a dependency for the FORTIFY_SOURCE
>>> improvements that are close to being finished. :)
>>
>> I don't maintain libata anymore, so Damien is the guy to nudge ;-)
> 
> Ah-ha, okay, thanks.
> 
> /me waves "hi" to Damien. :)

Hi Kees,

This is already queued up in libata tree for-5.17 branch. I have not
sent my PR to Linus yet as I am letting things soack a little longer in
for-next (for the various arch compile tests).

Please check that branch to see if all is OK !

Cheers.


-- 
Damien Le Moal
Western Digital Research