Subject: Re: [PATCH v2] selftests: rtc: Increase test timeout so that all
 tests run
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= 
        <nfraprado@collabora.com>
Cc:     Shuah Khan <shuah@kernel.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        linux-rtc@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20220112194142.3276385-1-nfraprado@collabora.com>
 <Yd84cDlW9+f7wQxq@piout.net>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <f286a86d-6371-d8bd-6ca9-5f622468d1a4@linuxfoundation.org>
Date:   Wed, 12 Jan 2022 16:51:12 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <Yd84cDlW9+f7wQxq@piout.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 1/12/22 1:22 PM, Alexandre Belloni wrote:
> On 12/01/2022 14:41:42-0500, Nícolas F. R. A. Prado wrote:
>> The timeout setting for the rtc kselftest is currently 90 seconds. This
>> setting is used by the kselftest runner to stop running a test if it
>> takes longer than the assigned value.
>>
>> However, two of the test cases inside rtc set alarms. These alarms are
>> set to the next beginning of the minute, so each of these test cases may
>> take up to, in the worst case, 60 seconds.
>>
>> In order to allow for all test cases in rtc to run, even in the worst
>> case, when using the kselftest runner, the timeout value should be
>> increased to at least 120. Set it to 180, so there's some additional
>> slack.
>>
>> Correct operation can be tested by running the following command right
>> after the start of a minute (low second count), and checking that all
>> test cases run:
>>
>> 	./run_kselftest.sh -c rtc
>>
>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

Thank you both. Will apply this for 5.17-rc2 once the merge window
closes.

thanks,
-- Shuah