IronPort-SDR: 6lt5yPxEOJ7/oHgmOTYT+0JF+uYVSRxA0Dm+I8Se1QVBdAcXoPTmY1NmLJIrsHlO+6Wj6YNaWR
 6txn/7Im+77uB6qzkKf04PXosGx/YxyZkCE9XJnHLaGhR7iLCFUUg5mEChBuH/xiT87PxQc4FY
 LGbqnoYaux2EmXRDgy/5CMeQIsvQxHhwfHfw1FU7Nry3l70D43LfDpgOB/0jLoBJNIJaJ4Flhd
 cPiljfW1QAU7Hvgd9mseLbSDlzm+Njb+eFoZfa/ZUHqmO6ZoRI+8QXD9H22O3IgRCkjg9fEya1
 Pe9FW2N3Ln61CoSMnEk3E80r
IronPort-SDR: dlyRj6DiEA4sY7W2p07kZ4yGQU6ACO9OMQlnAcxqgNlPyRg8yQ2b0t5T7Zc4jaQokOp1CkLPDT
 iu8w3W4JWx/t97HdzRbkBX6xYGt7CuCqE5EgEw0e9U8EifP3T2kqvllreSYHAzSPILFZf+r7SF
 XV9K5KfcnW1wpJkIPbQN4S5F3WQSnIlU7sGXXB2w8DpF+XaCD0R5yi+9O1lfyik0dQJAzQZZgW
 /UqXKn2e7smK7TZAaodXLfG8HXy1sDhA2t2EWbZRG4SO+8az0lq2wIqMZxbA2rBgrqNGF4ByWU
 +lU=
WDCIronportException: Internal
Message-ID: <2d9b4f08-967e-6040-a954-e7bfa7e4dce1@opensource.wdc.com>
Date:   Thu, 13 Jan 2022 08:52:09 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] ata: pata_ali: remove redundant return statement
Content-Language: en-US
To:     Colin Ian King <colin.i.king@gmail.com>, linux-ide@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220112234741.1232858-1-colin.i.king@gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220112234741.1232858-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/13/22 08:47, Colin Ian King wrote:
> A return statement is unnecessarily complicated, currently value
> in variable mask is bitwise-masked and the variable is being
> updated and then returned. Just updating the mask is all that is
> required as the following statement is a return.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/ata/pata_ali.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
> index ab28a6707b94..1b90cda27246 100644
> --- a/drivers/ata/pata_ali.c
> +++ b/drivers/ata/pata_ali.c
> @@ -123,7 +123,7 @@ static unsigned long ali_20_filter(struct ata_device *adev, unsigned long mask)
>  		mask &= ~(ATA_MASK_MWDMA | ATA_MASK_UDMA);
>  	ata_id_c_string(adev->id, model_num, ATA_ID_PROD, sizeof(model_num));
>  	if (strstr(model_num, "WDC"))
> -		return mask &= ~ATA_MASK_UDMA;

Yeah, not to mention that is really ugly as the return should really
have been:

return mask & ~ATA_MASK_UDMA;

> +		mask &= ~ATA_MASK_UDMA;
>  	return mask;
>  }
>  

Will queue this up.

-- 
Damien Le Moal
Western Digital Research