Date:   Thu, 13 Jan 2022 10:39:34 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc:     Linux ACPI <linux-acpi@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Steven Noonan <steven@valvesoftware.com>
Subject: Re: [PATCH v1 2/2] ACPI: CPPC: Drop redundant local variable from
 cpc_read()
Message-ID: <Yd+Q5htH5dit/gIX@amd.com>
References: <11905930.O9o76ZdvQC@kreacher>
 <4374346.LvFx2qVVIh@kreacher>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4374346.LvFx2qVVIh@kreacher>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o9ObKt9mNFg0pKd3ryd6TsZcoqxBqyoe3rnwpFuUy4jD1IS2dBZGSEbRbtT+?=
 =?us-ascii?Q?c59tqaWtL+fVZi6xfwRDNGPzqhKXyxXZwmIcjhxOLTfmq9bUTbBV83jlHOeq?=
 =?us-ascii?Q?4W1ToOYcrvi6If1/d8FPwDfIuHKqfkcv4JSwd6DL8q8fT+jTGCLyWzQ3g93q?=
 =?us-ascii?Q?iUQKMgqji05FcrRMRKbFjWRfMOICvE8/I9nukzQNsm7AjquW9lakctAs5XLk?=
 =?us-ascii?Q?FoK/IXUjLRRPGpLUfyojtH9UUxWwtuw7BKJDQkpoS+vCBEMYwdbbQLMqEAvh?=
 =?us-ascii?Q?Ze3QX7Mn1bqP68S2buvsS85aL6q1Zc38zOTubPPfsJ+dcHXQMTpKialnaUUr?=
 =?us-ascii?Q?CdoShWmH+AL125Gdsjf8eihrH7iEXBHWyxYpgzAiDPUKhndN9aVNSu/7Py1T?=
 =?us-ascii?Q?ssH1nnWqYsJRrFFR9K5aHSH5wQdhZ7E4oG94tShFkyKi7+6Ux5pClG6EQI1+?=
 =?us-ascii?Q?AbYxsGSOXi01/eWyz7ZtSOGNpQtUHP2SqfGXG5N6JRko6PwEueRi8gFLHclU?=
 =?us-ascii?Q?iR+S7VqPPagFNiP3EkHEpr05gDZqsr+b8qS4zvBp8qHczAbyN0xDLl9mZE9h?=
 =?us-ascii?Q?Lq+iiOftWHl/uD5SqpE+D02pmPGX/6n34Ba0XEhma86pn0jFBHZnQZZZaIfg?=
 =?us-ascii?Q?P0fh1gexSuUWtDBvzRy9EKUWpx4q0+K4z/04gl5relYwOXo8V7v7vkZzJuFO?=
 =?us-ascii?Q?WSOGcvw/KUGS1BSUnIMrdr5K2g5ls3RGu2xL9xX/dCKYUPBYFQxdMmgJ/XX3?=
 =?us-ascii?Q?o5c46xvM7YWYV5XZW2RIZ12HMKn6BsmIut67pBjPBuXDe06MTBC1B2cINZB/?=
 =?us-ascii?Q?RIKGNa4mgF2acpGrcXH0PlMnZ7jaqJuzPeitRLp8PBgG5PLfA++bq5+ureVh?=
 =?us-ascii?Q?wgpNytsEQMzvgKtO0Eiomot6MI8CkNTC5mmpMdBtKznkxBkUjLlmpouW7Eud?=
 =?us-ascii?Q?VOKO7OQbEkxzr5/tgtEUAYa9zSCrx8FDtV1N8MvrvKCKEOViRI9EqyUnBK6Y?=
 =?us-ascii?Q?xEpThFo40f2DoRsFsexIUiIxr/kjAByMoqEL+dnojiCm0FiFjnd+931rcEcl?=
 =?us-ascii?Q?J001DAD6XEjrJA2AcgZpo/86YAodavNbY7TA4PIK/lizv8hdes2xZaOqojgR?=
 =?us-ascii?Q?ZcCKCzczC5k7fNXVvqWyHdHCqW/ziE0dS+mQnPOgi0mm7C4/jYHtIWFe2NUp?=
 =?us-ascii?Q?HXN96Qp3KiTEO3cp0WYwy0sl4frS7c8xtgic0pDaviTpQiEZauuGMQGrKGR/?=
 =?us-ascii?Q?1hebx8VrPlqhJiBDKBw4NwdQ1C4+jlXFW2kSzXB0yIzyLKAC2Ir2goG6oqTX?=
 =?us-ascii?Q?I9JRhxyuuIX8qZhXjl6afmqJKZs5VDqbuMIOPCUNof2SQv5PbiR7r3o7CwcH?=
 =?us-ascii?Q?KOgc9A8XQVPxst0ysSDaX19tHZqTzNwm+tHa2m5xWzADMOeX6yr6zxuIK83v?=
 =?us-ascii?Q?hOGyx1JQAkisA3pv36Sn4UuI/Bu6rwljm0u5cotlZH4t/ZJhck4PZ3ze2zFO?=
 =?us-ascii?Q?CQF09dptjcQVlAEmkXnDYyysSyItm0UEWk97wvkHCidZn2E1FFsJT2DY0Qbf?=
 =?us-ascii?Q?QCzJi8rH109JzVCjxP+8jiUv4MOHABjZjKq27hZRUQeXmrwAXTmsH76Jd1ab?=
 =?us-ascii?Q?N7E2xfYpHLxGs+P5wlBVvSQ=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15e95a10-567d-4a7d-513f-08d9d63dfdc1
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 02:39:58.9852
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ndCmjzdXD+XrFGa3+oHKRzNA1RgWK0XpuPd8VFSet8g/QndzR2YW9ba3A1vq7UNO6Atrzt3Zi5sNJfnd+rdsww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4058
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 13, 2022 at 02:27:22AM +0800, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The ret_val local variable in cpc_read() is not necessary, so
> eliminate it.
> 
> No functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/acpi/cppc_acpi.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> Index: linux-pm/drivers/acpi/cppc_acpi.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/cppc_acpi.c
> +++ linux-pm/drivers/acpi/cppc_acpi.c
> @@ -915,14 +915,13 @@ int __weak cpc_write_ffh(int cpunum, str
>  
>  static int cpc_read(int cpu, struct cpc_register_resource *reg_res, u64 *val)
>  {
> -	int ret_val = 0;
>  	void __iomem *vaddr = NULL;
>  	int pcc_ss_id = per_cpu(cpu_pcc_subspace_idx, cpu);
>  	struct cpc_reg *reg = &reg_res->cpc_entry.reg;
>  
>  	if (reg_res->type == ACPI_TYPE_INTEGER) {
>  		*val = reg_res->cpc_entry.int_value;
> -		return ret_val;
> +		return 0;
>  	}
>  
>  	*val = 0;
> @@ -968,10 +967,10 @@ static int cpc_read(int cpu, struct cpc_
>  	default:
>  		pr_debug("Error: Cannot read %u bit width from PCC for ss: %d\n",
>  			 reg->bit_width, pcc_ss_id);
> -		ret_val = -EFAULT;
> +		return -EFAULT;
>  	}
>  
> -	return ret_val;
> +	return 0;
>  }
>  
>  static int cpc_write(int cpu, struct cpc_register_resource *reg_res, u64 val)
> 
> 
>