Sender: Guenter Roeck <groeck7@gmail.com>
To:     Oleksandr Natalenko <oleksandr@natalenko.name>,
        Eugene Shalygin <eugene.shalygin@gmail.com>
Cc:     andy.shevchenko@gmail.com, pauk.denis@gmail.com,
        Jean Delvare <jdelvare@suse.com>, linux-kernel@vger.kernel.org,
        linux-hwmon@vger.kernel.org
References: <20220111180347.1245774-1-eugene.shalygin@gmail.com>
 <20220111180347.1245774-4-eugene.shalygin@gmail.com>
 <2224186.ElGaqSPkdT@natalenko.name>
From:   Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v5 3/3] hwmon: deprecate asis_wmi_ec_sensors driver
Message-ID: <a95919c0-6a89-18bc-e8ba-2165414e096b@roeck-us.net>
Date:   Wed, 12 Jan 2022 18:51:47 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <2224186.ElGaqSPkdT@natalenko.name>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 1/12/22 1:51 PM, Oleksandr Natalenko wrote:
> Hello.
> 
> On úterý 11. ledna 2022 19:03:46 CET Eugene Shalygin wrote:
>> ---
>>   drivers/hwmon/Kconfig | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
>> index 2c16b19d2c03..5e693c93d43a 100644
>> --- a/drivers/hwmon/Kconfig
>> +++ b/drivers/hwmon/Kconfig
>> @@ -2243,13 +2243,16 @@ config SENSORS_ASUS_WMI
>>   
>>   config SENSORS_ASUS_WMI_EC
>>   	tristate "ASUS WMI B550/X570"
>> -	depends on ACPI_WMI
>> +	depends on ACPI_WMI && !SENSORS_ASUS_EC
> 
> Not sure how it handles `SENSORS_ASUS_EC=m`. Probably, it should be:
> 
> ```
> depends on ACPI_WMI && SENSORS_ASUS_EC=n
> ```
> 

Odd language, and good catch. If I understand correctly, the result
of !SENSORS_ASUS_EC is 'm' if SENSORS_ASUS_EC=m. So, yes, it looks
like this needs to be "ACPI_WMI && SENSORS_ASUS_EC=n".

Guenter

> ?
> 
>>   	help
>>   	  If you say yes here you get support for the ACPI embedded controller
>>   	  hardware monitoring interface found in B550/X570 ASUS motherboards.
>>   	  This driver will provide readings of fans, voltages and temperatures
>>   	  through the system firmware.
>>   
>> +	  This driver is deprecated in favor of the ASUS EC Sensors driver
>> +	  which provides fully compatible output.
>> +
>>   	  This driver can also be built as a module. If so, the module
>>   	  will be called asus_wmi_sensors_ec.
> 
> Thanks.
>