Date:   Thu, 13 Jan 2022 11:00:36 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc:     Linux ACPI <linux-acpi@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Steven Noonan <steven@valvesoftware.com>
Subject: Re: [PATCH v1 1/2] ACPI: CPPC: Fix up I/O port access in cpc_read()
Message-ID: <Yd+V1PyRnxg+jE6p@amd.com>
References: <11905930.O9o76ZdvQC@kreacher>
 <5789025.lOV4Wx5bFT@kreacher>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5789025.lOV4Wx5bFT@kreacher>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bqxOYRPP0SSpT6HinclcOECEz0rVRFs1m3vKWGBxzHiW2JsDamqVGhoSEp9b?=
 =?us-ascii?Q?uQ3LG/vVuQWUqBv0JcmoCRgDSu2W6yjMcOoiITxYeQ+xJht/+wCEde0ThmjD?=
 =?us-ascii?Q?IPwfK6nRcuQfeUjQc/DwqZruZtEk844QZ/gJ2/URUDZ8TMksX79eoI7lR/SD?=
 =?us-ascii?Q?u17ggJ6kV8THkKmCtR99n9/lvFNEZJmnzr4G8/BB6O4Wp1KejqLsiKtjios6?=
 =?us-ascii?Q?8mYbnrH++UDiEr87RU1MmNme3qk/iFBX+rfgxc/gXwFrFhAJmXH2BRQkmwOU?=
 =?us-ascii?Q?QWqjXKxgpmXmCrZBbl6GOYrGJMuJR0L7WmI+pSbMJ7DjHp1h0b1RG0//u5mG?=
 =?us-ascii?Q?hBv3T/y11rn4s8wWnNwT9WLmEKxpfnfKam2nxTbqg3spMzZf8qstmvsvQkcp?=
 =?us-ascii?Q?0nVpSqdwBf1+hN843ZerfpabhZ5kqnpIwNTSYTNvWxJBqnzo6HLgmT3Ii5v9?=
 =?us-ascii?Q?vytBrIvezRY9WtJ2i15tl/rXfNyPS/K8XgXkOWEeDbjLmVn4aWHALxSnayBL?=
 =?us-ascii?Q?VjoQhGIMr6YnxvKO5MaUXHVWMfXls6yyTZSRIfJEh8RMnPJCee9f3+O2c5IV?=
 =?us-ascii?Q?6Hhm/0BVOESERj7+0T2w1ah/BCHypSz9JlZ6vCV9GB66l+ZOsxzbZFm6Tk6R?=
 =?us-ascii?Q?gRJMgin7zYInHHf8vj8kjgBSh4l9dyhY5SKpYeGfGT9m6EQKNeX1Ub4T7Q4V?=
 =?us-ascii?Q?yBA60Ay6V5fwQMUkFKdCCaSyf5lt6Cgg4C/+xMSQX/TEueBWOb2jlESw3+MQ?=
 =?us-ascii?Q?sQPav/9XTJsv2LTy1Us+e33/zc3aqaoxFsTrc/n2QsgX2+/VHYrcfJv65jxp?=
 =?us-ascii?Q?wcmxPXG9qAYcQodRNTLWq4PvmQxmTxhIx1IdnIPJD5Ngoa4a7gPicRhRg6vj?=
 =?us-ascii?Q?MgQlFJ3NXSad9+ITt7pyhkE/qiqoi/XB2LxFb2/Zsqh3U2bX2TDcLua3zYoG?=
 =?us-ascii?Q?znpNXJV/HSv+sqfQs1EMD9Su2oLD0I3Svt6I0vZDBlMPOioZdIiq+hWlTKlJ?=
 =?us-ascii?Q?AQ6YHrEq3ULxNwZbE18oJDPXc5inS5tHaYFwDfNqsaQw2ddyUKYcnKFlQ6NY?=
 =?us-ascii?Q?kBRudUZ9L1VnW6E/yd+chvumP5gLyYhARqBs+r+9u0LRLFQBVD8BvEyrW3Nj?=
 =?us-ascii?Q?uIe2dudQ6+6J4+6lx4QkWBHXiix+pDXfdeOEtFeEcYynQxpukdQHNiwjgARQ?=
 =?us-ascii?Q?9hVehZIF92sM2Zx0fGcXXAYsYpWXjeZEmbtZFyTP8zlxbCudwd50Tb9xiw5l?=
 =?us-ascii?Q?mW0Y3zGgBjI7sGz6ROwTuSGwGVP5eCPZf7dHU2Tx8/mSbikI/fy/3QbTblfg?=
 =?us-ascii?Q?RO8Q4niP3G0nUjz4JHaFPqxRLqWN+eChiYS5/icnPB6L7562Oc3JejOT/yAK?=
 =?us-ascii?Q?fDyXQ+QiQUZEPms5fARTED76bvYqY96l66fPyVWxYVA3s0ijJnoAbIfpEQ9C?=
 =?us-ascii?Q?coJREdAdmKnVomQljODluNQLVSnipYgmY+9D6j5Ux/1nWxn7gU4Tw01J6adU?=
 =?us-ascii?Q?hHsUEomIzaw6SlrS3ayGhe4SVtgLl6AdL4LqW4Rs9TsB1oxg+vkY2ClbY6E8?=
 =?us-ascii?Q?9hIbiNDJVoNx+6LFZMn7dhqkztW2BVyP0dACyX1WfFoybADoMk3AQoxlpquj?=
 =?us-ascii?Q?XqmyAyxDFPSPQDSQZTmCABU=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae63c582-9da7-4bdf-a1cd-08d9d640ecb0
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 03:00:59.0010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qAQ0R9PvIRqCUtAUodXcSknkrgEeamEFPlUP5on/spNJ/LuLXGufmRIgkBjK5wtsGDZAi1/4SgkC+ePBfCVRbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2504
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 12, 2022 at 07:26:32PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The code as currently implemented does not work on big endian systems,
> so fix it up.
> 
> Fixes: a2c8f92bea5f ("ACPI: CPPC: Implement support for SystemIO registers")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> Link: https://lore.kernel.org/linux-acpi/20220111092928.GA24968@kili/
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/acpi/cppc_acpi.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Index: linux-pm/drivers/acpi/cppc_acpi.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/cppc_acpi.c
> +++ linux-pm/drivers/acpi/cppc_acpi.c
> @@ -929,16 +929,18 @@ static int cpc_read(int cpu, struct cpc_
>  
>  	if (reg->space_id == ACPI_ADR_SPACE_SYSTEM_IO) {
>  		u32 width = 8 << (reg->access_width - 1);
> +		u32 val_u32;
>  		acpi_status status;
>  
>  		status = acpi_os_read_port((acpi_io_address)reg->address,
> -					   (u32 *)val, width);
> +					   &val_u32, width);
>  		if (ACPI_FAILURE(status)) {
>  			pr_debug("Error: Failed to read SystemIO port %llx\n",
>  				 reg->address);
>  			return -EFAULT;
>  		}
>  
> +		*val = val_u32;
>  		return 0;
>  	} else if (reg->space_id == ACPI_ADR_SPACE_PLATFORM_COMM && pcc_ss_id >= 0)
>  		vaddr = GET_PCC_VADDR(reg->address, pcc_ss_id);
> 
> 
>