Reply-To: Gavin Shan <gshan@redhat.com>
Subject: Re: [PATCH v4 06/21] KVM: arm64: Support SDEI_EVENT_CONTEXT hypercall
To:     Shannon Zhao <shannon.zhaosl@gmail.com>,
        kvmarm@lists.cs.columbia.edu
Cc:     maz@kernel.org, linux-kernel@vger.kernel.org,
        Jonathan.Cameron@huawei.com, pbonzini@redhat.com, will@kernel.org
References: <20210815001352.81927-1-gshan@redhat.com>
 <20210815001352.81927-7-gshan@redhat.com>
 <40d818a2-0c91-e06e-6ce8-ac8123b8d1d4@gmail.com>
From:   Gavin Shan <gshan@redhat.com>
Message-ID: <798ecbb0-f369-f3e7-ad50-78acfd902d1d@redhat.com>
Date:   Thu, 13 Jan 2022 15:02:15 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.0
MIME-Version: 1.0
In-Reply-To: <40d818a2-0c91-e06e-6ce8-ac8123b8d1d4@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Shannon,

On 1/11/22 5:43 PM, Shannon Zhao wrote:
> On 2021/8/15 8:13, Gavin Shan wrote:
>> +static unsigned long kvm_sdei_hypercall_context(struct kvm_vcpu *vcpu)
>> +{
>> +    struct kvm *kvm = vcpu->kvm;
>> +    struct kvm_sdei_kvm *ksdei = kvm->arch.sdei;
>> +    struct kvm_sdei_vcpu *vsdei = vcpu->arch.sdei;
>> +    struct kvm_sdei_vcpu_regs *regs;
>> +    unsigned long index = smccc_get_arg1(vcpu);
>> +    unsigned long ret = SDEI_SUCCESS;
>> +
>> +    /* Sanity check */
>> +    if (!(ksdei && vsdei)) {
>> +        ret = SDEI_NOT_SUPPORTED;
>> +        goto out;
>> +    }
> Maybe we could move these common sanity check codes to kvm_sdei_hypercall to save some lines.
> 

Not all hypercalls need this check. For example, COMPLETE/COMPLETE_RESUME/CONTEXT don't
have SDEI event number as the argument. If we really want move this check into function
kvm_sdei_hypercall(), we would have code like below. Too much duplicated snippets will
be seen. I don't think it's better than what we have if I fully understand your comments.

       switch (...) {
       case REGISTER:
            if (!(ksdei && vsdei)) {
                ret = SDEI_NOT_SUPPORTED;
                break;
            }

            ret = kvm_sdei_hypercall_register(vcpu);
            break;
       case UNREGISTER:
            if (!(ksdei && vsdei)) {
                ret = SDEI_NOT_SUPPORTED;
                break;
            }

            ret = kvm_sdei_hypercall_unregister(vcpu);
            break;
      case CONTEXT:
            ret = kvm_sdei_hypercall_context(vcpu);
            break;
        :
     }

Thanks,
Gavin