Subject: Re: [PATCH] pps: clients: gpio: Propagate return value from
 pps_gpio_probe
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Robert Hancock <robert.hancock@calian.com>
Cc:     linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        rasm@fe.up.pt, jamesnuss@nanometrics.ca, akpm@linux-foundation.org
References: <20220112205214.2060954-1-robert.hancock@calian.com>
 <Yd9DDJ2HmptwIITA@smile.fi.intel.com>
From:   Rodolfo Giometti <giometti@enneenne.com>
Message-ID: <d21aeae0-f75d-f8b9-032a-f4751696d467@enneenne.com>
Date:   Thu, 13 Jan 2022 09:17:57 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <Yd9DDJ2HmptwIITA@smile.fi.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/01/22 22:07, Andy Shevchenko wrote:
> On Wed, Jan 12, 2022 at 02:52:14PM -0600, Robert Hancock wrote:
>> If the pps-gpio driver was probed prior to the GPIO device it uses, the
>> devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe
>> replaced that error code with -EINVAL, causing the pps-gpio probe to
>> fail and not be retried later. Propagate the error return value so that
>> deferred probe works properly.
> 
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Rodolfo Giometti <giometti@enneenne.com>
> 
>> Fixes: 161520451dfa (pps: new client driver using GPIO)
>> Signed-off-by: Robert Hancock <robert.hancock@calian.com>
>> ---
>>  drivers/pps/clients/pps-gpio.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
>> index 35799e6401c9..2f4b11b4dfcd 100644
>> --- a/drivers/pps/clients/pps-gpio.c
>> +++ b/drivers/pps/clients/pps-gpio.c
>> @@ -169,7 +169,7 @@ static int pps_gpio_probe(struct platform_device *pdev)
>>  	/* GPIO setup */
>>  	ret = pps_gpio_setup(dev);
>>  	if (ret)
>> -		return -EINVAL;
>> +		return ret;
>>  
>>  	/* IRQ setup */
>>  	ret = gpiod_to_irq(data->gpio_pin);
>> -- 
>> 2.31.1
>>
> 


-- 
GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti