MIME-Version: 1.0
References: <20220113073158.2171673-1-hsinyi@chromium.org> <2e676870-11f2-b5fa-faf1-d6633e801a5a@wanadoo.fr>
In-Reply-To: <2e676870-11f2-b5fa-faf1-d6633e801a5a@wanadoo.fr>
From:   Hsin-Yi Wang <hsinyi@chromium.org>
Date:   Thu, 13 Jan 2022 16:30:20 +0800
Message-ID: <CAJMQK-jZgw0Kw0ON8sY=+FFf_Z_Pys48DN+r+g6cCUqcw_7-8A@mail.gmail.com>
Subject: Re: [PATCH v2 1/3] drm/bridge: anx7625: Convert to use devm_kzalloc
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Robert Foss <robert.foss@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Xin Ji <xji@analogixsemi.com>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maxime Ripard <maxime@cerno.tech>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jan 13, 2022 at 4:04 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Le 13/01/2022 =C3=A0 08:31, Hsin-Yi Wang a =C3=A9crit :
> > Use devm_kzalloc instead of kzalloc and drop kfree(). Let the memory
> > handled by driver detach.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > Reviewed-by: Xin Ji <xji@analogixsemi.com>
> > ---
> >   drivers/gpu/drm/bridge/analogix/anx7625.c | 9 +++------
> >   1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/dr=
m/bridge/analogix/anx7625.c
> > index 0b858c78abe8b6..dbe708eb3bcf11 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -2515,7 +2515,7 @@ static int anx7625_i2c_probe(struct i2c_client *c=
lient,
> >               return -ENODEV;
> >       }
> >
> > -     platform =3D kzalloc(sizeof(*platform), GFP_KERNEL);
> > +     platform =3D devm_kzalloc(dev, sizeof(*platform), GFP_KERNEL);
> >       if (!platform) {
> >               DRM_DEV_ERROR(dev, "fail to allocate driver data\n");
> >               return -ENOMEM;
> > @@ -2527,7 +2527,7 @@ static int anx7625_i2c_probe(struct i2c_client *c=
lient,
> >       if (ret) {
> >               if (ret !=3D -EPROBE_DEFER)
> >                       DRM_DEV_ERROR(dev, "fail to parse DT : %d\n", ret=
);
> > -             goto free_platform;
> > +             return ret;
> >       }
> >
> >       platform->client =3D client;
> > @@ -2552,7 +2552,7 @@ static int anx7625_i2c_probe(struct i2c_client *c=
lient,
> >       if (!platform->hdcp_workqueue) {
> >               dev_err(dev, "fail to create work queue\n");
> >               ret =3D -ENOMEM;
> > -             goto free_platform;
> > +             return ret;
> >       }
> >
> >       platform->pdata.intp_irq =3D client->irq;
> > @@ -2637,9 +2637,6 @@ static int anx7625_i2c_probe(struct i2c_client *c=
lient,
> >       if (platform->hdcp_workqueue)
> >               destroy_workqueue(platform->hdcp_workqueue);
> >
> > -free_platform:
> > -     kfree(platform);
> > -
> >       return ret;
> >   }
> >
>
> Hi,
>
> you also need to update anx7625_i2c_remove() accordingly, otherwise you
> introduce a double free.
>
Hi,

Updated in v3.
> CJ
>
>