Date:   Thu, 13 Jan 2022 09:35:21 +0100
From:   Petr Mladek <pmladek@suse.com>
To:     jim.cromie@gmail.com
Cc:     Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        John Ogness <john.ogness@linutronix.de>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Chris Down <chris@chrisdown.name>,
        Marc Zyngier <maz@kernel.org>,
        Andrew Scull <ascull@google.com>,
        Will Deacon <will@kernel.org>, Jason Baron <jbaron@akamai.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Jessica Yu <jeyu@kernel.org>
Subject: Re: [RFC 1/2] printk/dynamic_debug: Remove cyclic dependency between
 printk.h and dynamic_debug.h
Message-ID: <Yd/kSVaFyn2/huaf@alley>
References: <20220111143046.14680-1-pmladek@suse.com>
 <20220111143046.14680-2-pmladek@suse.com>
 <996a7cf5-b047-5038-c86b-f10820364465@rasmusvillemoes.dk>
 <Yd7Fq6V1/Ynff6Qx@alley>
 <CAJfuBxzKZYBf_CGzHGjL_Jn2M=x_NH_j89kFX2UGxr8Sr4=fVw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJfuBxzKZYBf_CGzHGjL_Jn2M=x_NH_j89kFX2UGxr8Sr4=fVw@mail.gmail.com>
Precedence: bulk

On Wed 2022-01-12 20:38:57, jim.cromie@gmail.com wrote:
> On Wed, Jan 12, 2022 at 5:12 AM Petr Mladek <pmladek@suse.com> wrote:
> >
> > On Tue 2022-01-11 17:01:35, Rasmus Villemoes wrote:
> > > On 11/01/2022 15.30, Petr Mladek wrote:
> 
> 
> > > >  static inline int dynamic_debug_exec_queries(const char *query, const char *modname)
> > > >  {
> > > > -   pr_warn("kernel not built with CONFIG_DYNAMIC_DEBUG_CORE\n");
> > > > +   /* Use raw _printk() to avoid cyclic dependency. */
> > > > +   _printk(KERN_WARNING "kernel not built with CONFIG_DYNAMIC_DEBUG_CORE\n");
> > > >     return 0;
> > > >  }
> > >
> > > And for this one I think the solution is even simpler, as I can't find
> > > any in-tree callers. Perhaps just nuke it entirely?
> >
> > Adding Jim into Cc whether he still has any plans to use this API.
> >
> > Best Regards,
> > Petr
> 
> This EXPORT can go.

Does it mean that the entire function might be removed or just
EXPORT_SYMBOL_GPL() macro, please?

I am especially interested whether we could remove pr_warn()
from the header file. It would help us the get rid of the
cyclic header dependency an easy way.

Best Regards,
Petr