Message-ID: <be18b2bb-f334-1f31-50df-9935929281f6@xs4all.nl>
Date:   Thu, 13 Jan 2022 10:15:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.4.1
Subject: Re: [PATCH 0/3] Add 12bit and 14bit luma-only formats
Content-Language: en-US
To:     Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
        dave.stevenson@raspberrypi.com
References: <20220112161014.972076-1-jeanmichel.hautbois@ideasonboard.com>
From:   Hans Verkuil <hverkuil@xs4all.nl>
In-Reply-To: <20220112161014.972076-1-jeanmichel.hautbois@ideasonboard.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jean-Michel,

On 12/01/2022 17:10, Jean-Michel Hautbois wrote:
> Hello,
> 
> While working on adding the V4L2-PIX-FMT-Y12P and V4L2-PIX-FMT-Y14P
> formats, I noticed an issue in the way V4L2-PIX-FMT-Y10P is described.
> This series aims to solve it before adding Y12P and Y14P.
> 
> Those two formats are needed for the next-to-come bcm2835 unicam driver.
> 
> Jean-Michel Hautbois (3):
>   media: doc: pixfmt-yuv: Fix V4L2-PIX-FMT-Y10P format
>   media: v4l: Add V4L2-PIX-FMT-Y12P format
>   media: v4l: Add V4L2-PIX-FMT-Y14P format
> 
>  .../media/v4l/pixfmt-yuv-luma.rst             | 48 ++++++++++++++++++-
>  drivers/media/v4l2-core/v4l2-ioctl.c          |  2 +
>  include/uapi/linux/videodev2.h                |  2 +
>  3 files changed, 50 insertions(+), 2 deletions(-)
> 

I'll take the first patch, but it is better to add patches 2 and 3 to the unicam RFC
series. Adding pixelformats that are not used by any existing driver isn't a good idea
and I'd like to avoid that.

Regards,

	Hans