Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E279C433FE for ; Thu, 13 Jan 2022 12:14:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234410AbiAMMO1 (ORCPT ); Thu, 13 Jan 2022 07:14:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52362 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230310AbiAMMO0 (ORCPT ); Thu, 13 Jan 2022 07:14:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642076066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+0lIRoOhUZRcmverl2fS/N58QWJmAbrDo4GjOCnd6uY=; b=FnLpWe6YqOj0xlt1BTO7bzrlAKJySL7kJt7Cji8CaTp8exbknJYriigq+88/ArNLFsc2jm b4iNRJxfCDgtAV9B/biddxi3koT3goP80HiFQo1HCcpl//9RyFbVehMlKXwUGdX2ralXki oMoxGTI91WShClfreSZo52eNcJHLRvU= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-386-H6eRGF6BPMmKlZ0fx6-phg-1; Thu, 13 Jan 2022 07:14:25 -0500 X-MC-Unique: H6eRGF6BPMmKlZ0fx6-phg-1 Received: by mail-ed1-f69.google.com with SMTP id c8-20020a05640227c800b003fdc1684cdeso5188985ede.12 for ; Thu, 13 Jan 2022 04:14:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+0lIRoOhUZRcmverl2fS/N58QWJmAbrDo4GjOCnd6uY=; b=1pXWkePhGmA9VIo+Aq2Hk6K6nyTlPJ++DntQD4l+9/xGWRr4I+31605zCficwbwN5i cSjagwVtrdF51v8p+8HAPKxHqYftSCZ2D+sJo4n8gCVGyeKyjdYbNvJm1qWUwYWa+nCm OV0MHPCsKSySuE03iZvOw/JkAKXr3RrSediod+NKOKjbPlnT2fYDemEMZieYegKVREDR eW9q9KdaOTNwjNBwTJMrljWe2z/m29pEMCUyRvThezpaC35OEiS5JQEz8Dm46DG7pgTc PSbO14S6NChwpfb8n8mHoXNwtgnc0KKBe5RYttcZGmsoq8X/zquX0e5N8Qs9+53mCDph 09KQ== X-Gm-Message-State: AOAM533fAvk/0uCWif7wjnX9vn2qKl6NOmy6HDQ7I0T/Jg5KhQ/7r4IO 4DZTCu+Kdcm2DcTG7Ol2pyG+jpGXBuEZkKRYDjvk46HMQMw1PZUXkXQVmmoncYbOoDl37EPqou1 4QgRPy6uFNQzsBEPr7v5mUjeO X-Received: by 2002:a17:906:dc94:: with SMTP id cs20mr3224678ejc.316.1642076063775; Thu, 13 Jan 2022 04:14:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJxPQMF6TGaiElXpWlkkYzbwGgnKNg/CxUKtTPr6TZd994YwTxRDTgzO+5g21JW/xapJL8Xr3w== X-Received: by 2002:a17:906:dc94:: with SMTP id cs20mr3224656ejc.316.1642076063508; Thu, 13 Jan 2022 04:14:23 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id c9sm839546ejf.10.2022.01.13.04.14.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 04:14:22 -0800 (PST) Message-ID: Date: Thu, 13 Jan 2022 13:14:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: KVM: Warn if mark_page_dirty() is called without an active vCPU Content-Language: en-US To: Christian Borntraeger , dwmw2@infradead.org Cc: butterflyhuangxx@gmail.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, seanjc@google.com, Cornelia Huck , Janosch Frank , David Hildenbrand , linux-s390 , Thomas Huth , Claudio Imbrenda References: <20220113120609.736701-1-borntraeger@linux.ibm.com> From: Paolo Bonzini In-Reply-To: <20220113120609.736701-1-borntraeger@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/13/22 13:06, Christian Borntraeger wrote: > From: Christian Borntraeger > > Quick heads-up. > The new warnon triggers on s390. Here we write to the guest from an > irqfd worker. Since we do not use dirty_ring yet this might be an over-indication. > Still have to look into that. Yes, it's okay to add an #ifdef around the warning. Paolo