Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2367EC433EF for ; Thu, 13 Jan 2022 12:27:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231645AbiAMM1m (ORCPT ); Thu, 13 Jan 2022 07:27:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54608 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231301AbiAMM1j (ORCPT ); Thu, 13 Jan 2022 07:27:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642076859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ViQVHhS9TeU1GADrKolwOU4MxQRPJUjTMiV4znToNZg=; b=S61E3PMcSiNkDJkvPVCzceJ9qfyhEJ3C2wN/Xz/GedDMNaGaHDfquIyBgQXMkdL0rs8cFq 2qb53tWtXcxZuBkuXe5+9VTWyycoRiAvJ6p07PdHpIXvFjLyr4iGGfbMkAMet3UBZCnVXl a2gOjpm0nItJ+3FeJZ19ngUvXNuCu+A= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-298-UZZXdyusPF2Pbdi3Me8o6w-1; Thu, 13 Jan 2022 07:27:37 -0500 X-MC-Unique: UZZXdyusPF2Pbdi3Me8o6w-1 Received: by mail-ed1-f71.google.com with SMTP id h1-20020aa7cdc1000000b0040042dd2fe4so3926741edw.17 for ; Thu, 13 Jan 2022 04:27:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ViQVHhS9TeU1GADrKolwOU4MxQRPJUjTMiV4znToNZg=; b=Tiy5kHe7bcWlMZeurLNP2d0JbZUmlmqdN61+qe248Tp4yv8cD+xeS8AvnK+Hn4lshs qWk6eAMlqhpPQGmHAKiUY9ZanzVGux7sxG1ZHXLmclYEteXdMsIHxuJF3JA53TEP6Gjh XIpzTIo6m+nYCK8O/Rle/C4C7XviX8+4T+LNeil88BGaQmJtLpihOsES52O/DC2PfgUd eddNqXlEeiw7H0J6JFZ0XnUv+sofzgVR8zHlCGnmgGk3x8wlaW08aMEzViNbqbpPBBQB uqkqdC1Y1ZhBvu1hOTkIOzAii0xtC82+Mn1QPdG3HspInH8mMtW7eNG0qYlmlifKCgoa blmg== X-Gm-Message-State: AOAM531CB6Kij6plOKh9YhEOWNhMrrUMq6THjglmg8Axzq0BZd1Sx0aA 6fBb0NwVev91yB4ZwJqwFm1wZK35DkTUtlpm4WxzUSBJX/ax/o7BZoJxbo2cojfB+iW15H0L772 VPU2IZU35d2EKUPT8Go9cqKPM X-Received: by 2002:a17:906:da1b:: with SMTP id fi27mr3480783ejb.68.1642076856777; Thu, 13 Jan 2022 04:27:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJzzq8hitOmNz+ym3vvwJSFT3GdzZkSBYpwA288q5gf8tRuG+8tKBO7yzTkkVxcdxI0Vag+s+w== X-Received: by 2002:a17:906:da1b:: with SMTP id fi27mr3480767ejb.68.1642076856599; Thu, 13 Jan 2022 04:27:36 -0800 (PST) Received: from krava (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id qa35sm836380ejc.67.2022.01.13.04.27.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 04:27:36 -0800 (PST) Date: Thu, 13 Jan 2022 13:27:34 +0100 From: Jiri Olsa To: Masami Hiramatsu Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , netdev@vger.kernel.org, bpf@vger.kernel.org, lkml , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Steven Rostedt , "Naveen N . Rao" , Anil S Keshavamurthy , "David S . Miller" Subject: Re: [RFC PATCH v2 0/8] fprobe: Introduce fprobe function entry/exit probe Message-ID: References: <164199616622.1247129.783024987490980883.stgit@devnote2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 12, 2022 at 05:01:15PM +0100, Jiri Olsa wrote: > On Wed, Jan 12, 2022 at 11:02:46PM +0900, Masami Hiramatsu wrote: > > Hi Jiri and Alexei, > > > > Here is the 2nd version of fprobe. This version uses the > > ftrace_set_filter_ips() for reducing the registering overhead. > > Note that this also drops per-probe point private data, which > > is not used anyway. > > > > This introduces the fprobe, the function entry/exit probe with > > multiple probe point support. This also introduces the rethook > > for hooking function return as same as kretprobe does. This > > nice, I was going through the multi-user-graph support > and was wondering that this might be a better way > > > abstraction will help us to generalize the fgraph tracer, > > because we can just switch it from rethook in fprobe, depending > > on the kernel configuration. > > > > The patch [1/8] and [7/8] are from your series[1]. Other libbpf > > patches will not be affected by this change. > > I'll try the bpf selftests on top of this I'm getting crash and stall when running bpf selftests, the fprobe sample module works fine, I'll check on that jirka