Subject: Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation
To:     "Ruhl, Michael J" <michael.j.ruhl@intel.com>,
        "guangming.cao@mediatek.com" <guangming.cao@mediatek.com>,
        "sumit.semwal@linaro.org" <sumit.semwal@linaro.org>
Cc:     "jianjiao.zeng@mediatek.com" <jianjiao.zeng@mediatek.com>,
        "lmark@codeaurora.org" <lmark@codeaurora.org>,
        "wsd_upstream@mediatek.com" <wsd_upstream@mediatek.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "yf.wang@mediatek.com" <yf.wang@mediatek.com>,
        "linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "libo.kang@mediatek.com" <libo.kang@mediatek.com>,
        "benjamin.gaignard@linaro.org" <benjamin.gaignard@linaro.org>,
        "bo.song@mediatek.com" <bo.song@mediatek.com>,
        "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
        "labbott@redhat.com" <labbott@redhat.com>,
        "mingyuan.ma@mediatek.com" <mingyuan.ma@mediatek.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
References: <CAO_48GF=ttKqSOm9GRoA3Mq+-RQOtRjWp449XPcz-wH=kjaTjw@mail.gmail.com>
 <20220113123406.11520-1-guangming.cao@mediatek.com>
 <4f88205c1b344aea8608960e2f85b8f4@intel.com>
 <e657f5257cbf4955817b0bbf037de9f9@intel.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <24157767-dc29-bbdd-5428-d89ecc6b9606@amd.com>
Date:   Thu, 13 Jan 2022 14:05:24 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <e657f5257cbf4955817b0bbf037de9f9@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzhidnYweUg2dDR4aXJqRXJIek80K21NWldVNThRaFlXbGg0dEtFR2FyZUQv?=
 =?utf-8?B?ZFhlRmhkL2d6eUk3L3hZNXJoTi9pYVhjS1oySU9KMGtiYmN1MWVodTFOeVFW?=
 =?utf-8?B?RlhkVzNIYVlvT3lrdFlmUWx3d1BjSWxBYkdvNjNIdUtJczBlT1JFL0NYYVpt?=
 =?utf-8?B?RW9UdXYwTm1IQndoSS9hM1ZoV2NXYnhVSmtKczQ1ZjJZTlIveHZlZ1RuVzNy?=
 =?utf-8?B?MWxSNWZvUWoza0wrWWF3R0RSb2h3OW1DT1h4bUpNVWtkOEFDMlFwaHJDWDFt?=
 =?utf-8?B?eW4xaW1XOFM0NktIUWQycTdpamEza0o2QjNGeTdXbjBrN0lJZkJzLzNURjUr?=
 =?utf-8?B?emcxVCtNbmRJeFVocC9KN2tDajlRYjFqazlGcDIyL0JINUNZOVl1a2JqenhX?=
 =?utf-8?B?NDM0RnNlRXQzYWFGd2t0YVp3V0dwK3craHpjbWVab3dZNThBTTAwbWJRNlNa?=
 =?utf-8?B?MW5pQ3NVYnF0TFowbVRXMDM4dXdrbzdHb1h0dW9NSCtqcDM4UmdSdjRhTHVC?=
 =?utf-8?B?dVNlMVBlNG83eEViMkt3bGswdndhMW0zV0tXR210Tm1zMDBqOGc5SkVQU0VO?=
 =?utf-8?B?ck1EbjRQMFBjTTRLbzNQdElBcVRPcGpPRDh2dlEvNGJVQmtuZmRPYXl2MzZH?=
 =?utf-8?B?ajV5THdrSG42L1U2VzNMOHR6NEtLZ0JIWGowUVdMS1F6Q0hXRFpncGZycjBR?=
 =?utf-8?B?ZmFUTVM4N3EvaDRDUTdtMjBQaGlLR2cwdXdNSzlXeXM5YlBjRXBGTjdqM3NY?=
 =?utf-8?B?bk9KdkdQZGV5bGp1UHBCeldhRU1xbVRiUzNvY0pNTlJFUmE2amc2Y0NXQjlZ?=
 =?utf-8?B?QmtMQWY3MFYvak01MEptYThjdHp3dUw3c21HS3gwUVBzQy9jYWFIVFZpVExq?=
 =?utf-8?B?aWRmNXVrK3p1V2x0c2pYd2YvV3J3N3UzekZEcTJvQmUydE5BbFZXYjdsVlNh?=
 =?utf-8?B?UXkzcm11Q3g2MVZjSU9MalhHeEdWcUN6bjNyYkpFWEhhaFFoUzU2Nk90ai8r?=
 =?utf-8?B?aXJPakRNcE1LZktaTHBIY0p6UUZ1a3JaNDF3SlY3RnNKU0tmc0p3SjBlU01X?=
 =?utf-8?B?bDdTYmtRSllvTkhHY2hubERLM051Z0hhWHFZVWs2bzJkeTJsMHZ4KytPRjk3?=
 =?utf-8?B?cVR2Smtma3pCaTNmTzFySEVtT3U0T2NQWjhaU0xBT1J2VWtKRlVkcldJN1J5?=
 =?utf-8?B?K0d5MzNpMnBRUk9DS3JrZ1RCRzdSTGVLR3lZY2lpdDJLVlpNbnRwRHhyRUtT?=
 =?utf-8?B?b0NGT3liQVVyVXl0ZVl4Mm5UNU5rMXpZZlZkV2xaLzNHbTNNTzF4ZkVQdXNn?=
 =?utf-8?B?ZVVEU0VFaGhSd2pCdGZ2OEh3bVBmcjZaMjRwbkRIc1NpTGRQV1dHMjkrK2NF?=
 =?utf-8?B?MURxeUVyMFc4b1NpWWVudjdsUThBK0VJZlZ4VGgyOC9mQk9QQVJwL3J3dmtG?=
 =?utf-8?B?VWNBbWN4Rmg2aGtsYmlPaXh2bDl0T1QyQmg2anhNcUNaaDJ2QmJMUTlIMzZD?=
 =?utf-8?B?VGVqMjJOOEdsVWpVU0JoZGFmaEhkRHo5b3dKQ3ErRHgra2hPdmhpV01rcTJU?=
 =?utf-8?B?K1RwR3Y2aUR6cXQvM1lLaEhWRjFzVjZVZXRvaG5FME1aakZHUjNzVFh1N1Ri?=
 =?utf-8?B?cWdwSU1YQVpqYXdmemhjWE1MY01hUmJZeTliUHI0MlBDTmVCdkoxM2lFM0JP?=
 =?utf-8?B?M3pjUVhaM05HMTNUUkhHWGwzNnNsdFJCajNHcTAwMlRTeVRiS0FLRm9WYy9y?=
 =?utf-8?B?ME1CY25iRHUvQzBtYlVpak5WVjArYWJKTUVOdHMwWVNWNDlVSjVEcE9yUjRu?=
 =?utf-8?B?YTMwYytzT0w1dHBlR3dEaEdraHZTNnpjSUQveW5KakFDSGJKM05oREp6czQw?=
 =?utf-8?B?Y0dJK1ZCOFJlenkvR0hERzlScjRVR2dBR2FDUlR1RHdRMnZ0UFZTcmovMFZM?=
 =?utf-8?B?aXBtemh6MHMrNmFvRkJITjhBUzhRZkczTnFCWk01K2xTelphY3MyTVNzbUk1?=
 =?utf-8?B?OWlBKzVqU3k5LzlPaHFkUEhwL1drdUFLRmx6NWlTWW9zMHhqMW8zVnZGY3Fm?=
 =?utf-8?B?bTJjbXFkdWdweVdUOHdnN2oyUUM1SndENHdUYWpTUEI2RXlFdXZramYzV0I2?=
 =?utf-8?B?NFQ5K2dqQ3R5RURVV3VmdXR6NThVNm1INFN5UUsyODd4bkRFTVJISXQ2bjZW?=
 =?utf-8?Q?/lg2T42dmpmRoPy7E2dILjg=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18ce137f-f4a2-4256-1a26-08d9d6956183
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB0192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 13:05:32.6119
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ulYBrgs1WCg62CwjPCDXY6/Hb4VLB0JNh2JQvWOSrnS1walgJpa8NJtWfXX4GS8J
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5066
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 13.01.22 um 14:00 schrieb Ruhl, Michael J:
>> -----Original Message-----
>> From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of
>> Ruhl, Michael J
>> Sent: Thursday, January 13, 2022 7:58 AM
>> To: guangming.cao@mediatek.com; sumit.semwal@linaro.org
>> Cc: jianjiao.zeng@mediatek.com; lmark@codeaurora.org;
>> wsd_upstream@mediatek.com; christian.koenig@amd.com; linux-
>> kernel@vger.kernel.org; dri-devel@lists.freedesktop.org;
>> yf.wang@mediatek.com; linaro-mm-sig@lists.linaro.org; linux-
>> mediatek@lists.infradead.org; libo.kang@mediatek.com;
>> benjamin.gaignard@linaro.org; bo.song@mediatek.com;
>> matthias.bgg@gmail.com; labbott@redhat.com;
>> mingyuan.ma@mediatek.com; linux-arm-kernel@lists.infradead.org; linux-
>> media@vger.kernel.org
>> Subject: RE: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation
>>
>>
>>> -----Original Message-----
>>> From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of
>>> guangming.cao@mediatek.com
>>> Sent: Thursday, January 13, 2022 7:34 AM
>>> To: sumit.semwal@linaro.org
>>> Cc: linux-arm-kernel@lists.infradead.org; mingyuan.ma@mediatek.com;
>>> Guangming <Guangming.Cao@mediatek.com>;
>>> wsd_upstream@mediatek.com; linux-kernel@vger.kernel.org; dri-
>>> devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org;
>>> yf.wang@mediatek.com; libo.kang@mediatek.com;
>>> benjamin.gaignard@linaro.org; bo.song@mediatek.com;
>>> matthias.bgg@gmail.com; linux-mediatek@lists.infradead.org;
>>> lmark@codeaurora.org; labbott@redhat.com; christian.koenig@amd.com;
>>> jianjiao.zeng@mediatek.com; linux-media@vger.kernel.org
>>> Subject: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation
>>>
>>> From: Guangming <Guangming.Cao@mediatek.com>
>>>
>>> Add a size check for allocation since the allocation size is
>>> always less than the total DRAM size.
>>>
>>> Without this check, once the invalid size allocation runs on a process that
>>> can't be killed by OOM flow(such as "gralloc" on Android devices), it will
>>> cause a kernel exception, and to make matters worse, we can't find who are
>>> using
>>> so many memory with "dma_buf_debug_show" since the relevant dma-buf
>>> hasn't exported.
>>>
>>> To make OOM issue easier, maybe need dma-buf framework to dump the
>>> buffer size
>>> under allocating in "dma_buf_debug_show".
>>>
>>> Signed-off-by: Guangming <Guangming.Cao@mediatek.com>
>>> Signed-off-by: jianjiao zeng <jianjiao.zeng@mediatek.com>
>>> ---
>>> v3: 1. update patch, use right shift to replace division.
>>>     2. update patch, add reason in code and commit message.
>>> v2: 1. update size limitation as total_dram page size.
>>>     2. update commit message
>>> ---
>>> drivers/dma-buf/dma-heap.c | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
>>> index 56bf5ad01ad5..1fd382712584 100644
>>> --- a/drivers/dma-buf/dma-heap.c
>>> +++ b/drivers/dma-buf/dma-heap.c
>>> @@ -55,6 +55,16 @@ static int dma_heap_buffer_alloc(struct dma_heap
>>> *heap, size_t len,
>>> 	struct dma_buf *dmabuf;
>>> 	int fd;
>>>
>>> +	/*
>>> +	 * Invalid size check. The "len" should be less than totalram.
>>> +	 *
>>> +	 * Without this check, once the invalid size allocation runs on a process
>>> that
>>> +	 * can't be killed by OOM flow(such as "gralloc" on Android devices), it
>>> will
>>> +	 * cause a kernel exception, and to make matters worse, we can't find
>>> who are using
>>> +	 * so many memory with "dma_buf_debug_show" since the relevant
>>> dma-buf hasn't exported.
>>> +	 */
>>> +	if (len >> PAGE_SHIFT > totalram_pages())
>> If your "heap" is from cma, is this still a valid check?
> And thinking a bit further, if I create a heap from something else (say device memory),
> you will need to be able to figure out the maximum allowable check for the specific
> heap.
>
> Maybe the heap needs a callback for max size?

Well we currently maintain a separate allocator and don't use dma-heap, 
but yes we have systems with 16GiB device and only 8GiB system memory so 
that check here is certainly not correct.

In general I would rather let the system run into -ENOMEM or -EINVAL 
from the allocator instead.

Regards,
Christian.

>
> m
>> M
>>
>>> +		return -EINVAL;
>>> 	/*
>>> 	 * Allocations from all heaps have to begin
>>> 	 * and end on page boundaries.
>>> --
>>> 2.17.1