From:   Zi Yan <ziy@nvidia.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     Mike Rapoport <rppt@kernel.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christoph Hellwig <hch@lst.de>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linuxppc-dev@lists.ozlabs.org,
        virtualization@lists.linux-foundation.org,
        iommu@lists.linux-foundation.org, Vlastimil Babka <vbabka@suse.cz>,
        Mel Gorman <mgorman@techsingularity.net>,
        Eric Ren <renzhengeek@gmail.com>
Subject: Re: [RFC PATCH v3 1/8] mm: page_alloc: avoid merging non-fallbackable pageblocks with others.
Date:   Thu, 13 Jan 2022 09:50:10 -0500
Message-ID: <AF721DC0-B618-4ECC-8752-87D413E203A7@nvidia.com>
In-Reply-To: <ae2862a0-c39c-ed2f-23fe-510c6c2fad5c@redhat.com>
References: <20220105214756.91065-1-zi.yan@sent.com>
 <20220105214756.91065-2-zi.yan@sent.com>
 <7dc078ef-70f4-159e-b928-34f0fb0ffaea@redhat.com>
 <YeAO0vtyjWWMRliF@kernel.org>
 <ae2862a0-c39c-ed2f-23fe-510c6c2fad5c@redhat.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_B6476F45-E5BF-42AC-977B-6865155E7EC6_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bRc2NSXTAINEwQVXKNEtmSpPqIVpVBzhuMR+/A26tXFQJ33ub6dhW6yjd4Dq?=
 =?us-ascii?Q?yzaEyD1oaR4s4IUmzIBffjuXtQsoJmcu65QM/gwLhOltNYWRhuxeR2TmcE/9?=
 =?us-ascii?Q?syc2IQq7+kq07INF+gKmQcE95wO1n6dTyZTvn1OoopwSsZZbw1mGW+BSKk3N?=
 =?us-ascii?Q?q1K/BdnqxTlg1t8fA41eqvgM1dX9iOu6SAPHIHaxgMUPiYwavuDV0R8o1sLQ?=
 =?us-ascii?Q?rEz6tUWB6+dv6XatwwdGfN4RrvR6zuucoRXxiG1ENWc13Uv3r/k8Kk+wnYIw?=
 =?us-ascii?Q?ygNloQ+k9px5IyJqQh1hZ8xs4zNoV15NT/mKeaVLA5SCpv9qY/17df+BM5RE?=
 =?us-ascii?Q?tnG8iUhmy411xokiqx/iZKwKxUET3O2pDhZPbO3UbOhQco9uUXuLt9vk/rgV?=
 =?us-ascii?Q?zJLhZ1fquQ3WnR+4e3sgEAfnHQtf7olz5/FdNbEl4GQY9ObC9EpviavNDBCD?=
 =?us-ascii?Q?+cLl7VurAUratsR7xXxOuGZH3f+uM5nQGDWSdewlzJwBt1pNybdIIFXeNN8S?=
 =?us-ascii?Q?cb3f1d4HwEOYQnanVU8XMo7YKMKtEUreKsHoD36Gtw2LTQCQp+cKzn4ipcFW?=
 =?us-ascii?Q?UDHxSs6gX8i1/nUEFaeusfowlEaYd5hJMwoPr6Nz2OSycQPHmHmtnX+dPLjG?=
 =?us-ascii?Q?35vjyTvE9FsTr2DvUAnGHg4RsynGy2dAscubYUuCw//hXBeqRKpMiP7EsRia?=
 =?us-ascii?Q?Mbd0G1kZsygTTQvaGB0R9I2WLQNRf2WSyDUKxz5jMmUCuXUpAq57qKzU3QpD?=
 =?us-ascii?Q?90V5DXAMf5PB2vVV2rnLrw3EdCycc4g63JZvVsydqYuMNjXGaivYPDObOyxu?=
 =?us-ascii?Q?WdEKduZQly1z+aaWMqoDgA/wH/OEM9nofYB4HivXtxYvRnWTq4lUYeO89fNx?=
 =?us-ascii?Q?ec3zsYm9cV3jYO/AZIhfpqL5PJfs1GpAOH1LA3EEWNGISriIIEsX64ZD8M4f?=
 =?us-ascii?Q?qYWRUT6VnhMdrghkmq77CjaWgO0Tz02Yx8HQc3ARZz6OhUgN1NgT4/nMZnT1?=
 =?us-ascii?Q?Hs43pd+AIzBUFSMeOAxAFfLreXd95T+pO8h22vmPe6ppfqjRUPY8ObBRq2Rz?=
 =?us-ascii?Q?NU2WxXyR8MAw7Yh4w1qbCrN3CeqgraKFiiFjEY5z9t36APSvfHT42Fl3Xlfp?=
 =?us-ascii?Q?D2tGJPwsoIqf42shirprxRjYhKT43s0V3SAppN3ORyI5CfEeHgK2YasKb04A?=
 =?us-ascii?Q?qk7h2OSNZxcgm6hm8HdZRvUWD3tI5k8O/D78v7KB4S8uQkdbccom1+4z824M?=
 =?us-ascii?Q?Bsqo+zQ9vqRy5CZoLm58TsrA2jDScJOcKF+NzSMDkx1yoNO38uYLvAoWmvlI?=
 =?us-ascii?Q?SldNc3orPHSpy8phbUWc8efa2CkibfmyD7FIlAsYhNXPbhaD7PmjLDQkIuRX?=
 =?us-ascii?Q?EN/IQ982yt+6LxmWrhQ+hu3oNsFHlQfNg/JvYnrOkr7rbtFaNYumQu2tHP1w?=
 =?us-ascii?Q?t14TTooNTTAE3cgO3jNbxR8hNsCAO39+U+48ZeAaUVOS8kx5e/nipMbVCvhc?=
 =?us-ascii?Q?baEfLqfIISTQKuPFST1CpJH7nt4lI+576Zx+Dj+OjkvUiIhv5LkAW7v3EZsX?=
 =?us-ascii?Q?68B0tqlYDlLS+y/Q2S4=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a35e1061-e192-48e8-075d-08d9d6a4006f
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3823.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 14:50:12.1767
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YHE84NbNIDWAJbSqFBmatziF2ajGKFThUN7rvNnVVtJBbjMMvKmV9szuWXVTSM8o
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4577
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_B6476F45-E5BF-42AC-977B-6865155E7EC6_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 13 Jan 2022, at 7:28, David Hildenbrand wrote:

> On 13.01.22 12:36, Mike Rapoport wrote:
>> On Wed, Jan 12, 2022 at 11:54:49AM +0100, David Hildenbrand wrote:
>>> On 05.01.22 22:47, Zi Yan wrote:
>>>> From: Zi Yan <ziy@nvidia.com>
>>>>
>>>> This is done in addition to MIGRATE_ISOLATE pageblock merge avoidanc=
e.
>>>> It prepares for the upcoming removal of the MAX_ORDER-1 alignment
>>>> requirement for CMA and alloc_contig_range().
>>>>
>>>> MIGRARTE_HIGHATOMIC should not merge with other migratetypes like
>>>> MIGRATE_ISOLATE and MIGRARTE_CMA[1], so this commit prevents that to=
o.
>>>> Also add MIGRARTE_HIGHATOMIC to fallbacks array for completeness.
>>>>
>>>> [1] https://lore.kernel.org/linux-mm/20211130100853.GP3366@techsingu=
larity.net/
>>>>
>>>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>>>> ---
>>>>  include/linux/mmzone.h |  6 ++++++
>>>>  mm/page_alloc.c        | 28 ++++++++++++++++++----------
>>>>  2 files changed, 24 insertions(+), 10 deletions(-)
>>>>
>>
>> ...
>>
>>>> @@ -3545,8 +3553,8 @@ int __isolate_free_page(struct page *page, uns=
igned int order)
>>>>  		struct page *endpage =3D page + (1 << order) - 1;
>>>>  		for (; page < endpage; page +=3D pageblock_nr_pages) {
>>>>  			int mt =3D get_pageblock_migratetype(page);
>>>> -			if (!is_migrate_isolate(mt) && !is_migrate_cma(mt)
>>>> -			    && !is_migrate_highatomic(mt))
>>>> +			/* Only change normal pageblock */
>>>> +			if (migratetype_has_fallback(mt))
>>>>  				set_pageblock_migratetype(page,
>>>>  							  MIGRATE_MOVABLE);
>>>>  		}
>>>
>>> That part is a nice cleanup IMHO. Although the "has fallback" part is=
 a
>>> bit imprecise. "migratetype_is_mergable()" might be a bit clearer.
>>> ideally "migratetype_is_mergable_with_other_types()". Can we come up
>>> with a nice name for that?
>>
>> migratetype_is_mergable() kinda implies "_with_other_types", no?
>>
>> I like migratetype_is_mergable() more than _has_fallback().
>>
>> My $0.02 to bikeshedding :)
>
> :)
>
> Yeah, for me migratetype_is_mergable() would also be good enough. I
> think I was at first thinking one could mistake it with a dedicated
> migratetype. But such functions are historically called
>
> is_migrate_cma/is_migrate_cma/....
>
> -- =

> Thanks,
>
> David / dhildenb

OK. Will use migratetype_is_mergable() instead.


--
Best Regards,
Yan, Zi

--=_MailMate_B6476F45-E5BF-42AC-977B-6865155E7EC6_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmHgPCIPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqKNzwQAKcwq2cFFnNvugkk7N/YRv61E1LZSEnqVGH3
UoAT/0Yq/+870HXu5JP7joE9O2tdxNXpMUKxbD/FbTuyMl0iaOB9GDtt1cf0l7z2
quluao4+fbtsaLuOjN12Rkzyb6AjZsCcgLvUy1uJzTA0SmagzJNEaKT/Z3FjQKXi
94nvQkJ3QuQTVR2KxnPbBDBE7edKZ5s7MnlTeiv9jU6J0TJElR/pZHlzwBvYVY9t
9yhUGsKeDGerXLoRFpVN2Yr7VH9t3VaA4KNADv9Ns7bZSWJBtoJlBmzXq0Qq5Sys
/w1wbE4z8BP2/RhZtDvfuWm/ObujjoBT3cv7D2QnXmX3jOgwzLItIGiGmhAyAEPq
2DJWTLDFMQzrDqLvMyR4hNUO+5o5bYYvfIPTc5ajg4aKimfZYxWI+PiOzy9d9Xrf
YIs5vDiBZFtO6LUaUsv30UUqR7j2j1go8uAemO3nFl2VdwrfU9ccWsNFNhNQTZKg
LvIFB+xi75r6GFy1qXQe+ou6aNAVBoBkxO5YQa3kHibz/fu0cHM2poMkalnKqUUU
ndnHeKFuICA9e36dVehbqLyVo4qiF76djhkk41hktMJKzkk6pUdz1+J09ISq60iL
SozH2PeXJtD9bIThPzD0zFaJeVrLjj1F9xKdg64g5ez8bZGm6Dd+ByRl1wYqyWSc
vouSamwp
=KkJj
-----END PGP SIGNATURE-----

--=_MailMate_B6476F45-E5BF-42AC-977B-6865155E7EC6_=--