Message-ID: <8bde7cdc-6bd5-d50e-ea44-dfb480b88ca0@gmail.com>
Date:   Thu, 13 Jan 2022 08:21:26 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [PATCH v2 2/2] selftests: add option to list all available tests
Content-Language: en-US
To:     "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "shuah@kernel.org" <shuah@kernel.org>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20211202022954.23545-1-lizhijian@cn.fujitsu.com>
 <20211202022954.23545-2-lizhijian@cn.fujitsu.com>
 <b76c51c6-80b6-c3ec-f416-f5e48aa5a6c5@fujitsu.com>
From:   David Ahern <dsahern@gmail.com>
In-Reply-To: <b76c51c6-80b6-c3ec-f416-f5e48aa5a6c5@fujitsu.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/12/22 10:53 PM, lizhijian@fujitsu.com wrote:
> ping

seems to have been lost in the void

> 
> 
> On 02/12/2021 10:29, Li Zhijian wrote:
>> $ ./fcnal-test.sh -l
>> Test names: ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter
>> ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter
>> use_cases
>>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> ---
>>   tools/testing/selftests/net/fcnal-test.sh | 9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
>> index 5cb59947eed2..7e78be99aa4c 100755
>> --- a/tools/testing/selftests/net/fcnal-test.sh
>> +++ b/tools/testing/selftests/net/fcnal-test.sh
>> @@ -3993,6 +3993,7 @@ usage: ${0##*/} OPTS
>>   	-4          IPv4 tests only
>>   	-6          IPv6 tests only
>>   	-t <test>   Test name/set to run
>> +	-l          List all available tests
>>   	-p          Pause on fail
>>   	-P          Pause after each test
>>   	-v          Be verbose
>> @@ -4006,10 +4007,15 @@ TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter"
>>   TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter"
>>   TESTS_OTHER="use_cases"
>>   
>> +list()
>> +{
>> +	echo "Test names: $TESTS_IPV4 $TESTS_IPV6 $TESTS_OTHER"
>> +}

Just add the test list at the end of usage() like this:

@@ -4019,6 +4019,9 @@ usage: ${0##*/} OPTS
        -p          Pause on fail
        -P          Pause after each test
        -v          Be verbose
+
+Tests:
+       $TESTS_IPV4 $TESTS_IPV6 $TESTS_OTHER
 EOF
 }